Fix for bug 1974: drop unnecessary define_syslog_variables() call from common.php

The call was moved to this spot in commit 3ea1119e500c23ee918569e2a58cc5abaa1d8a5a (previously init'd later in another func) but doesn't seem to be needed anyway. None of our code uses the variables that this function defines, just the constants -- which are already predefined without the call.

The function is deprecated in PHP 5.3 and gone in 6, so we may as well toss it now.

diff --git a/lib/common.php b/lib/common.php
index 4958866d030f5c2093f5c01a4894de11f3461386..fbe4216e3d498185af8b38d940a669cdc313f6ec 100644 (file)
--- a/lib/common.php
+++ b/lib/common.php
@@ -38,8 +38,6 @@ define('FOREIGN_NOTICE_SEND_REPLY', 4);
 define('FOREIGN_FRIEND_SEND', 1);
 define('FOREIGN_FRIEND_RECV', 2);
 
-define_syslog_variables();
-
 # append our extlib dir as the last-resort place to find libs
 
 set_include_path(get_include_path() . PATH_SEPARATOR . INSTALLDIR . '/extlib/');