Fixed 'last' array, TODOs.txt updated

diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt
index 6d62421ec2af347845d36d5f4a4242ce06c4925b..90ad79fc8670f60be4c0ae1fd23e072ca1e322a5 100644 (file)
--- a/DOCS/TODOs.txt
+++ b/DOCS/TODOs.txt
@@ -1,7 +1,7 @@
 ### WARNING: THIS FILE IS AUTO-GENERATED BY DOCS/todo-builder.sh (1000/quix0r) ###
 ### DO NOT EDIT THIS FILE. ###
-./beg.php:197:                 // @TODO Opps, what is missing here???
-./doubler.php:275:// @TODO Rewrite all constants
+./beg.php:195:                 // @TODO Opps, what is missing here???
+./doubler.php:269:// @TODO Rewrite all constants
 ./inc/cache/config-local.php:120:// @TODO Rewrite the following three constants, somehow...
 ./inc/config-functions.php:182:        // @TODO Make this all better... :-/
 ./inc/config-functions.php:207:        // @TODO Rewrite these all to config entries, if somehow possible
@@ -77,7 +77,8 @@
 ./inc/modules/admin/what-admin_add.php:121:                            // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-admin_add.php:62:             // @TODO Cant this be rewritten?
 ./inc/modules/admin/what-admin_add.php:78:             // @TODO This can be somehow rewritten to a function
-./inc/modules/admin/what-adminedit.php:250:            // @TODO Rewrite this constant
+./inc/modules/admin/what-adminedit.php:238:            // @TODO Rewrite this constant
+./inc/modules/admin/what-adminedit.php:62:     // @TODO Kill all constants in this file
 ./inc/modules/admin/what-admins_mails.php:100:         // @TODO Rewrite this constant
 ./inc/modules/admin/what-admins_mails.php:173:         // @TODO Rewrite this constant
 ./inc/modules/admin/what-admins_mails.php:61:                          // @TODO Can this be rewritten???
@@ -200,32 +201,33 @@
 ./inc/modules/member/what-transfer.php:364:            // @TODO Rewrite these constants
 ./inc/modules/member/what-transfer.php:451:                            // @TODO Rewrite all these constants
 ./inc/modules/member/what-unconfirmed.php:134: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
-./inc/mysql-manager.php:1552:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
-./inc/mysql-manager.php:1595:                  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1773:                          // @TODO Find a way for updating $_CONFIG here
-./inc/mysql-manager.php:1797:          // @TODO Find a way for updating $_CONFIG here
-./inc/mysql-manager.php:1820:// @TODO Can this be rewritten to a filter?
-./inc/mysql-manager.php:1882:                  // @TODO Rewrite this to $content = SQL_FETCHARRAY()
+./inc/mysql-manager.php:1555:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
+./inc/mysql-manager.php:1598:                  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1776:                          // @TODO Find a way for updating $_CONFIG here
+./inc/mysql-manager.php:1800:          // @TODO Find a way for updating $_CONFIG here
+./inc/mysql-manager.php:1823:// @TODO Can this be rewritten to a filter?
+./inc/mysql-manager.php:1885:                  // @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/mysql-manager.php:199:                   // @TODO Nothing helped???
-./inc/mysql-manager.php:2176:          // @TODO This can be somehow rewritten
+./inc/mysql-manager.php:2179:          // @TODO This can be somehow rewritten
 ./inc/mysql-manager.php:513:   // @TODO Why is this global??? #100
-./inc/mysql-manager.php:950:                   // @TODO Why does this lead into an endless loop but we still need it???
-./inc/mysql-manager.php:951:                   // @TODO Commented out redirectToUrl('admin.php');
+./inc/mysql-manager.php:517:   // @TODO Try to rewrite this to one or more functions
+./inc/mysql-manager.php:953:                   // @TODO Why does this lead into an endless loop but we still need it???
+./inc/mysql-manager.php:954:                   // @TODO Commented out redirectToUrl('admin.php');
 ./inc/wrapper-functions.php:152:// @TODO Implement $compress
 ./inc/wrapper-functions.php:159:// @TODO Implement $decompress
 ./inc/wrapper-functions.php:391:// @TODO Do some more sanity check here
-./mailid.php:140:                                      // @TODO Rewrite this to a filter
-./mailid.php:185:                                                      // @TODO Rewrite these constants
-./mailid.php:221:      // @TODO Rewrite this to a filter
-./mailid.php:96:               // @TODO Rewrite this to a filter
-./mailid_top.php:137:                                  // @TODO Rewrite this to a filter
-./mailid_top.php:184:                                                  // @TODO Rewrite this to a filter
-./mailid_top.php:191:                                                                  // @TODO Rewrite this to a filter
-./mailid_top.php:224:                                                                  // @TODO Rewrite these constants
-./mailid_top.php:229:                                                                  // @TODO Rewrite these blocks to filter
-./mailid_top.php:90:           // @TODO Rewrite this to a filter
-./show_bonus.php:106:                  // @TODO Rewrite this constant
-./surfbar.php:69:      // @TODO Display quick login form here or redirect as configured
+./mailid.php:139:                                      // @TODO Rewrite this to a filter
+./mailid.php:184:                                                      // @TODO Rewrite these constants
+./mailid.php:220:      // @TODO Rewrite this to a filter
+./mailid.php:95:               // @TODO Rewrite this to a filter
+./mailid_top.php:136:                                  // @TODO Rewrite this to a filter
+./mailid_top.php:183:                                                  // @TODO Rewrite this to a filter
+./mailid_top.php:190:                                                                  // @TODO Rewrite this to a filter
+./mailid_top.php:223:                                                                  // @TODO Rewrite these constants
+./mailid_top.php:228:                                                                  // @TODO Rewrite these blocks to filter
+./mailid_top.php:89:           // @TODO Rewrite this to a filter
+./show_bonus.php:104:                  // @TODO Rewrite this constant
+./surfbar.php:67:      // @TODO Display quick login form here or redirect as configured
 ### ### DEPRECATION FOLLOWS: ### ###
 ./inc/functions.php:235:       // @DEPRECATED Try to rewrite the if() condition
 ./inc/functions.php:249:                       // @DEPRECATED

diff --git a/inc/mysql-manager.php b/inc/mysql-manager.php
index 9fc243f21403d3acd2326267c07def46c4101a92..2fdeaa1ad8d9bae3074329f02eb28e5863af8e32 100644 (file)
--- a/inc/mysql-manager.php
+++ b/inc/mysql-manager.php
@@ -513,7 +513,10 @@ function IS_MEMBER () {
        // @TODO Why is this global??? #100
        global $status;
 
-       if (!is_array($GLOBALS['last'])) $GLOBALS['last'] = array();
+       // Fix missing 'last' array, damn stupid code :(((
+       // @TODO Try to rewrite this to one or more functions
+       if ((!isset($GLOBALS['last'])) || (!is_array($GLOBALS['last']))) $GLOBALS['last'] = array();
+
        $ret = false;
 
        // is the cache entry there?