bogus version of common_local_url()

Threw together a bogus version of common_local_url(), which should
work for now. But eventually it should use pretty URLs if possible.

darcs-hash:20080517135138-84dde-3c69c89ee8080568e92f655cbb3171867a7b38ce.gz

diff --git a/doc/TODO b/doc/TODO
index 08df348e2f8297c797f40bb985996b020f7d7fda..1eaad981a1f2f7ca01ef735e061f16d68c3edb86 100644 (file)
--- a/doc/TODO
+++ b/doc/TODO
@@ -18,11 +18,11 @@
 + header menu
 + footer menu
 + disallow direct to PHP files
++ common_local_url()
 - require valid nicknames
 - store canonical username for comparison and fetch
 - use only canonical usernames
 - use only canonical email addresses
-- common_local_url()
 - configuration system ($config)
 - RSS 1.0 feeds of a user's notices
 - RSS 1.0 dump of a user's notices
@@ -33,7 +33,14 @@
 - license on shownotice
 - design from Open Source Web Designs
 - TOS checkbox on register
+- pretty URLs
 - release 0.1
+- content negotiation for interface language
+- content negotiation for content type
+- content negotiation for encoding
+- content negotiation for charset
+- If-Modified-Since support
+- Vary
 - delete a notice
 - gettext
 - subscribe remote

diff --git a/lib/common.php b/lib/common.php
index b4c2f9b6e7e24ad60bdc1911700353a63fa6244a..2625d08ef4652328320af618126ed99f563e2530 100644 (file)
--- a/lib/common.php
+++ b/lib/common.php
@@ -17,6 +17,9 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/* XXX: break up into separate modules (HTTP, HTML, user, files) */
+
+
 if (!defined('LACONICA')) { exit(1) }
 
 define('AVATAR_PROFILE_SIZE', 96);
@@ -254,6 +257,16 @@ function common_avatar_url($filename) {
        return $config['avatar']['path'] . '/' . $filename;
 }
 
+function common_local_url($action, $args) {
+       /* XXX: pretty URLs */
+       $extra = '';
+       foreach ($args as $key => $value) {
+               $extra .= "&${key}=${value}";
+       }
+       /* XXX: correct path */
+       return "/index.php?action=${action}${extra}";
+}
+
 // XXX: set up gettext
 
 function _t($str) { $str }