Improve ForumManager::profileAdvanced logic

diff --git a/src/Content/ForumManager.php b/src/Content/ForumManager.php
index f3f3392ec189c907ef77be4cd3f8723c70dca2a7..ce945aa1d6bbfa90e8c966f209e9e42fecd009be 100644 (file)
--- a/src/Content/ForumManager.php
+++ b/src/Content/ForumManager.php
@@ -5,8 +5,8 @@
  */
 namespace Friendica\Content;
 
-use Friendica\Core\Protocol;
 use Friendica\Content\Text\HTML;
+use Friendica\Core\Protocol;
 use Friendica\Core\Renderer;
 use Friendica\Database\DBA;
 use Friendica\DI;
@@ -152,8 +152,8 @@ class ForumManager
        public static function profileAdvanced($uid)
        {
                $profile = intval(Feature::isEnabled($uid, 'forumlist_profile'));
-               if (! $profile) {
-                       return;
+               if (!$profile) {
+                       return '';
                }
 
                $o = '';
@@ -167,19 +167,15 @@ class ForumManager
                $contacts = self::getList($uid, $lastitem, false, false);
 
                $total_shown = 0;
-               $forumlist = '';
                foreach ($contacts as $contact) {
-                       $forumlist .= HTML::micropro($contact, true, 'forumlist-profile-advanced');
-                       $total_shown ++;
+                       $o .= HTML::micropro($contact, true, 'forumlist-profile-advanced');
+                       $total_shown++;
                        if ($total_shown == $show_total) {
                                break;
                        }
                }
 
-               if (count($contacts) > 0) {
-                       $o .= $forumlist;
-                       return $o;
-               }
+               return $o;
        }
 
        /**