updateKeys (for classes with PRI id) now in Managed_DataObject

diff --git a/classes/Foreign_user.php b/classes/Foreign_user.php
index ec36dc342356db720e7ce37fe9265c6aada4f92d..eeaf817876b7ff8ead28c47cb6e82bc6cf3d621a 100644 (file)
--- a/classes/Foreign_user.php
+++ b/classes/Foreign_user.php
@@ -70,33 +70,4 @@ class Foreign_user extends Managed_DataObject
             return empty($result) ? null : $fuser;
         }
     }
-
-    function updateKeys(&$orig)
-    {
-        $this->_connect();
-        $parts = array();
-        foreach (array('id', 'service', 'uri', 'nickname') as $k) {
-            if (strcmp($this->$k, $orig->$k) != 0) {
-                $parts[] = $k . ' = ' . $this->_quote($this->$k);
-            }
-        }
-        if (count($parts) == 0) {
-            // No changes
-            return true;
-        }
-        $toupdate = implode(', ', $parts);
-
-        $table = $this->tableName();
-        if(common_config('db','quote_identifiers')) {
-            $table = '"' . $table . '"';
-        }
-        $qry = 'UPDATE ' . $table . ' SET ' . $toupdate .
-          ' WHERE id = ' . $this->id;
-        $orig->decache();
-        $result = $this->query($qry);
-        if ($result) {
-            $this->encache();
-        }
-        return $result;
-    }
 }

diff --git a/classes/Managed_DataObject.php b/classes/Managed_DataObject.php
index 531232332dd24e0889bf1f61250db7ac79e12976..d20d3cc27ea2dc65f17036ec0aee4820ce72cd63 100644 (file)
--- a/classes/Managed_DataObject.php
+++ b/classes/Managed_DataObject.php
@@ -320,4 +320,35 @@ abstract class Managed_DataObject extends Memcached_DataObject
         // FIXME: How about forcing to return an int? Or will that overflow eventually?
         return $this->id;
     }
+
+    // 'update' won't write key columns, so we have to do it ourselves.
+    public function updateKeys(&$orig)
+    {
+        if (!$orig instanceof $this) {
+            throw new ServerException('Tried updating a DataObject with a different class than itself.');
+        }
+
+        $this->_connect();
+        $parts = array();
+        foreach ($this->keys() as $k) {
+            if (strcmp($this->$k, $orig->$k) != 0) {
+                $parts[] = $k . ' = ' . $this->_quote($this->$k);
+            }
+        }
+        if (count($parts) == 0) {
+            // No changes
+            return true;
+        }
+        $toupdate = implode(', ', $parts);
+
+        $table = common_database_tablename($this->tableName());
+        $qry = 'UPDATE ' . $table . ' SET ' . $toupdate .
+          ' WHERE id = ' . $this->getID();
+        $orig->decache();
+        $result = $this->query($qry);
+        if ($result !== false) {
+            $this->encache();
+        }
+        return $result;
+    }
 }

diff --git a/classes/User.php b/classes/User.php
index 242873efe17ba908bb66aac9ac69710b86e68a5b..060a67411d54b68492adf9f229fc2c792ef890a7 100644 (file)
--- a/classes/User.php
+++ b/classes/User.php
@@ -152,34 +152,6 @@ class User extends Managed_DataObject
         return $this->getProfile()->hasPendingSubscription($other);
     }
 
-    // 'update' won't write key columns, so we have to do it ourselves.
-
-    function updateKeys(&$orig)
-    {
-        $this->_connect();
-        $parts = array();
-        foreach (array('nickname', 'email', 'incomingemail', 'sms', 'carrier', 'smsemail') as $k) {
-            if (strcmp($this->$k, $orig->$k) != 0) {
-                $parts[] = $k . ' = ' . $this->_quote($this->$k);
-            }
-        }
-        if (count($parts) == 0) {
-            // No changes
-            return true;
-        }
-        $toupdate = implode(', ', $parts);
-
-        $table = common_database_tablename($this->tableName());
-        $qry = 'UPDATE ' . $table . ' SET ' . $toupdate .
-          ' WHERE id = ' . $this->id;
-        $orig->decache();
-        $result = $this->query($qry);
-        if ($result) {
-            $this->encache();
-        }
-        return $result;
-    }
-
     /**
      * Get the most recent notice posted by this user, if any.
      *