Continued:

- private and final together doesn't make any sense since PHP has fixed a lot
  of internal wrong handling a VERY long time ago ...

diff --git a/framework/main/classes/database/backend/lfdb_legacy/class_CachedLocalFileDatabase.php b/framework/main/classes/database/backend/lfdb_legacy/class_CachedLocalFileDatabase.php
index b82baad5ff36d5966d0c7005dba324fd4db72e10..d693aced24a80183f8461fa81d9bef69c3da9c61 100644 (file)
--- a/framework/main/classes/database/backend/lfdb_legacy/class_CachedLocalFileDatabase.php
+++ b/framework/main/classes/database/backend/lfdb_legacy/class_CachedLocalFileDatabase.php
@@ -135,7 +135,7 @@ class CachedLocalFileDatabase extends BaseDatabaseBackend implements DatabaseBac
         * @param       $infoInstance   The FQFN of the last read file
         * @return      void
         */
-       private final function setLastFile (SplFileInfo $infoInstance) {
+       private function setLastFile (SplFileInfo $infoInstance) {
                // Cast string and set it
                $this->lastFile = $infoInstance;
        }
@@ -155,7 +155,7 @@ class CachedLocalFileDatabase extends BaseDatabaseBackend implements DatabaseBac
         * @param               $contents       An array with header and data elements
         * @return      void
         */
-       private final function setLastFileContents (array $contents) {
+       private function setLastFileContents (array $contents) {
                // Set array
                $this->lastContents = $contents;
        }

diff --git a/framework/main/classes/database/frontend/class_BaseDatabaseFrontend.php b/framework/main/classes/database/frontend/class_BaseDatabaseFrontend.php
index 78665d33715e5b278c642266ba10edaa117a4890..525b7efca7800df85063c588e13c5dcef793ea5f 100644 (file)
--- a/framework/main/classes/database/frontend/class_BaseDatabaseFrontend.php
+++ b/framework/main/classes/database/frontend/class_BaseDatabaseFrontend.php
@@ -74,7 +74,7 @@ abstract class BaseDatabaseFrontend extends BaseFrameworkSystem {
         *
         * @return      void
         */
-       private final function initCacheInstance () {
+       private function initCacheInstance () {
                // Set "cache" attributes
                //* NOISY-DEBUG: */ self::createDebugInstance(__CLASS__, __LINE__)->traceMessage('BASE-DATABASE-FRONTEND: CALLED!');
                $this->databaseCacheEnabled = FrameworkBootstrap::getConfigurationInstance()->isEnabled('database_cache');

diff --git a/framework/main/classes/decorator/xml/compactor/class_XmlCompactorDecorator.php b/framework/main/classes/decorator/xml/compactor/class_XmlCompactorDecorator.php
index 9fc7d1a7fa68fd9576598de651feefb7fe9c67d1..6d7b016531811848615d89bd4df07426eb46d818 100644 (file)
--- a/framework/main/classes/decorator/xml/compactor/class_XmlCompactorDecorator.php
+++ b/framework/main/classes/decorator/xml/compactor/class_XmlCompactorDecorator.php
@@ -83,7 +83,7 @@ class XmlCompactorDecorator extends BaseDecorator implements Parseable {
         *
         * @return      $parserInstance An instance of an Parseable
         */
-       private final function getParserInstance () {
+       private function getParserInstance () {
                return $this->parserInstance;
        }
 

diff --git a/framework/main/classes/images/class_BaseImage.php b/framework/main/classes/images/class_BaseImage.php
index a6f8faa5ef64b30a446a2da7119f70af8fded6a5..76871d1b1fb5e2a4f037fa85e4947163cbd8da5a 100644 (file)
--- a/framework/main/classes/images/class_BaseImage.php
+++ b/framework/main/classes/images/class_BaseImage.php
@@ -125,7 +125,7 @@ abstract class BaseImage extends BaseFrameworkSystem implements Registerable {
         * @param       $colorChannel   Red, green or blue channel?
         * @param       $colorValue             Value to set
         */
-       private final function setColor (string $colorMode, string $colorChannel, $colorValue) {
+       private function setColor (string $colorMode, string $colorChannel, $colorValue) {
                // Construct the eval() command
                $eval = sprintf("\$this->%s['%s'] = \"%s\";",
                        $colorMode,

diff --git a/framework/main/classes/mailer/class_BaseMailer.php b/framework/main/classes/mailer/class_BaseMailer.php
index dd95136132f1b4d3064a09977c57929cc0a57c81..840bb616b8bdafb4a5ae340ca4d9491e54a81268 100644 (file)
--- a/framework/main/classes/mailer/class_BaseMailer.php
+++ b/framework/main/classes/mailer/class_BaseMailer.php
@@ -89,7 +89,7 @@ abstract class BaseMailer extends BaseFrameworkSystem {
         * @param       $variableName   Template variable name to add
         * @return      void
         */
-       private final function addTemplateVariable ($section, $variableName) {
+       private function addTemplateVariable ($section, $variableName) {
                // Get template name
                $templateName = $this->getTemplateName();
 

diff --git a/framework/main/classes/template/class_BaseTemplateEngine.php b/framework/main/classes/template/class_BaseTemplateEngine.php
index dccbddc41df98b31ab945f89005e05fad5c9bb28..f428be61f410dc87f29f8e250a2ed9c23d1ee252 100644 (file)
--- a/framework/main/classes/template/class_BaseTemplateEngine.php
+++ b/framework/main/classes/template/class_BaseTemplateEngine.php
@@ -633,7 +633,7 @@ abstract class BaseTemplateEngine extends BaseFrameworkSystem {
         * @param       $template       The last loaded template
         * @return      void
         */
-       private final function setLastTemplate (SplFileInfo $fileInstance) {
+       private function setLastTemplate (SplFileInfo $fileInstance) {
                $this->lastTemplate = $fileInstance;
        }
 
@@ -642,7 +642,7 @@ abstract class BaseTemplateEngine extends BaseFrameworkSystem {
         *
         * @return      $template       The last loaded template
         */
-       private final function getLastTemplate () {
+       private function getLastTemplate () {
                return $this->lastTemplate;
        }
 
@@ -803,7 +803,7 @@ abstract class BaseTemplateEngine extends BaseFrameworkSystem {
         * @param       $compiledData   Compiled template data
         * @return      void
         */
-       private final function setCompiledData (string $compiledData) {
+       private function setCompiledData (string $compiledData) {
                // And store it in this class
                $this->compiledData = $compiledData;
        }

diff --git a/framework/main/classes/template/menu/class_MenuTemplateEngine.php b/framework/main/classes/template/menu/class_MenuTemplateEngine.php
index e7e932a5849233003447b7b0edc0ed26ff09c1f9..53febfd625e824184b783a20f2d07e729b297c7a 100644 (file)
--- a/framework/main/classes/template/menu/class_MenuTemplateEngine.php
+++ b/framework/main/classes/template/menu/class_MenuTemplateEngine.php
@@ -216,7 +216,7 @@ class MenuTemplateEngine extends BaseTemplateEngine implements CompileableTempla
         *
         * @return      $menuInstance   A RenderableMenu instance
         */
-       private final function getMenuInstance () {
+       private function getMenuInstance () {
                return $this->menuInstance;
        }
 
@@ -250,7 +250,7 @@ class MenuTemplateEngine extends BaseTemplateEngine implements CompileableTempla
         * @param       $element                Element name to set as current main node
         * @return      $currMainNode   Current main node
         */
-       private final function setCurrMainNode (string $element) {
+       private function setCurrMainNode (string $element) {
                $this->curr['main_node'] = $element;
        }
 

diff --git a/framework/main/classes/template/xml/class_BaseXmlTemplateEngine.php b/framework/main/classes/template/xml/class_BaseXmlTemplateEngine.php
index 0b7cb3790dcb49d483bfb605e504536d861fe2cc..bc53481c7cfa69b6b3beaaac257f568da73765aa 100644 (file)
--- a/framework/main/classes/template/xml/class_BaseXmlTemplateEngine.php
+++ b/framework/main/classes/template/xml/class_BaseXmlTemplateEngine.php
@@ -235,7 +235,7 @@ abstract class BaseXmlTemplateEngine extends BaseTemplateEngine implements Compi
         * @param       $element                Element name to set as current main node
         * @return      $currMainNode   Current main node
         */
-       private final function setCurrMainNode (string $element) {
+       private function setCurrMainNode (string $element) {
                $this->curr['main_node'] = $element;
        }
 

diff --git a/framework/main/exceptions/class_FrameworkException.php b/framework/main/exceptions/class_FrameworkException.php
index c08687a23ec5665a14bf48e82c54a8a3b8f3ca8b..7852a066079ed3a33771f38d8a6a8fac7535b8c7 100644 (file)
--- a/framework/main/exceptions/class_FrameworkException.php
+++ b/framework/main/exceptions/class_FrameworkException.php
@@ -85,7 +85,7 @@ abstract class FrameworkException extends ReflectionException {
         *
         * @return      void
         */
-       private final function saveBackTrace () {
+       private function saveBackTrace () {
                // Get full backtrace
                $this->backTrace = debug_backtrace();
 

diff --git a/framework/main/middleware/database/class_DatabaseConnection.php b/framework/main/middleware/database/class_DatabaseConnection.php
index b64d518926b7b0114747e2bd8ad26901e0143575..2b18d36bfe515e2d75a73b5493be95494d334fdb 100644 (file)
--- a/framework/main/middleware/database/class_DatabaseConnection.php
+++ b/framework/main/middleware/database/class_DatabaseConnection.php
@@ -104,7 +104,7 @@ class DatabaseConnection extends BaseMiddleware implements DatabaseConnector, Re
         * @param       $backendInstance        An instance of a DatabaseBackend class
         * @return      void
         */
-       private final function setBackendInstance (DatabaseBackend $backendInstance) {
+       private function setBackendInstance (DatabaseBackend $backendInstance) {
                $this->backendInstance = $backendInstance;
        }