[twitter] Abort follow process on API call failure

- Prevents users without a connected Twitter account from visibly following a Twitter contact

diff --git a/twitter/twitter.php b/twitter/twitter.php
index 33af5663f2b5ea107bce4b7cc785a97717cd4ddb..d9f1310aa32b5f32f608ebe3abd9626d4fb48299 100644 (file)
--- a/twitter/twitter.php
+++ b/twitter/twitter.php
@@ -157,7 +157,10 @@ function twitter_follow(App $a, array &$contact)
 
        $uid = $a->getLoggedInUserId();
 
-       twitter_api_contact('friendships/create', ['network' => Protocol::TWITTER, 'nick' => $nickname], $uid);
+       if (!twitter_api_contact('friendships/create', ['network' => Protocol::TWITTER, 'nick' => $nickname], $uid)) {
+               $contact = null;
+               return;
+       }
 
        $user = twitter_fetchuser($nickname);