Ugly hack to show thumbnails of otherwise unrepresentable attachments

such as text/html, where the thumbnail has been retrieved via oEmbed/OpenGraph

diff --git a/lib/attachmentlistitem.php b/lib/attachmentlistitem.php
index 2d484fb6a8e1de797c572305edec477a850d2d6d..8adc07e6db7c59bd1c7ab40d8a245d3e6f0a0364 100644 (file)
--- a/lib/attachmentlistitem.php
+++ b/lib/attachmentlistitem.php
@@ -129,6 +129,12 @@ class AttachmentListItem extends Widget
                 if ($this->attachment->mimetype === 'application/ogg') {
                     $mediatype = 'video';   // because this element can handle Ogg/Vorbis etc. on its own
                 }
+
+                // Ugly hack to show text/html links which have a thumbnail (such as from oEmbed/OpenGraph image URLs)
+                if (!in_array($mediatype, ['image','audio','video']) && $thumb instanceof File_thumbnail) {
+                    $mediatype = 'image';
+                }
+
                 switch ($mediatype) {
                 // Anything we understand as an image, if we need special treatment, do it in StartShowAttachmentRepresentation
                 case 'image':