Fix scrollToItem breaking dropItem functionality

- Add doc
- Refactor function by removing double jQuery wrapping

diff --git a/view/theme/frio/js/theme.js b/view/theme/frio/js/theme.js
index b4ba2fd357d7ff7366718b3db2b221149f5b2b7d..62cd85df9b53975e96ced89b868c78a489cae9ff 100644 (file)
--- a/view/theme/frio/js/theme.js
+++ b/view/theme/frio/js/theme.js
@@ -573,31 +573,38 @@ String.prototype.rtrim = function() {
        return trimmed;
 };
 
-// Scroll to a specific item and highlight it
-// Note: jquery.color.js is needed
-function scrollToItem(itemID) {
-       if( typeof itemID === "undefined")
+/**
+ * Scroll the screen to the item element whose id is provided, then highlights it
+ *
+ * Note: jquery.color.js is required
+ *
+ * @param {string} elementId The item element id
+ * @returns {undefined}
+ */
+function scrollToItem(elementId) {
+       if (typeof elementId === "undefined") {
                return;
+       }
 
-       var elm = $('#'+itemID);
+       var $el = $(document.getElementById(elementId));
        // Test if the Item exists
-       if(!elm.length)
+       if (!$el.length) {
                return;
+       }
 
        // Define the colors which are used for highlighting
        var colWhite = {backgroundColor:'#F5F5F5'};
        var colShiny = {backgroundColor:'#FFF176'};
 
-       // Get the Item Position (we need to substract 100 to match
-       // correct position
-       var itemPos = $(elm).offset().top - 100;
+       // Get the Item Position (we need to substract 100 to match correct position
+       var itemPos = $el.offset().top - 100;
 
        // Scroll to the DIV with the ID (GUID)
        $('html, body').animate({
                scrollTop: itemPos
        }, 400, function() {
                // Highlight post/commenent with ID  (GUID)
-               $(elm).animate(colWhite, 1000).animate(colShiny).animate(colWhite, 600);
+               $el.animate(colWhite, 1000).animate(colShiny).animate(colWhite, 600);
        });
 }
 

diff --git a/view/theme/frio/templates/wall_thread.tpl b/view/theme/frio/templates/wall_thread.tpl
index 1977f541c231562bad5b0d529b1ac3fb811f8ed8..e71dc7b84c336fb3b2d3dcb7ee1216614449f40e 100644 (file)
--- a/view/theme/frio/templates/wall_thread.tpl
+++ b/view/theme/frio/templates/wall_thread.tpl
@@ -68,9 +68,9 @@ as the value of $top_child_total (this is done at the end of this file)
 
 {{* Use a different div container in dependence max thread-level = 7 *}}
 {{if $item.thread_level<7}}
-<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_{{$item.thread_level}} {{if $item.thread_level==1}}panel-body h-entry{{else}}u-comment h-cite{{/if}}" id="item-{{$item.guid|regex_replace:'/%.*/':''}}"><!-- wall-item-container -->
+<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_{{$item.thread_level}} {{if $item.thread_level==1}}panel-body h-entry{{else}}u-comment h-cite{{/if}}" id="item-{{$item.guid}}"><!-- wall-item-container -->
 {{else}}
-<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_7 u-comment h-cite" id="item-{{$item.guid|regex_replace:'/%.*/':''}}">
+<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_7 u-comment h-cite" id="item-{{$item.guid}}">
  {{/if}}
        <div class="media">
                {{* Put addional actions in a top-right dropdown menu *}}