From: Michael <heluecht@pirati.ca>
Date: Sun, 19 May 2019 08:54:26 +0000 (+0000)
Subject: Fixed contact suggestion
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=14d4132ad02334bcc22e503290cada91f3d67967;p=friendica.git

Fixed contact suggestion
---

diff --git a/mod/fsuggest.php b/mod/fsuggest.php
index 58bb116700..e84a8bd54d 100644
--- a/mod/fsuggest.php
+++ b/mod/fsuggest.php
@@ -13,7 +13,7 @@ use Friendica\Util\Strings;
 
 function fsuggest_post(App $a)
 {
-	if (! local_user()) {
+	if (!local_user()) {
 		return;
 	}
 
@@ -22,53 +22,35 @@ function fsuggest_post(App $a)
 	}
 
 	$contact_id = intval($a->argv[1]);
+	if (empty($contact_id)) {
+		return;
+	}
 
-	$contact = DBA::selectFirst('contact', [], ['id' => $contact_id, 'uid' => local_user()]);
-	if (! DBA::isResult($contact)) {
+	$contact = DBA::selectFirst('contact', ['name', 'url', 'request', 'photo'], ['id' => $contact_id, 'uid' => local_user()]);
+	if (!DBA::isResult($contact)) {
 		notice(L10n::t('Contact not found.') . EOL);
 		return;
 	}
 
+	$note = Strings::escapeHtml(trim(defaults($_POST, 'note', '')));
+
 	$new_contact = intval($_POST['suggest']);
+	if (empty($new_contact)) {
+		return;
+	}
 
-	$hash = Strings::getRandomHex();
+	if (!DBA::exists('contact', ['id' => $new_contact])) {
+		return;
+	}
 
-	$note = Strings::escapeHtml(trim(defaults($_POST, 'note', '')));
+	$fields = ['uid' => local_user(),'cid' => $contact_id, 'name' => $contact['name'],
+		'url' => $contact['url'], 'request' => $contact['request'],
+		'photo' => $contact['photo'], 'note' => $note, 'created' => DateTimeFormat::utcNow()];
+	DBA::insert('fsuggest', $fields);
 
-	if ($new_contact) {
-		$r = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d LIMIT 1",
-			intval($new_contact),
-			intval(local_user())
-		);
-		if (DBA::isResult($r)) {
-			q("INSERT INTO `fsuggest` ( `uid`,`cid`,`name`,`url`,`request`,`photo`,`note`,`created`)
-				VALUES ( %d, %d, '%s','%s','%s','%s','%s','%s')",
-				intval(local_user()),
-				intval($contact_id),
-				DBA::escape($contact['name']),
-				DBA::escape($contact['url']),
-				DBA::escape($contact['request']),
-				DBA::escape($contact['photo']),
-				DBA::escape($hash),
-				DBA::escape(DateTimeFormat::utcNow())
-			);
-			$r = q("SELECT `id` FROM `fsuggest` WHERE `note` = '%s' AND `uid` = %d LIMIT 1",
-				DBA::escape($hash),
-				intval(local_user())
-			);
-			if (DBA::isResult($r)) {
-				$fsuggest_id = $contact['id'];
-				q("UPDATE `fsuggest` SET `note` = '%s' WHERE `id` = %d AND `uid` = %d",
-					DBA::escape($note),
-					intval($fsuggest_id),
-					intval(local_user())
-				);
-				Worker::add(PRIORITY_HIGH, 'Notifier', 'suggest', $fsuggest_id);
-			}
-
-			info(L10n::t('Friend suggestion sent.') . EOL);
-		}
-	}
+	Worker::add(PRIORITY_HIGH, 'Notifier', 'suggest', DBA::lastInsertId());
+
+	info(L10n::t('Friend suggestion sent.') . EOL);
 }
 
 function fsuggest_content(App $a)