From: Zach Copley <zach@controlyourself.ca>
Date: Wed, 4 Feb 2009 05:22:41 +0000 (-0800)
Subject: trac533 Removed redundant calls to htmlspecialcharacters().
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=19724a51b3da1fb076ca47ce1ea7a4f229fa3b5d;p=quix0rs-gnu-social.git

trac533 Removed redundant calls to htmlspecialcharacters().
XMLWriter::writeAttribute() already takes care of the escaping for
us, although that doesn't seem to be well documented.
---

diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php
index f9245414f2..7780b1c19d 100644
--- a/lib/htmloutputter.php
+++ b/lib/htmloutputter.php
@@ -172,7 +172,7 @@ class HTMLOutputter extends XMLOutputter
                        'type' => 'text',
                        'id' => $id);
         if ($value) {
-            $attrs['value'] = htmlspecialchars($value);
+            $attrs['value'] = $value;
         }
         $this->element('input', $attrs);
         if ($instructions) {
@@ -206,7 +206,7 @@ class HTMLOutputter extends XMLOutputter
                        'class' => 'checkbox',
                        'id' => $id);
         if ($value) {
-            $attrs['value'] = htmlspecialchars($value);
+            $attrs['value'] = $value;
         }
         if ($checked) {
             $attrs['checked'] = 'checked';