From: Roland Häder <roland@mxchange.org>
Date: Fri, 21 Aug 2009 21:55:43 +0000 (+0000)
Subject: Much simplier and with is_null() sanity check
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=1dfce1c5d3a9102021322559085bd69f49c981cc;p=core.git

Much simplier and with is_null() sanity check
---

diff --git a/inc/classes/main/helper/class_BaseHelper.php b/inc/classes/main/helper/class_BaseHelper.php
index da4f6b12..5cd4ea88 100644
--- a/inc/classes/main/helper/class_BaseHelper.php
+++ b/inc/classes/main/helper/class_BaseHelper.php
@@ -438,15 +438,17 @@ class BaseHelper extends BaseFrameworkSystem {
 	 *
 	 * @param	$fieldName		Name of the field we shall fetch
 	 * @return	$fieldValue		Value from field
+	 * @throws	NullPointerException	Thrown if $valueInstance is null
 	 */
 	public function getValueField ($fieldName) {
-		// Construct the eval() command
-		$eval = sprintf("\$fieldValue = \$this->getValueInstance()->getField('%s');",
-			$fieldName
-		);
+		// The $valueInstance attribute should not be null!
+		if (is_null($this->getValueInstance())) {
+			// Throws an exception here
+			throw new NullPointerException($this, self::EXCEPTION_IS_NULL_POINTER);
+		} // END - if
 
 		// Get the field value
-		eval($eval);
+		$fieldValue = $this->getValueInstance()->getField($fieldName);
 
 		// Return it
 		return $fieldValue;