From: Hypolite Petovan <mrpetovan@gmail.com>
Date: Tue, 20 Dec 2016 20:14:43 +0000 (-0500)
Subject: proxy: Simplify url extension extraction
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=1f94cb9aac1d329dcb49245493ec42a197b8f17a;p=friendica.git

proxy: Simplify url extension extraction
---

diff --git a/mod/proxy.php b/mod/proxy.php
index af0f912616..4f3c994d75 100644
--- a/mod/proxy.php
+++ b/mod/proxy.php
@@ -281,15 +281,8 @@ function proxy_url($url, $writemode = false, $size = '') {
 
 	$longpath .= '/' . strtr(base64_encode($url), '+/', '-_');
 
-	// Extract the URL extension, disregarding GET parameters starting with ?
-	$question_mark_pos = strpos($url, '?');
-	if ($question_mark_pos === false) {
-		$question_mark_pos = strlen($url);
-	}
-	$dot_pos = strrpos($url, '.', $question_mark_pos - strlen($url));
-	if ($dot_pos !== false) {
-		$extension = strtolower(substr($url, $dot_pos + 1, $question_mark_pos - ($dot_pos + 1)));
-	}
+	// Extract the URL extension
+	$extension = pathinfo(parse_url($url, PHP_URL_PATH), PATHINFO_EXTENSION);
 
 	$extensions = array('jpg', 'jpeg', 'gif', 'png');
 	if (in_array($extension, $extensions)) {