From: Craig Andrews <candrews@integralblue.com>
Date: Tue, 21 Sep 2010 22:04:28 +0000 (-0400)
Subject: Do not allow blank passwords when authenticating against LDAP.
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=2db8aa3ec3f6804f8f16efe754aafb149f4035c9;p=quix0rs-gnu-social.git

Do not allow blank passwords when authenticating against LDAP.
---

diff --git a/plugins/LdapCommon/LdapCommon.php b/plugins/LdapCommon/LdapCommon.php
index d583e30857..09ff54bad9 100644
--- a/plugins/LdapCommon/LdapCommon.php
+++ b/plugins/LdapCommon/LdapCommon.php
@@ -144,6 +144,12 @@ class LdapCommon
         if(!$entry){
             return false;
         }else{
+            if(empty($password)) {
+                //NET_LDAP2 will do an anonymous bind if bindpw is not set / empty string
+                //which causes all login attempts that involve a blank password to appear
+                //to succeed. Which is obviously not good.
+                return false;
+            }
             $config = $this->get_ldap_config();
             $config['binddn']=$entry->dn();
             $config['bindpw']=$password;