From: Roland Haeder Date: Wed, 18 Mar 2015 00:40:49 +0000 (+0100) Subject: Small rewrite for better use of closeFile(): X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=2fa120077c1dbf3f98589d36351d2b1ded76d271;p=hub.git Small rewrite for better use of closeFile(): - closeFile() is now no longer be callable publicly. If a file needs to be closed, it can simply be set to NULL (or unset). Class fields which points to such objects (e.g. pointerInstance) should always be set to NULL and not removed as this may cause checks with is_null() to trigger an E_NOTICE: Being set to NULL or completly unset is a different thing. - Updated 'core' to latest commit Signed-off-by: Roland Haeder --- diff --git a/application/hub/main/source/urls/class_CrawlerUploadedListUrlSource.php b/application/hub/main/source/urls/class_CrawlerUploadedListUrlSource.php index ba2c81e97..4c28ab0c5 100644 --- a/application/hub/main/source/urls/class_CrawlerUploadedListUrlSource.php +++ b/application/hub/main/source/urls/class_CrawlerUploadedListUrlSource.php @@ -275,8 +275,8 @@ class CrawlerUploadedListUrlSource extends BaseUrlSource implements UrlSource, R // Debug message //* NOISY-DEBUG: */ self::createDebugInstance(__CLASS__)->debugOutput('CRAWLER-SOURCE [' . __METHOD__ . ':' . __LINE__ . ']: File ' . $csvFileInstance->getFileName() . ' has been fully read.'); - // Try to close it - $csvFileInstance->closeFile(); + // Try to close it by actually unsetting (destructing) it + unset($csvFileInstance); // This file as been fully read, so don't push it back on stack. return; diff --git a/core b/core index 4648ede71..bd1477458 160000 --- a/core +++ b/core @@ -1 +1 @@ -Subproject commit 4648ede712da5257e96eb4d88f0cc01cb2890740 +Subproject commit bd147745864d29d1dcb0392f366cddae7eb38740