From: Roland Häder Date: Sun, 12 Jan 2025 21:26:53 +0000 (+0100) Subject: Continued: X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=3b16229f350ff257816cf1cd137d4c0246c7c2a8;p=fba.git Continued: - only invoke error_log.add() when 'write_error_log' is enabled --- diff --git a/fba/models/error_log.py b/fba/models/error_log.py index 505bade..fca72e6 100644 --- a/fba/models/error_log.py +++ b/fba/models/error_log.py @@ -37,8 +37,7 @@ def add(domain: str, error: dict) -> None: if blacklist.is_blacklisted(domain): raise ValueError(f"domain='{domain}' is blacklisted but function was invoked") elif not _write_error_log: - logger.debug("Writing to error_log is disabled in configuruation file - EXIT!") - return + raise Exception("Logging of errors is disabled but function was invoked") logger.debug("error[]='%s' - BEFORE!", type(error)) if isinstance(error, (BaseException, json.decoder.JSONDecodeError)): diff --git a/fba/models/instances.py b/fba/models/instances.py index 3e376db..f581689 100644 --- a/fba/models/instances.py +++ b/fba/models/instances.py @@ -81,6 +81,7 @@ _pending = { _config = { "recheck_block" : config.get("recheck_block"), "recheck_instance": config.get("recheck_instance"), + "write_error_log" : config.get("write_error_log"), } def _set_data(key: str, domain: str, value: any) -> None: @@ -302,8 +303,9 @@ def set_last_error(domain: str, error: any) -> None: _set_data("last_status_code" , domain, error["status_code"]) _set_data("last_error_details", domain, error["json"]["error"] if error["json"]["error"] != "" else None) - logger.debug("Invoking error_log.add(domain='%s',error[]='%s'", domain, type(error)) - error_log.add(domain, error) + if _config["write_error_log"]: + logger.debug("Invoking error_log.add(domain='%s',error[]='%s'", domain, type(error)) + error_log.add(domain, error) logger.debug("EXIT!")