From: Michael Vogel <icarus@dabo.de>
Date: Sat, 27 Sep 2014 10:49:00 +0000 (+0200)
Subject: Security issue: Encoding of GUID in itemcache to avoid directory bypassing with a... 
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=459fc2fabdcc436090045723ae921ed95e221e1f;p=friendica.git

Security issue: Encoding of GUID in itemcache to avoid directory bypassing with a malificious formatted GUID.
---

diff --git a/include/items.php b/include/items.php
index b1ee854aef..e0e0c842b7 100644
--- a/include/items.php
+++ b/include/items.php
@@ -1412,7 +1412,7 @@ function item_store($arr,$force_parent = false, $notify = false) {
 	if (!$deleted) {
 
 		// Store the fresh generated item into the cache
-		$cachefile = get_cachefile($arr["guid"]."-".hash("md5", $arr['body']));
+		$cachefile = get_cachefile(urlencode($arr["guid"])."-".hash("md5", $arr['body']));
 
 		if (($cachefile != '') AND !file_exists($cachefile)) {
 			$s = prepare_text($arr['body']);
diff --git a/include/tags.php b/include/tags.php
index fbb9e6ff77..ea7eed84c3 100644
--- a/include/tags.php
+++ b/include/tags.php
@@ -26,7 +26,7 @@ function create_tags_from_item($itemid) {
 	if ($message["deleted"])
 		return;
 
-	$cachefile = get_cachefile($message["guid"]."-".hash("md5", $message['body']));
+	$cachefile = get_cachefile(urlencode($message["guid"])."-".hash("md5", $message['body']));
 
 	if (($cachefile != '') AND !file_exists($cachefile)) {
 		$s = prepare_text($message['body']);
diff --git a/include/text.php b/include/text.php
index b20afd9336..9fef4aebb5 100644
--- a/include/text.php
+++ b/include/text.php
@@ -1330,8 +1330,7 @@ function prepare_body(&$item,$attach = false, $preview = false) {
 	$item['mentions'] = $mentions;
 
 
-	//$cachefile = get_cachefile($item["guid"]."-".strtotime($item["edited"])."-".hash("crc32", $item['body']));
-	$cachefile = get_cachefile($item["guid"]."-".hash("md5", $item['body']));
+	$cachefile = get_cachefile(urlencode($item["guid"])."-".hash("md5", $item['body']));
 
 	if (($cachefile != '')) {
 		if (file_exists($cachefile)) {
diff --git a/mod/item.php b/mod/item.php
index 0e2fce7bf7..cd23de60d5 100644
--- a/mod/item.php
+++ b/mod/item.php
@@ -807,7 +807,7 @@ function item_post(&$a) {
 		file_tag_update_pconfig($uid,$categories_old,$categories_new,'category');
 
 		// Store the fresh generated item into the cache
-		$cachefile = get_cachefile($datarray["guid"]."-".hash("md5", $datarray['body']));
+		$cachefile = get_cachefile(urlencode($datarray["guid"])."-".hash("md5", $datarray['body']));
 
 		if (($cachefile != '') AND !file_exists($cachefile)) {
 			$s = prepare_text($datarray['body']);
diff --git a/mod/parse_url.php b/mod/parse_url.php
index 4953b8f4cb..c5f010ac11 100644
--- a/mod/parse_url.php
+++ b/mod/parse_url.php
@@ -186,6 +186,9 @@ function parseurl_getsiteinfo($url, $no_guessing = false, $do_oembed = true, $co
 				case "twitter:image":
 					$siteinfo["image"] = $attr["content"];
 					break;
+				case "twitter:image:src":
+					$siteinfo["image"] = $attr["content"];
+					break;
 				case "twitter:card":
 					if (($siteinfo["type"] == "") OR ($attr["content"] == "photo"))
 						$siteinfo["type"] = $attr["content"];