From: Michael Vogel <icarus@dabo.de>
Date: Wed, 2 Mar 2016 22:39:50 +0000 (+0100)
Subject: Some beautification
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=5adecf5b50e11fb6016cc089426f74b8f930ed0b;p=friendica.git

Some beautification
---

diff --git a/include/diaspora2.php b/include/diaspora2.php
index baf117b102..4d0e4c2cb8 100644
--- a/include/diaspora2.php
+++ b/include/diaspora2.php
@@ -1524,16 +1524,16 @@ print_r($data);
 
 		$body = diaspora2bb($raw_message);
 
-		if ($data->photo)
+		$datarray = array();
+
+		if ($data->photo) {
 			foreach ($data->photo AS $photo)
 				$body = "[img]".$photo->remote_photo_path.$photo->remote_photo_name."[/img]\n".$body;
 
-		$datarray = array();
-
-		if($data->photo->remote_photo_path AND $data->photo->remote_photo_name)
 			$datarray["object-type"] = ACTIVITY_OBJ_PHOTO;
-		else {
+		} else {
 			$datarray["object-type"] = ACTIVITY_OBJ_NOTE;
+
 			// Add OEmbed and other information to the body
 			if (!self::is_redmatrix($contact["url"]))
 				$body = add_page_info_to_body($body, false, true);
@@ -1541,6 +1541,7 @@ print_r($data);
 
 		$str_tags = "";
 
+		// This doesn't work. @todo Check if the "tag" field is filled in the "item_store" function.
 		$cnt = preg_match_all("/@\[url=(.*?)\[\/url\]/ism", $body, $matches, PREG_SET_ORDER);
 		if($cnt) {
 			foreach($matches as $mtch) {