From: Michael <heluecht@pirati.ca>
Date: Fri, 22 Nov 2019 18:39:51 +0000 (+0000)
Subject: Improvement for PR 7854: Avoid leaking of BCC header data
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=5bf8c895a9614bd442ca6d526228042be744f408;p=friendica.git

Improvement for PR 7854: Avoid leaking of BCC header data
---

diff --git a/src/Protocol/ActivityPub/Transmitter.php b/src/Protocol/ActivityPub/Transmitter.php
index 7fc0f5d990..b9a00c4817 100644
--- a/src/Protocol/ActivityPub/Transmitter.php
+++ b/src/Protocol/ActivityPub/Transmitter.php
@@ -498,7 +498,13 @@ class Transmitter
 			}
 		}
 
-		return ['to' => array_values($data['to']), 'cc' => array_values($data['cc']), 'bcc' => array_values($data['bcc'])];
+		$receivers = ['to' => array_values($data['to']), 'cc' => array_values($data['cc']), 'bcc' => array_values($data['bcc'])];
+
+		if (!$blindcopy) {
+			unset($receivers['bcc']);
+		}
+
+		return $receivers;
 	}
 
 	/**
@@ -693,18 +699,6 @@ class Transmitter
 		$mail = self::ItemArrayFromMail($mail_id);
 		$object = self::createNote($mail);
 
-		if (!empty($object['cc'])) {
-			$object['to'] = array_merge($object['to'], $object['cc']);
-			unset($object['cc']);
-		}
-
-		if (!empty($object['bcc'])) {
-			$object['to'] = array_merge($object['to'], $object['bcc']);
-			unset($object['bcc']);
-		}
-
-		$object['tag'] = [['type' => 'Mention', 'href' => $object['to'][0], 'name' => 'test']];
-
 		if (!$object_mode) {
 			$data = ['@context' => ActivityPub::CONTEXT];
 		} else {
@@ -730,6 +724,8 @@ class Transmitter
 		unset($data['bcc']);
 
 		$object['to'] = $data['to'];
+		$object['tag'] = [['type' => 'Mention', 'href' => $object['to'][0], 'name' => 'test']];
+
 		unset($object['cc']);
 		unset($object['bcc']);