From: ThorstenB <brehmt@gmail.com>
Date: Tue, 31 Jan 2012 22:19:02 +0000 (+0100)
Subject: Fix string buffer issue with replay time display.
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=5c3b6a2cc4a741fd886ae151291c7daffc807946;p=flightgear.git

Fix string buffer issue with replay time display.
Unclean method of appending a string to a buffer would break with
some compiler optimization settings.
---

diff --git a/src/Aircraft/replay.cxx b/src/Aircraft/replay.cxx
index 7ef44c202..702a8f913 100644
--- a/src/Aircraft/replay.cxx
+++ b/src/Aircraft/replay.cxx
@@ -173,19 +173,26 @@ printTimeStr(char* pStrBuffer,double _Time, bool ShowDecimal=true)
 {
     if (_Time<0)
         _Time = 0;
-    unsigned int Time = (unsigned int) (_Time*10);
-    int h = Time/36000;
-    int m = (Time % 36000)/600;
-    int s = (Time % 600)/10;
-    int d = Time % 10;
+    unsigned int Time = _Time*10;
+    unsigned int h = Time/36000;
+    unsigned int m = (Time % 36000)/600;
+    unsigned int s = (Time % 600)/10;
+    unsigned int d = Time % 10;
+
+    int len;
     if (h>0)
-        sprintf(pStrBuffer,"%u:%02u",h,m);
+        len = sprintf(pStrBuffer,"%u:%02u:%02u",h,m,s);
     else
-        sprintf(pStrBuffer,"%u",m);
+        len = sprintf(pStrBuffer,"%u:%02u",m,s);
+
+    if (len < 0)
+    {
+        *pStrBuffer = 0;
+        return;
+    }
+
     if (ShowDecimal)
-        sprintf(pStrBuffer,"%s:%02u.%u",pStrBuffer,s,d);
-    else
-        sprintf(pStrBuffer,"%s:%02u",pStrBuffer,s);
+        sprintf(&pStrBuffer[len],".%u",d);
 }
 
 /** Start replay session