From: Sarven Capadisli <csarven@status.net>
Date: Sat, 3 Oct 2009 20:17:26 +0000 (+0000)
Subject: Updated comment about browser sniffing
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=604cfd8b116886cac04a8d062c66f11fb601318f;p=quix0rs-gnu-social.git

Updated comment about browser sniffing
---

diff --git a/plugins/MobileProfile/MobileProfilePlugin.php b/plugins/MobileProfile/MobileProfilePlugin.php
index cce8f8081c..f594f3c0ee 100644
--- a/plugins/MobileProfile/MobileProfilePlugin.php
+++ b/plugins/MobileProfile/MobileProfilePlugin.php
@@ -96,8 +96,16 @@ class MobileProfilePlugin extends WAP20Plugin
                 // serve them MP
 
                 // XXX: Browser sniffing sucks
+
                 // I really don't like going through this every page, 
                 // find a better way
+
+                // May be better to categorize the devices in terms of 
+                // low,mid,high-end
+
+                // Or, detect the mobile devices based on their support for 
+                // MP 1.0, 1.1, or 1.2 may be ideal. Possible?
+
                 $this->mobiledevices = 
                     array('alcatel', 'android', 'audiovox', 'au-mic,', 
                           'avantgo', 'blackberry', 'blazer', 'cldc-', 'danger', 
@@ -112,8 +120,8 @@ class MobileProfilePlugin extends WAP20Plugin
 
                 $httpuseragent = strtolower($_SERVER['HTTP_USER_AGENT']);
 
-                foreach($this->mobiledevices as $mb) {
-                    if (strstr($httpuseragent, $mb) !== false) {
+                foreach($this->mobiledevices as $md) {
+                    if (strstr($httpuseragent, $md) !== false) {
                         $this->serveMobile = true;
                         break;
                     }