From: Michael <heluecht@pirati.ca>
Date: Sun, 26 Aug 2018 04:31:29 +0000 (+0000)
Subject: Issue 4475: Don't create empty twitter quotes
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=6175f07adf65d07b23310d0912d03d8c9addff2e;p=friendica-addons.git

Issue 4475: Don't create empty twitter quotes
---

diff --git a/twitter/twitter.php b/twitter/twitter.php
index 74828a84..bc81144f 100644
--- a/twitter/twitter.php
+++ b/twitter/twitter.php
@@ -817,6 +817,10 @@ function twitter_do_mirrorpost(App $a, $uid, $post)
 		// We don't support nested shares, so we mustn't show quotes as shares on retweets
 		$item = twitter_createpost($a, $uid, $post->retweeted_status, ['id' => 0], false, false, true);
 
+		if (empty($item['body'])) {
+			return [];
+		}
+
 		$datarray['body'] = "\n" . share_header(
 			$item['author-name'],
 			$item['author-link'],
@@ -830,6 +834,10 @@ function twitter_do_mirrorpost(App $a, $uid, $post)
 	} else {
 		$item = twitter_createpost($a, $uid, $post, ['id' => 0], false, false, false);
 
+		if (empty($item['body'])) {
+			return [];
+		}
+
 		$datarray['body'] = $item['body'];
 	}
 
@@ -907,6 +915,10 @@ function twitter_fetchtimeline(App $a, $uid)
 
 				$_REQUEST = twitter_do_mirrorpost($a, $uid, $post);
 
+				if (empty($_REQUEST['body'])) {
+					continue;
+				}
+
 				logger('twitter: posting for user ' . $uid);
 
 				item_post($a);
@@ -1467,6 +1479,10 @@ function twitter_createpost(App $a, $uid, $post, array $self, $create_user, $onl
 	if (!empty($post->retweeted_status)) {
 		$retweet = twitter_createpost($a, $uid, $post->retweeted_status, $self, false, false, $noquote);
 
+		if (empty($retweet['body'])) {
+			return [];
+		}
+
 		$retweet['source'] = $postarray['source'];
 		$retweet['private'] = $postarray['private'];
 		$retweet['allow_cid'] = $postarray['allow_cid'];
@@ -1481,6 +1497,10 @@ function twitter_createpost(App $a, $uid, $post, array $self, $create_user, $onl
 	if (!empty($post->quoted_status) && !$noquote) {
 		$quoted = twitter_createpost($a, $uid, $post->quoted_status, $self, false, false, true);
 
+		if (empty($quoted['body'])) {
+			return [];
+		}
+
 		$postarray['body'] = $statustext;
 
 		$postarray['body'] .= "\n" . share_header(