From: Mikael Nordfeldth <mmn@hethane.se>
Date: Tue, 3 Jun 2014 10:22:07 +0000 (+0200)
Subject: Dangerous non-dynamic profile fetching in Notice
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=629cbedee2e26273b5044d6c6b257c1348eb3146;p=quix0rs-gnu-social.git

Dangerous non-dynamic profile fetching in Notice

For a Notice object with multiple results, ->getProfile() would ALWAYS
return the first profile in the list. For example our "popular notices"
stream ended up believing all notices were made by the same profile.
---

diff --git a/classes/Notice.php b/classes/Notice.php
index f055096c33..73e05912ac 100644
--- a/classes/Notice.php
+++ b/classes/Notice.php
@@ -141,14 +141,14 @@ class Notice extends Managed_DataObject
     const GROUP_SCOPE     = 4;
     const FOLLOWER_SCOPE  = 8;
 
-    protected $_profile = -1;
+    protected $_profile = array();
     
     public function getProfile()
     {
-        if ($this->_profile === -1) {
+        if (!isset($this->_profile[$this->profile_id])) {
             $this->_setProfile(Profile::getKV('id', $this->profile_id));
         }
-        return $this->_profile;
+        return $this->_profile[$this->profile_id];
     }
     
     public function _setProfile(Profile $profile=null)
@@ -156,7 +156,7 @@ class Notice extends Managed_DataObject
         if (!$profile instanceof Profile) {
             throw new NoProfileException($this->profile_id);
         }
-        $this->_profile = $profile;
+        $this->_profile[$this->profile_id] = $profile;
     }
 
     function delete($useWhere=false)