From: Michael <heluecht@pirati.ca>
Date: Wed, 29 Apr 2020 06:28:06 +0000 (+0000)
Subject: Issue 8550: Check for a good table_definition cache value
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=6487daa4a9c4ce6700e9fcaa2e1fc5031910923b;p=friendica.git

Issue 8550: Check for a good table_definition cache value
---

diff --git a/src/Database/DBA.php b/src/Database/DBA.php
index 9c3c3a52e5..9825d06c68 100644
--- a/src/Database/DBA.php
+++ b/src/Database/DBA.php
@@ -741,6 +741,17 @@ class DBA
 		return DI::dba()->processlist();
 	}
 
+	/**
+	 * Fetch a database variable
+	 *
+	 * @param string $name
+	 * @return string content
+	 */
+	public static function getVariable(string $name)
+	{
+		return DI::dba()->getVariable($name);
+	}
+
 	/**
 	 * Checks if $array is a filled array with at least one entry.
 	 *
diff --git a/src/Database/Database.php b/src/Database/Database.php
index db906bd01e..9892fc19af 100644
--- a/src/Database/Database.php
+++ b/src/Database/Database.php
@@ -1645,6 +1645,21 @@ class Database
 		return (["list" => $statelist, "amount" => $processes]);
 	}
 
+	/**
+	 * Fetch a database variable
+	 *
+	 * @param string $name
+	 * @return string content
+	 */
+	public function getVariable(string $name)
+	{
+		$result = $this->fetchFirst("SHOW GLOBAL VARIABLES WHERE `Variable_name` = ?", $name);
+		if (!isset($result['Value'])) {
+			return null;
+		}
+		return $result['Value'];
+	}
+
 	/**
 	 * Checks if $array is a filled array with at least one entry.
 	 *
diff --git a/src/Module/Admin/Summary.php b/src/Module/Admin/Summary.php
index f676792d82..7bd7901f78 100644
--- a/src/Module/Admin/Summary.php
+++ b/src/Module/Admin/Summary.php
@@ -55,6 +55,16 @@ class Summary extends BaseAdmin
 			$warningtext[] = DI::l10n()->t('Your DB still runs with InnoDB tables in the Antelope file format. You should change the file format to Barracuda. Friendica is using features that are not provided by the Antelope format. See <a href="%s">here</a> for a guide that may be helpful converting the table engines. You may also use the command <tt>php bin/console.php dbstructure toinnodb</tt> of your Friendica installation for an automatic conversion.<br />', 'https://dev.mysql.com/doc/refman/5.7/en/innodb-file-format.html');
 		}
 
+		// Avoid the database error 1615 "Prepared statement needs to be re-prepared", see https://github.com/friendica/friendica/issues/8550
+		$table_definition_cache = DBA::getVariable('table_definition_cache');
+		$table_open_cache = DBA::getVariable('table_open_cache');
+		if (!empty($table_definition_cache) && !empty($table_open_cache)) {
+			$suggested_definition_cache = max(400, round($table_open_cache / 2, 1));
+			if ($suggested_definition_cache > $table_definition_cache) {
+				$warningtext[] = DI::l10n()->t('Your table_definition_cache is too low (%d). This can lead to the database error "Prepared statement needs to be re-prepared". Please set it at least to %d (or -1 for autosizing). See <a href="%s">here</a> for more information.<br />', $table_definition_cache, $suggested_definition_cache, 'https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_table_definition_cache');
+			}
+		}
+
 		// Check if github.com/friendica/master/VERSION is higher then
 		// the local version of Friendica. Check is opt-in, source may be master or devel branch
 		if (DI::config()->get('system', 'check_new_version_url', 'none') != 'none') {