From: Michael <heluecht@pirati.ca>
Date: Mon, 5 Oct 2020 06:51:07 +0000 (+0000)
Subject: Pumpio: Minor fixes to avoid notices and editor warning
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=6c4482234e805ecc4f6468c9cf21a45067b44b1a;p=friendica-addons.git

Pumpio: Minor fixes to avoid notices and editor warning
---

diff --git a/pumpio/pumpio.php b/pumpio/pumpio.php
index 2e2ca98c..cea19717 100644
--- a/pumpio/pumpio.php
+++ b/pumpio/pumpio.php
@@ -145,8 +145,7 @@ function pumpio_connect(App $a)
 	if (($consumer_key == "") || ($consumer_secret == "")) {
 		Logger::log("pumpio_connect: ".sprintf("Unable to register the client at the pump.io server '%s'.", $hostname));
 
-		$o .= DI::l10n()->t("Unable to register the client at the pump.io server '%s'.", $hostname);
-		return $o;
+		return DI::l10n()->t("Unable to register the client at the pump.io server '%s'.", $hostname);
 	}
 
 	// The callback URL is the script that gets called after the user authenticates with pumpio
@@ -1504,12 +1503,12 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
 
 	// Fetching the original post
 	$condition = ["`uri` = ? AND `uid` = ? AND `extid` != ''", $id, $uid];
-	$item = Item::selectFirst(['extid'], $condition);
-	if (!DBA::isResult($item)) {
+	$original = Item::selectFirst(['extid'], $condition);
+	if (!DBA::isResult($original)) {
 		return false;
 	}
 
-	$url = $item["extid"];
+	$url = $original["extid"];
 
 	$client = new oauth_client_class;
 	$client->oauth_version = '1.0a';