From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Sun, 28 Apr 2019 02:22:21 +0000 (-0400)
Subject: Various feedback items
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=6df37afb828f4deb5397d512d801427f24a068c9;p=friendica.git

Various feedback items

- Add logger call on theme install failure
- Add todo in Module\Admin\DBSync
---

diff --git a/src/Core/Theme.php b/src/Core/Theme.php
index 37e673e404..61798a3969 100644
--- a/src/Core/Theme.php
+++ b/src/Core/Theme.php
@@ -177,6 +177,7 @@ class Theme
 
 			return true;
 		} catch (\Exception $e) {
+			Logger::error('Theme installation failed', ['theme' => $theme, 'error' => $e->getMessage()]);
 			return false;
 		}
 	}
diff --git a/src/Module/Admin/DBSync.php b/src/Module/Admin/DBSync.php
index a9c2cb6dbb..69001b9ce4 100644
--- a/src/Module/Admin/DBSync.php
+++ b/src/Module/Admin/DBSync.php
@@ -36,6 +36,7 @@ class DBSync extends BaseAdminModule
 
 		if ($a->argc > 2) {
 			if ($a->argv[2] === 'check') {
+				// @TODO Seems like a similar logic like Update::check()
 				$retval = DBStructure::update($a->getBasePath(), false, true);
 				if ($retval === '') {
 					$o .= L10n::t("Database structure update %s was successfully applied.", DB_UPDATE_VERSION) . "<br />";