From: Hypolite Petovan <mrpetovan@gmail.com>
Date: Thu, 19 Apr 2018 03:37:06 +0000 (-0400)
Subject: Improve CacheSessionhandler
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=87f638bdc90107bea511587368e2b3e1a4e40bcd;p=friendica.git

Improve CacheSessionhandler

- Replace !x() by empty()
- Add return values to read() and destroy()
---

diff --git a/src/Core/Session/CacheSessionHandler.php b/src/Core/Session/CacheSessionHandler.php
index 463fd33d3e..507735c4fc 100644
--- a/src/Core/Session/CacheSessionHandler.php
+++ b/src/Core/Session/CacheSessionHandler.php
@@ -24,7 +24,7 @@ class CacheSessionHandler extends BaseObject implements SessionHandlerInterface
 
 	public function read($session_id)
 	{
-		if (!x($session_id)) {
+		if (empty($session_id)) {
 			return '';
 		}
 
@@ -58,9 +58,9 @@ class CacheSessionHandler extends BaseObject implements SessionHandlerInterface
 			return true;
 		}
 
-		Cache::set('session:' . $session_id, $session_data, Session::$expire);
+		$return = Cache::set('session:' . $session_id, $session_data, Session::$expire);
 
-		return true;
+		return $return;
 	}
 
 	public function close()
@@ -70,8 +70,9 @@ class CacheSessionHandler extends BaseObject implements SessionHandlerInterface
 
 	public function destroy($id)
 	{
-		Cache::delete('session:' . $id);
-		return true;
+		$return = Cache::delete('session:' . $id);
+
+		return $return;
 	}
 
 	public function gc($maxlifetime)