From: Roland Häder <roland@mxchange.org>
Date: Sat, 18 Jun 2022 03:06:00 +0000 (+0200)
Subject: Some outside code relies on returned "false"
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=89302d0843308c8fa7cc0537cb10943e8defc8ee;p=friendica.git

Some outside code relies on returned "false"
---

diff --git a/src/Protocol/Diaspora.php b/src/Protocol/Diaspora.php
index c0a338344b..c71745a426 100644
--- a/src/Protocol/Diaspora.php
+++ b/src/Protocol/Diaspora.php
@@ -323,14 +323,14 @@ class Diaspora
 	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
 	 * @throws \ImagickException
 	 */
-	public static function decode(string $xml, string $privKey = ''): array
+	public static function decode(string $xml, string $privKey = '')
 	{
 		$public = false;
 		$basedom = XML::parseString($xml);
 
 		if (!is_object($basedom)) {
 			Logger::notice('XML is not parseable.');
-			return [];
+			return false;
 		}
 		$children = $basedom->children('https://joindiaspora.com/protocol');
 
@@ -344,7 +344,7 @@ class Diaspora
 			// This happens with posts from a relais
 			if (empty($privKey)) {
 				Logger::info('This is no private post in the old format');
-				return [];
+				return false;
 			}
 
 			$encrypted_header = json_decode(base64_decode($children->encrypted_header));