From: curt <curt>
Date: Sat, 5 Nov 2005 18:47:29 +0000 (+0000)
Subject: Add a code comment for future thought.
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=96fb7a45f7779f361bbb12fe1f80afde42a15346;p=simgear.git

Add a code comment for future thought.
---

diff --git a/simgear/sound/xmlsound.cxx b/simgear/sound/xmlsound.cxx
index fbb4504a..16d88b48 100644
--- a/simgear/sound/xmlsound.cxx
+++ b/simgear/sound/xmlsound.cxx
@@ -262,13 +262,19 @@ SGXmlSound::init(SGPropertyNode *root, SGPropertyNode *node, SGSoundMgr *sndmgr,
       outer_gain = pos->getDoubleValue("outer-gain", 0.0);
    }
    
-
    //
    // Initialize the sample
    //
    _mgr = sndmgr;
    if ( (_sample = _mgr->find(_name)) == NULL ) {
-       _sample = new SGSoundSample( path.c_str(),
+       // FIXME: Does it make sense to overwrite a previous entry's
+       // configuration just because a new entry has the same name?
+       // Note that we can't match on identical "path" because we the
+       // new entry could be at a different location with different
+       // configuration so we need a new sample which creates a new
+       // "alSource".  The semantics of what is going on here seems
+       // confused and needs to be thought through more carefully.
+        _sample = new SGSoundSample( path.c_str(),
                                     node->getStringValue("path", ""),
                                     true );