From: Craig Andrews <candrews@integralblue.com>
Date: Fri, 7 Aug 2009 22:26:12 +0000 (-0400)
Subject: Redirect instead of showing an error when the user visits a non-local notice's url
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=a7a87913befddd7b1ab8e0b4ab0e563e7927950b;p=quix0rs-gnu-social.git

Redirect instead of showing an error when the user visits a non-local notice's url
Use consistent logic in display non-local notice links

Fixes http://laconi.ca/trac/ticket/1788
---

diff --git a/actions/shownotice.php b/actions/shownotice.php
index 8f73dc824a..4b179bc72b 100644
--- a/actions/shownotice.php
+++ b/actions/shownotice.php
@@ -97,8 +97,8 @@ class ShownoticeAction extends OwnerDesignAction
 
         $this->user = User::staticGet('id', $this->profile->id);
 
-        if (empty($this->user)) {
-            $this->serverError(_('Not a local notice'), 500);
+        if (! $this->notice->is_local) {
+            common_redirect($this->notice->uri);
             return false;
         }
 
diff --git a/lib/noticelist.php b/lib/noticelist.php
index a8d5059ca4..5429d943f1 100644
--- a/lib/noticelist.php
+++ b/lib/noticelist.php
@@ -350,11 +350,10 @@ class NoticeListItem extends Widget
 
     function showNoticeLink()
     {
-        $noticeurl = common_local_url('shownotice',
+        if($this->notice->is_local){
+            $noticeurl = common_local_url('shownotice',
                                       array('notice' => $this->notice->id));
-        // XXX: we need to figure this out better. Is this right?
-        if (strcmp($this->notice->uri, $noticeurl) != 0 &&
-            preg_match('/^http/', $this->notice->uri)) {
+        }else{
             $noticeurl = $this->notice->uri;
         }
         $this->out->elementStart('a', array('rel' => 'bookmark',