From: Mikael Nordfeldth <mmn@hethane.se>
Date: Sat, 18 Jul 2015 09:04:35 +0000 (+0200)
Subject: Some missed exception throwing since fixing Foreign_link and Foreign_user
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=b609a3610fd3e61a11dc6b278bcc4eefee347897;p=quix0rs-gnu-social.git

Some missed exception throwing since fixing Foreign_link and Foreign_user
---

diff --git a/plugins/TwitterBridge/TwitterBridgePlugin.php b/plugins/TwitterBridge/TwitterBridgePlugin.php
index 84c6285029..dd3007e309 100644
--- a/plugins/TwitterBridge/TwitterBridgePlugin.php
+++ b/plugins/TwitterBridge/TwitterBridgePlugin.php
@@ -387,9 +387,9 @@ class TwitterBridgePlugin extends Plugin
 
         if ($n2s instanceof Notice_to_status) {
 
-            $flink = Foreign_link::getByUserID($notice->profile_id, TWITTER_SERVICE); // twitter service
-
-            if (!$flink instanceof Foreign_link) {
+            try {
+                $flink = Foreign_link::getByUserID($notice->profile_id, TWITTER_SERVICE); // twitter service
+            } catch (NoResultException $e) {
                 return true;
             }
 
@@ -421,9 +421,9 @@ class TwitterBridgePlugin extends Plugin
      */
     function onEndFavorNotice(Profile $profile, Notice $notice)
     {
-        $flink = Foreign_link::getByUserID($profile->getID(), TWITTER_SERVICE); // twitter service
-
-        if (!$flink instanceof Foreign_link) {
+        try {
+            $flink = Foreign_link::getByUserID($profile->getID(), TWITTER_SERVICE); // twitter service
+        } catch (NoResultException $e) {
             return true;
         }
 
@@ -460,10 +460,9 @@ class TwitterBridgePlugin extends Plugin
      */
     function onEndDisfavorNotice(Profile $profile, Notice $notice)
     {
-        $flink = Foreign_link::getByUserID($profile->id,
-                                           TWITTER_SERVICE); // twitter service
-
-        if (empty($flink)) {
+        try {
+            $flink = Foreign_link::getByUserID($profile->getID(), TWITTER_SERVICE); // twitter service
+        } catch (NoResultException $e) {
             return true;
         }
 
@@ -520,7 +519,7 @@ class TwitterBridgePlugin extends Plugin
                              "text" => sprintf(_("@%s on Twitter"), $fuser->nickname),
                              "image" => $this->path("icons/twitter-bird-white-on-blue.png"));
         } catch (NoResultException $e) {
-            // no foreign link for Twitter on this profile ID
+            // no foreign link and/or user for Twitter on this profile ID
         }
 
         return true;
@@ -564,16 +563,17 @@ class TwitterBridgePlugin extends Plugin
                 if( count($noticeArray) != 1 ) { break; }
                 $post = $noticeArray[0];
 
-                $flink = Foreign_link::getByUserID($post->profile_id, TWITTER_SERVICE);
-                if( $flink ) { // Our local user has registered Twitter Gateway
+                try {
+                    $flink = Foreign_link::getByUserID($post->profile_id, TWITTER_SERVICE);
                     $fuser = Foreign_user::getForeignUser($flink->foreign_id, TWITTER_SERVICE);
-                    if( $fuser ) { // Got nickname for local user's Twitter account
-                        $action->element('meta', array('name'    => 'twitter:creator',
-                                                     'content' => '@'.$fuser->nickname));
-                    }
+                    $action->element('meta', array('name'    => 'twitter:creator',
+                                                   'content' => '@'.$fuser->nickname));
+                } catch (NoResultException $e) {
+                    // no foreign link and/or user for Twitter on this profile ID
                 }
                 break;
-            default: break;
+            default:
+                break;
         }
 
         return true;