From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Mon, 10 Feb 2020 03:19:21 +0000 (-0500)
Subject: Increase specificity of [url][img] capture regex in BBCode::getAttachedData
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=d2ca5ccd354e3f252e434291d3465505080304ee;p=friendica.git

Increase specificity of [url][img] capture regex in BBCode::getAttachedData

- Prevents it from over capturing when there's a [url] tag before the image
---

diff --git a/src/Content/Text/BBCode.php b/src/Content/Text/BBCode.php
index f8b9fb2985..3c6b7062de 100644
--- a/src/Content/Text/BBCode.php
+++ b/src/Content/Text/BBCode.php
@@ -273,7 +273,7 @@ class BBCode
 			$body = preg_replace("/\[img\=(.*?)\](.*?)\[\/img\]/ism", '[img]$1[/img]', $body);
 			$post['text'] = $body;
 
-			if (preg_match_all("(\[url=(.*?)\]\s*\[img\](.*?)\[\/img\]\s*\[\/url\])ism", $body, $pictures, PREG_SET_ORDER)) {
+			if (preg_match_all("#\[url=([^\]]+?)\]\s*\[img\]([^\[]+?)\[/img\]\s*\[/url\]#ism", $body, $pictures, PREG_SET_ORDER)) {
 				if ((count($pictures) == 1) && !$has_title) {
 					if (!empty($item['object-type']) && ($item['object-type'] == Activity\ObjectType::IMAGE)) {
 						// Replace the preview picture with the real picture