From: Philipp Holzer <admin+github@philipp.info>
Date: Mon, 28 Oct 2019 21:24:46 +0000 (+0100)
Subject: Fix wrong check for logfile in admin summary
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=dc4d3842e02487b00ae8419f76b3272cc3633121;p=friendica.git

Fix wrong check for logfile in admin summary
---

diff --git a/src/Module/Admin/Summary.php b/src/Module/Admin/Summary.php
index e1952f294b..52b1380148 100644
--- a/src/Module/Admin/Summary.php
+++ b/src/Module/Admin/Summary.php
@@ -12,6 +12,7 @@ use Friendica\Database\DBA;
 use Friendica\Database\DBStructure;
 use Friendica\Model\Register;
 use Friendica\Module\BaseAdminModule;
+use Friendica\Network\HTTPException\InternalServerErrorException;
 use Friendica\Util\ConfigFileLoader;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\FileSystem;
@@ -85,20 +86,27 @@ class Summary extends BaseAdminModule
 			try {
 				$stream = $fileSystem->createStream($file);
 
-				if (is_file($stream) &&
-				    !is_writeable($stream)) {
-					$warningtext[] = L10n::t('The logfile \'%s\' is not writable. No logging possible', $stream);
+				if (!isset($stream)) {
+					throw new InternalServerErrorException('Stream is null.');
 				}
 
 			} catch (\Throwable $exception) {
 				$warningtext[] = L10n::t('The logfile \'%s\' is not usable. No logging possible (error: \'%s\')', $file, $exception->getMessage());
 			}
 
-			$stream = Config::get('system', 'dlogfile');
+			$file = Config::get('system', 'dlogfile');
 
-			if (is_file($stream) &&
-			    !is_writeable($stream)) {
-				$warningtext[] = L10n::t('The logfile \'%s\' is not writable. No logging possible', $stream);
+			try {
+				if (!empty($file)) {
+					$stream = $fileSystem->createStream($file);
+
+					if (!isset($stream)) {
+						throw new InternalServerErrorException('Stream is null.');
+					}
+				}
+
+			} catch (\Throwable $exception) {
+				$warningtext[] = L10n::t('The developer logfile \'%s\' is not usable. No logging possible (error: \'%s\')', $file, $exception->getMessage());
 			}
 		}