From: Sarven Capadisli <csarven@status.net>
Date: Fri, 30 Oct 2009 21:44:31 +0000 (+0000)
Subject: IE has some issue with notices that are sent with file attachments. It
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=dcca9fbec0cea9c5e15c4d58a8e9870514dfdbdd;p=quix0rs-gnu-social.git

IE has some issue with notices that are sent with file attachments. It
doesn't like the XHR response with XHTML DTD. New notices without the
file attachment work fine.

The rendered content (the anchor for the file attachment link) doesn't
appear to be the issue.

To fix this problem, I removed the XHTML DTD line from newnotice's XHR
response. This is unnecessary for text/xml outputs that's intended
for XHR responses any way. It just happens to fix an IE issue.

Still a mystery to me as to why it is particular to notices with file
attachments.
---

diff --git a/actions/newnotice.php b/actions/newnotice.php
index 8c0476f705..548832eca1 100644
--- a/actions/newnotice.php
+++ b/actions/newnotice.php
@@ -271,7 +271,9 @@ class NewnoticeAction extends Action
         common_broadcast_notice($notice);
 
         if ($this->boolean('ajax')) {
-            $this->startHTML('text/xml;charset=utf-8');
+            header('Content-Type: text/xml;charset=utf-8');
+            $this->xw->startDocument('1.0', 'UTF-8');
+            $this->elementStart('html');
             $this->elementStart('head');
             $this->element('title', null, _('Notice posted'));
             $this->elementEnd('head');