From: Evan Prodromou <evan@prodromou.name>
Date: Fri, 29 Aug 2008 02:51:27 +0000 (-0400)
Subject: CSRF protection in deletenotice
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=dd55916d5671f910698499f0786f9a94d95f5977;p=quix0rs-gnu-social.git

CSRF protection in deletenotice

darcs-hash:20080829025127-84dde-b3e2eb64b7dd8302037f471f6dba6949e2e15ecc.gz
---

diff --git a/actions/deletenotice.php b/actions/deletenotice.php
index f2c040a5a9..af620f036f 100644
--- a/actions/deletenotice.php
+++ b/actions/deletenotice.php
@@ -49,6 +49,7 @@ class DeletenoticeAction extends DeleteAction {
 		common_element_start('form', array('id' => 'notice_delete_form',
 								   'method' => 'post',
 								   'action' => common_local_url('deletenotice')));
+		common_hidden('token', common_session_token());
 		common_hidden('notice', $this->trimmed('notice'));
 		common_element_start('p');
 		common_element('span', array('id' => 'confirmation_text'), _('Are you sure you want to delete this notice?'));
@@ -67,6 +68,12 @@ class DeletenoticeAction extends DeleteAction {
 	}
 
 	function delete_notice() {
+		# CSRF protection
+		$token = $this->trimmed('token');
+		if (!$token || $token != common_session_token()) {
+			$this->show_form(_('There was a problem with your session token. Try again, please.'));
+			return;
+		}
 		$url = common_get_returnto();
 		$confirmed = $this->trimmed('submit');
 		if ($confirmed == _('Yes')) {