From: Sarven Capadisli <csarven@controlyourself.ca>
Date: Sat, 25 Jul 2009 17:37:37 +0000 (+0000)
Subject: Removed <dl> structure from NoticeListItem::showDeleteLink. Reason:
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=e0b877b26c5e93809b2a53b6c46326d5e31fa0e8;p=quix0rs-gnu-social.git

Removed <dl> structure from NoticeListItem::showDeleteLink. Reason:
To speed up DOM load by cutting down 3 nodes in each notice list item.
Generally each notice option should be a list item in a <ul>, however,
there is no tangible benefit for the user using this approach. In this
case, minimalism is favoured. Similarly, the new approach will make 5
fewer function calls on the server side.
---

diff --git a/lib/noticelist.php b/lib/noticelist.php
index 44726a17b7..d4d4fc7119 100644
--- a/lib/noticelist.php
+++ b/lib/noticelist.php
@@ -479,13 +479,9 @@ class NoticeListItem extends Widget
         if ($user && $this->notice->profile_id == $user->id) {
             $deleteurl = common_local_url('deletenotice',
                                           array('notice' => $this->notice->id));
-            $this->out->elementStart('dl', 'notice_delete');
-            $this->out->element('dt', null, _('Delete this notice'));
-            $this->out->elementStart('dd');
             $this->out->element('a', array('href' => $deleteurl,
+                                           'class' => 'notice_delete',
                                            'title' => _('Delete this notice')), _('Delete'));
-            $this->out->elementEnd('dd');
-            $this->out->elementEnd('dl');
         }
     }
 
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 867dc0ef7c..80ab397ee9 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -937,22 +937,18 @@ display:block;
 border:0;
 }
 .notice-options .notice_reply a,
-.notice-options .notice_delete a {
+.notice-options .notice_delete {
 text-decoration:none;
 padding-left:16px;
 }
-
 .notice-options form input.submit {
 width:16px;
 padding:2px 0;
 }
-
-.notice-options .notice_delete dt,
 .notice-options .form_favor legend,
 .notice-options .form_disfavor legend {
 display:none;
 }
-.notice-options .notice_delete fieldset,
 .notice-options .form_favor fieldset,
 .notice-options .form_disfavor fieldset {
 border:0;
diff --git a/theme/default/css/display.css b/theme/default/css/display.css
index 251d6706be..e8df27718f 100644
--- a/theme/default/css/display.css
+++ b/theme/default/css/display.css
@@ -227,7 +227,7 @@ background:transparent url(../../base/images/icons/twotone/green/favourite.gif)
 .notice-options form.form_disfavor input.submit {
 background:transparent url(../../base/images/icons/twotone/green/disfavourite.gif) no-repeat 0 45%;
 }
-.notice-options .notice_delete a {
+.notice-options .notice_delete {
 background:transparent url(../../base/images/icons/twotone/green/trash.gif) no-repeat 0 45%;
 }
 
diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index 42a4573a74..7dd4256bf5 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -227,7 +227,7 @@ background:transparent url(../../base/images/icons/twotone/green/favourite.gif)
 .notice-options form.form_disfavor input.submit {
 background:transparent url(../../base/images/icons/twotone/green/disfavourite.gif) no-repeat 0 45%;
 }
-.notice-options .notice_delete a {
+.notice-options .notice_delete {
 background:transparent url(../../base/images/icons/twotone/green/trash.gif) no-repeat 0 45%;
 }