From: Brion Vibber <brion@pobox.com>
Date: Wed, 2 Mar 2011 01:09:41 +0000 (-0800)
Subject: More fixes for 'fav' IM command: don't die with a fatal error if the notice has alrea... 
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=e42db528e2f0b26efcc1fcf779b9d3c34d7f5661;p=quix0rs-gnu-social.git

More fixes for 'fav' IM command: don't die with a fatal error if the notice has already been favored, and don't spew a warning when checking for user ID match.
---

diff --git a/lib/command.php b/lib/command.php
index 852d0a8f7c..39fb283dd8 100644
--- a/lib/command.php
+++ b/lib/command.php
@@ -287,6 +287,18 @@ class FavCommand extends Command
     function handle($channel)
     {
         $notice = $this->getNotice($this->other);
+
+        $fave            = new Fave();
+        $fave->user_id   = $this->user->id;
+        $fave->notice_id = $notice->id;
+        $fave->find();
+
+        if ($fave->fetch()) {
+            // TRANS: Error message text shown when a favorite could not be set because it has already been favorited.
+            $channel->error($this->user, _('Could not create favorite: already favorited.'));
+            return;
+        }
+
         $fave = Fave::addNew($this->user->getProfile(), $notice);
 
         if (!$fave) {
@@ -300,7 +312,7 @@ class FavCommand extends Command
 
         $other = User::staticGet('id', $notice->profile_id);
 
-        if ($other && $other->id != $user->id) {
+        if ($other && $other->id != $this->user->id) {
             if ($other->email && $other->emailnotifyfav) {
                 mail_notify_fave($other, $this->user, $notice);
             }