From: Philipp <admin+Github@philipp.info>
Date: Mon, 17 Jul 2023 18:20:21 +0000 (+0200)
Subject: Apply suggestions from code review
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=e659a0314086dd700dbe5e754e383ab758725805;p=friendica.git

Apply suggestions from code review

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
---

diff --git a/bin/daemon.php b/bin/daemon.php
index 317798a1dd..11bad2b11a 100755
--- a/bin/daemon.php
+++ b/bin/daemon.php
@@ -63,7 +63,7 @@ $dice = (new Dice())->addRules(include __DIR__ . '/../static/dependencies.config
 /** @var \Friendica\Core\Addon\Capabilities\ICanLoadAddons $addonLoader */
 $addonLoader = $dice->create(\Friendica\Core\Addon\Capabilities\ICanLoadAddons::class);
 $dice = $dice->addRules($addonLoader->getActiveAddonConfig('dependencies'));
-$dice = $dice->addRule(LoggerInterface::class,['constructParams' => [Logger\Capabilities\LogChannel::DAEMON]]);
+$dice = $dice->addRule(LoggerInterface::class, ['constructParams' => [Logger\Capabilities\LogChannel::DAEMON]]);
 
 DI::init($dice);
 \Friendica\Core\Logger\Handler\ErrorHandler::register($dice->create(\Psr\Log\LoggerInterface::class));
diff --git a/bin/worker.php b/bin/worker.php
index 18a41e0643..42a8f533d3 100755
--- a/bin/worker.php
+++ b/bin/worker.php
@@ -58,7 +58,7 @@ $dice = (new Dice())->addRules(include __DIR__ . '/../static/dependencies.config
 /** @var \Friendica\Core\Addon\Capabilities\ICanLoadAddons $addonLoader */
 $addonLoader = $dice->create(\Friendica\Core\Addon\Capabilities\ICanLoadAddons::class);
 $dice = $dice->addRules($addonLoader->getActiveAddonConfig('dependencies'));
-$dice = $dice->addRule(LoggerInterface::class,['constructParams' => [LogChannel::WORKER]]);
+$dice = $dice->addRule(LoggerInterface::class, ['constructParams' => [LogChannel::WORKER]]);
 
 DI::init($dice);
 \Friendica\Core\Logger\Handler\ErrorHandler::register($dice->create(\Psr\Log\LoggerInterface::class));
diff --git a/src/Core/Addon/Exception/AddonInvalidConfigFileException.php b/src/Core/Addon/Exception/AddonInvalidConfigFileException.php
index 3bb41be53c..bf173d0a4b 100644
--- a/src/Core/Addon/Exception/AddonInvalidConfigFileException.php
+++ b/src/Core/Addon/Exception/AddonInvalidConfigFileException.php
@@ -28,7 +28,7 @@ use Throwable;
  */
 class AddonInvalidConfigFileException extends \RuntimeException
 {
-	public function __construct($message = "", $code = 0, Throwable $previous = null)
+	public function __construct($message = '', $code = 0, Throwable $previous = null)
 	{
 		parent::__construct($message, 500, $previous);
 	}
diff --git a/src/Core/Hooks/Exceptions/HookConfigException.php b/src/Core/Hooks/Exceptions/HookConfigException.php
index ceca721b1d..6588787eba 100644
--- a/src/Core/Hooks/Exceptions/HookConfigException.php
+++ b/src/Core/Hooks/Exceptions/HookConfigException.php
@@ -23,7 +23,7 @@ namespace Friendica\Core\Hooks\Exceptions;
 
 class HookConfigException extends \RuntimeException
 {
-	public function __construct($message = "", \Throwable $previous = null)
+	public function __construct($message = '', \Throwable $previous = null)
 	{
 		parent::__construct($message, 500, $previous);
 	}
diff --git a/src/Core/Logger/Exception/LogLevelException.php b/src/Core/Logger/Exception/LogLevelException.php
index a79db80f54..9cf649a863 100644
--- a/src/Core/Logger/Exception/LogLevelException.php
+++ b/src/Core/Logger/Exception/LogLevelException.php
@@ -28,7 +28,7 @@ use Throwable;
  */
 class LogLevelException extends \InvalidArgumentException
 {
-	public function __construct($message = "", Throwable $previous = null)
+	public function __construct($message = '', Throwable $previous = null)
 	{
 		parent::__construct($message, 500, $previous);
 	}
diff --git a/src/Core/Logger/Exception/LoggerArgumentException.php b/src/Core/Logger/Exception/LoggerArgumentException.php
index bbc1fc0666..6925be4c7d 100644
--- a/src/Core/Logger/Exception/LoggerArgumentException.php
+++ b/src/Core/Logger/Exception/LoggerArgumentException.php
@@ -28,7 +28,7 @@ use Throwable;
  */
 class LoggerArgumentException extends \InvalidArgumentException
 {
-	public function __construct($message = "", Throwable $previous = null)
+	public function __construct($message = '', Throwable $previous = null)
 	{
 		parent::__construct($message, 500, $previous);
 	}
diff --git a/src/Core/Logger/Exception/LoggerException.php b/src/Core/Logger/Exception/LoggerException.php
index 7425576786..7529f6e78b 100644
--- a/src/Core/Logger/Exception/LoggerException.php
+++ b/src/Core/Logger/Exception/LoggerException.php
@@ -28,7 +28,7 @@ use Throwable;
  */
 class LoggerException extends \Exception
 {
-	public function __construct($message = "", Throwable $previous = null)
+	public function __construct($message = '', Throwable $previous = null)
 	{
 		parent::__construct($message, 500, $previous);
 	}
diff --git a/src/Core/Logger/Exception/LoggerUnusableException.php b/src/Core/Logger/Exception/LoggerUnusableException.php
index 46e49fd414..401a634825 100644
--- a/src/Core/Logger/Exception/LoggerUnusableException.php
+++ b/src/Core/Logger/Exception/LoggerUnusableException.php
@@ -28,7 +28,7 @@ use Throwable;
  */
 class LoggerUnusableException extends \RuntimeException
 {
-	public function __construct($message = "", Throwable $previous = null)
+	public function __construct($message = '', Throwable $previous = null)
 	{
 		parent::__construct($message, 500, $previous);
 	}
diff --git a/src/Core/Logger/Factory/AbstractLoggerTypeFactory.php b/src/Core/Logger/Factory/AbstractLoggerTypeFactory.php
index a6ff5eebbc..402176d8e6 100644
--- a/src/Core/Logger/Factory/AbstractLoggerTypeFactory.php
+++ b/src/Core/Logger/Factory/AbstractLoggerTypeFactory.php
@@ -69,7 +69,7 @@ abstract class AbstractLoggerTypeFactory
 				return LogLevel::INFO;
 			// legacy DATA
 			case "4":
-				// legacy ALL
+			// legacy ALL
 			case "5":
 				return LogLevel::DEBUG;
 			// default if nothing set