From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Sun, 3 Jul 2022 02:14:20 +0000 (-0400)
Subject: Rename Smilies::pregHeart to better match its purpose
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=e6feed65bf2ae97f41c335a33fbedd8a23e72ac1;p=friendica.git

Rename Smilies::pregHeart to better match its purpose

- Fix "Argument 1 passed to Friendica\Content\Smilies::pregHeart() must be of the type string, array given" error
---

diff --git a/src/Content/Smilies.php b/src/Content/Smilies.php
index 43289a710a..04dcf99070 100644
--- a/src/Content/Smilies.php
+++ b/src/Content/Smilies.php
@@ -233,7 +233,7 @@ class Smilies
 			$smilies = $cleaned;
 		}
 
-		$text = preg_replace_callback('/&lt;(3+)/', 'self::pregHeart', $text);
+		$text = preg_replace_callback('/&lt;(3+)/', 'self::heartReplaceCallback', $text);
 		$text = self::strOrigReplace($smilies['texts'], $smilies['icons'], $text);
 
 		$text = preg_replace_callback('/<(code)>(.*?)<\/code>/ism', 'self::decode', $text);
@@ -269,22 +269,20 @@ class Smilies
 	/**
 	 * expand <3333 to the correct number of hearts
 	 *
-	 * @param string $x string
+	 * @param array $matches
 	 * @return string HTML Output
-	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
 	 */
-	private static function pregHeart(string $x): string
+	private static function heartReplaceCallback(array $matches): string
 	{
-		if (strlen($x[1]) == 1) {
-			return $x[0];
+		if (strlen($matches[1]) == 1) {
+			return $matches[0];
 		}
 
 		$t = '';
-		for ($cnt = 0; $cnt < strlen($x[1]); $cnt ++) {
+		for ($cnt = 0; $cnt < strlen($matches[1]); $cnt ++) {
 			$t .= '❤';
 		}
 
-		$r =  str_replace($x[0], $t, $x[0]);
-		return $r;
+		return str_replace($matches[0], $t, $matches[0]);
 	}
 }