From: Philipp Holzer <admin@philipp.info>
Date: Tue, 5 Feb 2019 21:56:57 +0000 (+0100)
Subject: Adding unittest for empty setApp()
X-Git-Url: https://git.mxchange.org/?a=commitdiff_plain;h=ef16e1a037019e8539fa6fae5cd9242fc4162a7f;p=friendica.git

Adding unittest for empty setApp()
---

diff --git a/src/BaseObject.php b/src/BaseObject.php
index 1a23408ba1..4a6fa12d24 100644
--- a/src/BaseObject.php
+++ b/src/BaseObject.php
@@ -28,7 +28,7 @@ class BaseObject
 	public static function getApp()
 	{
 		if (empty(self::$app)) {
-			throw new InternalServerErrorException('App isn\' initialized.');
+			throw new InternalServerErrorException('App isn\'t initialized.');
 		}
 
 		return self::$app;
diff --git a/tests/src/BaseObjectTest.php b/tests/src/BaseObjectTest.php
index 2dbf5580f6..b2c73780a4 100644
--- a/tests/src/BaseObjectTest.php
+++ b/tests/src/BaseObjectTest.php
@@ -31,10 +31,6 @@ class BaseObjectTest extends TestCase
 	 */
 	protected function setUp()
 	{
-		$this->setUpVfsDir();
-		$configMock = \Mockery::mock('Friendica\Core\Config\ConfigCache');
-		$this->mockApp($this->root, $configMock);
-
 		$this->baseObject = new BaseObject();
 	}
 
@@ -44,6 +40,10 @@ class BaseObjectTest extends TestCase
 	 */
 	public function testGetApp()
 	{
+		$this->setUpVfsDir();
+		$configMock = \Mockery::mock('Friendica\Core\Config\ConfigCache');
+		$this->mockApp($this->root, $configMock);
+
 		$this->assertInstanceOf(App::class, $this->baseObject->getApp());
 	}
 
@@ -53,7 +53,20 @@ class BaseObjectTest extends TestCase
 	 */
 	public function testSetApp()
 	{
+		$this->setUpVfsDir();
+		$configMock = \Mockery::mock('Friendica\Core\Config\ConfigCache');
+		$this->mockApp($this->root, $configMock);
+
 		$this->assertNull($this->baseObject->setApp($this->app));
 		$this->assertEquals($this->app, $this->baseObject->getApp());
 	}
+
+	/**
+	 * Test the getApp() function without App
+	 * @expectedException Friendica\Network\HTTPException\InternalServerErrorException
+	 */
+	public function testGetAppFailed()
+	{
+		BaseObject::getApp();
+	}
 }