]> git.mxchange.org Git - friendica.git/log
friendica.git
6 years agoRename DBM method calls to DBA method calls
Hypolite Petovan [Sat, 21 Jul 2018 12:40:21 +0000 (08:40 -0400)]
Rename DBM method calls to DBA method calls

6 years agoUse DateTimeFormat::utc() instead of DBM::date()
Hypolite Petovan [Sat, 21 Jul 2018 12:25:11 +0000 (08:25 -0400)]
Use DateTimeFormat::utc() instead of DBM::date()

6 years agoAdd Database\DBM methods to Database\DBA
Hypolite Petovan [Sat, 21 Jul 2018 12:21:23 +0000 (08:21 -0400)]
Add Database\DBM methods to Database\DBA

6 years agoAdd missing space between PHP path and script in App->proc_run (#5468)
Hypolite Petovan [Mon, 23 Jul 2018 14:43:39 +0000 (10:43 -0400)]
Add missing space between PHP path and script in App->proc_run (#5468)

6 years agoMerge pull request #5431 from MrPetovan/task/5410-rename-database-methods
Michael Vogel [Mon, 23 Jul 2018 13:18:58 +0000 (15:18 +0200)]
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods

Move DBA to src/ part 3.1: Rename DBA methods

6 years agoFix Fatal errors in Protocol\OStatus (#5466)
Hypolite Petovan [Mon, 23 Jul 2018 11:48:44 +0000 (07:48 -0400)]
Fix Fatal errors in Protocol\OStatus (#5466)

6 years agoAnd some more removed notices in the core (#5465)
Michael Vogel [Mon, 23 Jul 2018 11:43:18 +0000 (13:43 +0200)]
And some more removed notices in the core (#5465)

6 years agoUsing getopt for CLI arguments (#5446)
Philipp [Mon, 23 Jul 2018 11:40:52 +0000 (13:40 +0200)]
Using getopt for CLI arguments (#5446)

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* fixing arguments for `spawnWorker`

* Adding `use Friendica\BaseObject` to `ApiTest.php`

* Refactoring the argument-usages of Friendica

* Refactoring the argument-usages of Friendica

* removing superfluous []

6 years agoCleaned up: (#5461)
Roland Häder [Mon, 23 Jul 2018 01:19:28 +0000 (03:19 +0200)]
Cleaned up: (#5461)

- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)

6 years agoCleanup: (#5463)
Roland Häder [Mon, 23 Jul 2018 01:18:21 +0000 (03:18 +0200)]
Cleanup: (#5463)

- rewrote x() to empty() as it is deprecated
- fixed indending for some entries

6 years agoFixes: (#5462)
Roland Häder [Mon, 23 Jul 2018 01:17:44 +0000 (03:17 +0200)]
Fixes: (#5462)
- fixed E_NOTICE about missing array element "page-flags-raw" (should be
  "page_flags_raw"?)
- same with account-type-raw -> account_type_raw
- added spaces to nicely indent code

6 years agoPrevents 4 E_NOTICEs when POST fields are not set. (#5458)
Roland Häder [Sun, 22 Jul 2018 23:49:16 +0000 (01:49 +0200)]
Prevents 4 E_NOTICEs when POST fields are not set. (#5458)

* Prevents 4 E_NOTICEs when POST fields are not set.

* Don't use x().

* Replaced usage of x() which is deprecated with !isset().

* Use empty() according to MrPetovan

6 years agoRename DBA::get_db to DBA::getConnection
Hypolite Petovan [Sat, 21 Jul 2018 02:11:11 +0000 (22:11 -0400)]
Rename DBA::get_db to DBA::getConnection

- Rename DBA::$db to DBA::$connection

6 years agoRename DBA::num_rows to DBA::numRows
Hypolite Petovan [Sat, 21 Jul 2018 02:05:12 +0000 (22:05 -0400)]
Rename DBA::num_rows to DBA::numRows

6 years agoRename DBA::server_info to DBA::serverInfo
Hypolite Petovan [Sat, 21 Jul 2018 02:04:43 +0000 (22:04 -0400)]
Rename DBA::server_info to DBA::serverInfo

6 years agoRename DBA::inArray to DBA::toArray
Hypolite Petovan [Sat, 21 Jul 2018 02:03:40 +0000 (22:03 -0400)]
Rename DBA::inArray to DBA::toArray

6 years agoRename DBA::fetch_first to DBA::fetchFirst
Hypolite Petovan [Sat, 21 Jul 2018 02:01:53 +0000 (22:01 -0400)]
Rename DBA::fetch_first to DBA::fetchFirst

6 years agoRename DBA::database_name to DBA::databaseName
Hypolite Petovan [Sat, 21 Jul 2018 02:00:16 +0000 (22:00 -0400)]
Rename DBA::database_name to DBA::databaseName

6 years agoRename DBA::clean_query to DBA::cleanQuery
Hypolite Petovan [Sat, 21 Jul 2018 01:59:17 +0000 (21:59 -0400)]
Rename DBA::clean_query to DBA::cleanQuery

6 years agoRename DBA::any_value_fallback to DBA::anyValueFallback
Hypolite Petovan [Sat, 21 Jul 2018 01:58:30 +0000 (21:58 -0400)]
Rename DBA::any_value_fallback to DBA::anyValueFallback

6 years agoRename DBA::affected_rows to DBA::affectedRows
Hypolite Petovan [Sat, 21 Jul 2018 01:58:15 +0000 (21:58 -0400)]
Rename DBA::affected_rows to DBA::affectedRows

6 years agoNeed to load "verb" from notify table, too. This whole thing is a maintenance (#5459)
Roland Häder [Sun, 22 Jul 2018 23:25:07 +0000 (01:25 +0200)]
Need to load "verb" from notify table, too. This whole thing is a maintenance (#5459)

nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.

6 years agoFix Fatal error in Protocol\Diaspora (#5460)
Hypolite Petovan [Sun, 22 Jul 2018 23:22:41 +0000 (19:22 -0400)]
Fix Fatal error in Protocol\Diaspora (#5460)

6 years agoFixed E_NOTICE when no valid result has been returned. (#5457)
Roland Häder [Sun, 22 Jul 2018 22:05:10 +0000 (00:05 +0200)]
Fixed E_NOTICE when no valid result has been returned. (#5457)

6 years agoFixed E_NOTICEs when uploading profile picture (#5456)
Roland Häder [Sun, 22 Jul 2018 20:01:14 +0000 (22:01 +0200)]
Fixed E_NOTICEs when uploading profile picture (#5456)

* Fixed E_NOTICEs when uploading profile picture.

* Fixed E_NOTICEs when $_POST doesn't contain these fields.

6 years agoUncommon logger levels in Friendica (#5453)
Roland Häder [Sun, 22 Jul 2018 18:07:44 +0000 (20:07 +0200)]
Uncommon logger levels in Friendica (#5453)

* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)

6 years agoFix yet another Fatal Error in Protocol\OStatus (#5454)
Hypolite Petovan [Sun, 22 Jul 2018 17:32:34 +0000 (13:32 -0400)]
Fix yet another Fatal Error in Protocol\OStatus (#5454)

6 years ago Fix another Fatal error in Protocol\OStatus (#5451)
Hypolite Petovan [Sun, 22 Jul 2018 16:57:33 +0000 (12:57 -0400)]
 Fix another Fatal error in Protocol\OStatus (#5451)

* Fix Fatal error in Protocol\OStatus

* Fix another Fatal error in Protocol\OStatus

6 years agoFixed E_NOTICE in boot.php and DBA class (#5430)
Roland Häder [Sun, 22 Jul 2018 16:53:46 +0000 (18:53 +0200)]
Fixed E_NOTICE in boot.php and DBA class (#5430)

* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed:
- better use `false` and `$port > 0`

* And better only provide `$port` when larger zero.

* Initialize `$port` with zero value (int) and not `false` (bool).

* Removed duplicate mysqli "import".

* `$post_update` is no longer used. Instead `$prefix` needs to be checked.

6 years agoFix Fatal error in Protocol\OStatus (#5450)
Hypolite Petovan [Sun, 22 Jul 2018 16:52:38 +0000 (12:52 -0400)]
Fix Fatal error in Protocol\OStatus (#5450)

6 years agoFixes/tye-hints (#5449)
Roland Häder [Sun, 22 Jul 2018 16:35:20 +0000 (18:35 +0200)]
Fixes/tye-hints (#5449)

- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
  `if (!empty($foo['bar']))` instead

6 years agoThere is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (...
Roland Häder [Sun, 22 Jul 2018 16:33:28 +0000 (18:33 +0200)]
There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (#5448)

declare it and push all other numbers higher or use LOGGER_NORMAL.

6 years agoFixes: (#5447)
Roland Häder [Sun, 22 Jul 2018 16:28:39 +0000 (18:28 +0200)]
Fixes: (#5447)
- rewrote to first check if PID file is readable, then if found load it
- next addition is to cast it's content to int. Any non-integer content will
  result in 0 (as I know).
- Give warnings a voice! (xdebug's scream option showed a warning)
- added some spaces for better readability

6 years agoAdded a for-loop (#5442)
Jeroen De Meerleer [Sat, 21 Jul 2018 21:29:39 +0000 (23:29 +0200)]
Added a for-loop (#5442)

* Using json_decode instead of reinventing hot water

Guys, you could have told me ;)

* changed spaces to tabs

* Guess I'll need a beer ;)

6 years agoWorker-details: Using json_decode instead of reinventing hot water (#5441)
Jeroen De Meerleer [Sat, 21 Jul 2018 17:24:03 +0000 (19:24 +0200)]
Worker-details: Using json_decode instead of reinventing hot water (#5441)

* Using json_decode instead of reinventing hot water

Guys, you could have told me ;)

* changed spaces to tabs

6 years agoDBStructure enhancements (#5437)
Philipp [Sat, 21 Jul 2018 12:43:43 +0000 (14:43 +0200)]
DBStructure enhancements (#5437)

* Adding DBStructure enhancements

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 4ae06ec)

* Adding `pre_update_1279` method

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 8496d84)

* code standards

(cherry picked from commit 551d09b)

* simplify to `empty` instead `is_null`

(cherry picked from commit ce68835)

6 years agoMake frio more consistent by replacing textual links with icons everywhere. (#5415)
Andreas Neustifter [Sat, 21 Jul 2018 11:31:05 +0000 (13:31 +0200)]
Make frio more consistent by replacing textual links with icons everywhere. (#5415)

* Make frio more consistent by replacing textual links with icons everywhere I could find them.

* [frio] Move profile add link to icon.

6 years agoMerge pull request #5435 from annando/htaccess
Tobias Diekershoff [Sat, 21 Jul 2018 05:48:15 +0000 (07:48 +0200)]
Merge pull request #5435 from annando/htaccess

Automatically create a .htaccess when not existing

6 years agoAutomatically create a .htaccess when not existing
Michael [Sat, 21 Jul 2018 05:41:19 +0000 (05:41 +0000)]
Automatically create a .htaccess when not existing

6 years agoMerge pull request #5433 from annando/mysqli
Tobias Diekershoff [Sat, 21 Jul 2018 05:18:10 +0000 (07:18 +0200)]
Merge pull request #5433 from annando/mysqli

Forgotten "use"

6 years agoForgotten "use"
Michael [Sat, 21 Jul 2018 05:09:09 +0000 (05:09 +0000)]
Forgotten "use"

6 years agoOne more notice (#5429)
Michael Vogel [Sat, 21 Jul 2018 00:43:22 +0000 (02:43 +0200)]
One more notice (#5429)

* Some more notices

* And some more notice in the worker

6 years agorenamed .htaccess to .htaccess-dist and ignored .htaccess afterwards (#5428)
Roland Häder [Sat, 21 Jul 2018 00:27:37 +0000 (02:27 +0200)]
renamed .htaccess to .htaccess-dist and ignored .htaccess afterwards (#5428)

* renamed .htaccess to .htaccess-dist and ignored .htaccess afterwards. This
allows local changes to it without having a dirty checkout directory.

Signed-off-by: Roland Häder <roland@mxchange.org>
* Some fixes:
- removed non-neutral words
- added examples for Linux/Windows

* Better documentation and added note about **not** renaming the file.

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoWe now have a pre update script (#5425)
Michael Vogel [Fri, 20 Jul 2018 19:47:16 +0000 (21:47 +0200)]
We now have a pre update script (#5425)

* We now have a pre update script

* Some optimized stuff

6 years ago[frio] Restyle album edit header. (#5426)
Andreas Neustifter [Fri, 20 Jul 2018 19:23:51 +0000 (21:23 +0200)]
[frio] Restyle album edit header. (#5426)

6 years ago[frio] Restyle photo upload (#5427)
Andreas Neustifter [Fri, 20 Jul 2018 19:23:12 +0000 (21:23 +0200)]
[frio] Restyle photo upload (#5427)

* Better wording in photo upload.

* [frio] Restyle photo uploader to conform to frio style.

6 years agoSome more notices (#5424)
Michael Vogel [Fri, 20 Jul 2018 18:07:54 +0000 (20:07 +0200)]
Some more notices (#5424)

6 years agoMerge pull request #5422 from MrPetovan/task/5410-rename-dba-to-DBA
Michael Vogel [Fri, 20 Jul 2018 17:44:54 +0000 (19:44 +0200)]
Merge pull request #5422 from MrPetovan/task/5410-rename-dba-to-DBA

Rename Friendica\Database\dba to Friendica\Database\DBA

6 years agoRename Friendica\Database\dba to Friendica\Database\DBA
Hypolite Petovan [Fri, 20 Jul 2018 12:19:26 +0000 (08:19 -0400)]
Rename Friendica\Database\dba to Friendica\Database\DBA

6 years agoMerge pull request #5420 from annando/notices
Tobias Diekershoff [Fri, 20 Jul 2018 10:46:42 +0000 (12:46 +0200)]
Merge pull request #5420 from annando/notices

Just some more fixed notice

6 years agoMerge pull request #5421 from annando/fatal
Tobias Diekershoff [Fri, 20 Jul 2018 10:45:00 +0000 (12:45 +0200)]
Merge pull request #5421 from annando/fatal

Wrong "use" for config

6 years agoWrong "use" for config
Michael [Fri, 20 Jul 2018 06:04:23 +0000 (06:04 +0000)]
Wrong "use" for config

6 years agoJust some more fixed notice
Michael [Fri, 20 Jul 2018 05:31:26 +0000 (05:31 +0000)]
Just some more fixed notice

6 years agoMerge pull request #5419 from annando/fixes
Michael Vogel [Fri, 20 Jul 2018 05:13:24 +0000 (07:13 +0200)]
Merge pull request #5419 from annando/fixes

Makes Diaspora working again

6 years agoMakes Diaspora working again
Michael [Fri, 20 Jul 2018 05:10:16 +0000 (05:10 +0000)]
Makes Diaspora working again

6 years agoMerge pull request #5418 from MrPetovan/task/5410-move-dba-to-src
Michael Vogel [Fri, 20 Jul 2018 04:50:36 +0000 (06:50 +0200)]
Merge pull request #5418 from MrPetovan/task/5410-move-dba-to-src

Move \dba to \Friendica\Database\dba

6 years agoAdd missing PDO* use statements in Database\dba
Hypolite Petovan [Fri, 20 Jul 2018 02:24:03 +0000 (22:24 -0400)]
Add missing PDO* use statements in Database\dba

6 years agoRemove class \dba from include/dba
Hypolite Petovan [Fri, 20 Jul 2018 02:15:57 +0000 (22:15 -0400)]
Remove class \dba from include/dba

6 years agoUpdate use statement lists with new Friendica\Database\dba class
Hypolite Petovan [Fri, 20 Jul 2018 02:15:21 +0000 (22:15 -0400)]
Update use statement lists with new Friendica\Database\dba class

- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements

6 years agoAdd new Friendica\Database\dba class
Hypolite Petovan [Fri, 20 Jul 2018 02:06:13 +0000 (22:06 -0400)]
Add new Friendica\Database\dba class

6 years agoMisc cleanups (#5417)
Roland Häder [Fri, 20 Jul 2018 00:52:18 +0000 (02:52 +0200)]
Misc cleanups (#5417)

* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>
* reverted back

Signed-off-by: Roland Häder <roland@mxchange.org>
* Added type-hint 'array' as the method uses foreach() on it.

Signed-off-by: Roland Häder <roland@mxchange.org>
* Tpzo fixed ...

Signed-off-by: Roland Häder <roland@mxchange.org>
* Added missing new-line at end of file, will make some POSIX parsers being lesser
confused ...

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoLittle fixes (#5414)
Michael Vogel [Thu, 19 Jul 2018 22:40:39 +0000 (00:40 +0200)]
Little fixes (#5414)

* We now store the item delivery data in a separate table

* Reorganized table structure

* Fix  a notice when using the profiler / ensure that permissions are strings

6 years agoSmall cleanup (#5416)
Roland Häder [Thu, 19 Jul 2018 22:39:05 +0000 (00:39 +0200)]
Small cleanup (#5416)

- added internal TODO to decide about is_result() usage
- removed semicolon (not needed here) from SQL query
- added empty line

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFix photo-upload and croping. (#5412)
Andreas Neustifter [Thu, 19 Jul 2018 21:59:18 +0000 (23:59 +0200)]
Fix photo-upload and croping. (#5412)

6 years agoWe now store the item delivery data in a separate table (#5413)
Michael Vogel [Thu, 19 Jul 2018 21:56:52 +0000 (23:56 +0200)]
We now store the item delivery data in a separate table (#5413)

* We now store the item delivery data in a separate table

* Reorganized table structure

6 years agoIssue 5407: Workers didn't start anymore (#5409)
Michael Vogel [Thu, 19 Jul 2018 15:05:17 +0000 (17:05 +0200)]
Issue 5407: Workers didn't start anymore (#5409)

6 years agoWorkerqueue param reformat (#5403)
Jeroen De Meerleer [Thu, 19 Jul 2018 13:52:48 +0000 (15:52 +0200)]
Workerqueue param reformat (#5403)

* Prettified the parameter layout of workerqueue

* Updated to code standards :)

* Where did I go wrong?

* Seems like someone needs to sleep ;)

6 years agoNew item field "Post-type" and new table "permissionset" (#5408)
Michael Vogel [Thu, 19 Jul 2018 13:52:05 +0000 (15:52 +0200)]
New item field "Post-type" and new table "permissionset" (#5408)

* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* Changed documentation

6 years agoFixes applied: (#5399)
Roland Häder [Thu, 19 Jul 2018 11:11:03 +0000 (13:11 +0200)]
Fixes applied: (#5399)

- $_SESSION['remember_user'] did only exist here and no where else
- it seems to be accient old-lost code, so I fixed it to $a->user['nickname']
  instead
- used multi-line comment for multiple lines of on-line comments

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFixes: (#5404)
Roland Häder [Thu, 19 Jul 2018 11:07:14 +0000 (13:07 +0200)]
Fixes: (#5404)
- fixed E_NOTICE in mod/follow.php
- fixed 2 E_NOTICE in src/Protocol/Diaspora.php
- added more type-hints for `array` type where known

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoMerge pull request #5406 from tobiasd/20180717-msg
Michael Vogel [Thu, 19 Jul 2018 06:45:54 +0000 (08:45 +0200)]
Merge pull request #5406 from tobiasd/20180717-msg

regen master messages.po

6 years agoregen master messages.po
Tobias Diekershoff [Thu, 19 Jul 2018 04:40:31 +0000 (06:40 +0200)]
regen master messages.po

6 years agoAdded warning for special characters in docs and template (#5402)
Jeroen De Meerleer [Wed, 18 Jul 2018 21:30:34 +0000 (23:30 +0200)]
Added warning for special characters in docs and template (#5402)

6 years agoAccording to @annando and @MrPetovan, $emailcc is no `item` field (column) and (...
Roland Häder [Wed, 18 Jul 2018 21:26:14 +0000 (23:26 +0200)]
According to @annando and @MrPetovan, $emailcc is no `item` field (column) and (#5401)

should be initialized empty (I did it above the `if()` block).

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFix tests (#5400)
Pierre Rudloff [Wed, 18 Jul 2018 20:30:55 +0000 (22:30 +0200)]
Fix tests (#5400)

* Avoid argc side-effects

* Fix undefined array keys in JITConfigAdapter::set()

* Avoid argv side effects in ApiTest

6 years agoPrettified the parameter layout of workerqueue (#5397)
Jeroen De Meerleer [Wed, 18 Jul 2018 20:24:35 +0000 (22:24 +0200)]
Prettified the parameter layout of workerqueue (#5397)

* Prettified the parameter layout of workerqueue

* Updated to code standards :)

* Where did I go wrong?

6 years agoFixed E_NOTICE when no 'term' was provided (#5391)
Roland Häder [Wed, 18 Jul 2018 19:41:24 +0000 (21:41 +0200)]
Fixed E_NOTICE when no 'term' was provided (#5391)

* Fixed E_NOTICE when no 'term' was provided, maybe better encapsulate this whole
$_GET, $_POST and $_SESSION thing into a `Request` class?

Signed-off-by: Roland Häder <roland@mxchange.org>
* Rewrote to recommendation by @MrPetovan which results in really nicer code.

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFix silent exit in ApiTest::testApiMediaUploadWithMedia() (#5398)
Pierre Rudloff [Wed, 18 Jul 2018 19:36:51 +0000 (21:36 +0200)]
Fix silent exit in ApiTest::testApiMediaUploadWithMedia() (#5398)

6 years agoswitch the Vagrant VM to the new config system (#5396)
Tobias Diekershoff [Wed, 18 Jul 2018 19:32:24 +0000 (21:32 +0200)]
switch the Vagrant VM to the new config system (#5396)

6 years agosimplifying unittests (#5395)
Philipp [Wed, 18 Jul 2018 19:04:18 +0000 (21:04 +0200)]
simplifying unittests (#5395)

* simplifying unittests

- use @requires instead class_exist
- define @small and @medium

* simplifying unittests

- removed unnecessary throwings

6 years agoMerge pull request #5394 from MrPetovan/bug/fix-config-set-return-value
Michael Vogel [Wed, 18 Jul 2018 09:07:10 +0000 (11:07 +0200)]
Merge pull request #5394 from MrPetovan/bug/fix-config-set-return-value

Change (P)Config::set return value to bool

6 years agoMerge pull request #5295 from MrPetovan/task/4889-move-config-to-config
Michael Vogel [Wed, 18 Jul 2018 09:04:35 +0000 (11:04 +0200)]
Merge pull request #5295 from MrPetovan/task/4889-move-config-to-config

Move configuration to config/

6 years agoChange (P)Config::set return value to bool
Hypolite Petovan [Wed, 18 Jul 2018 06:32:35 +0000 (02:32 -0400)]
Change (P)Config::set return value to bool

6 years agoFix notice in Util\Network
Hypolite Petovan [Wed, 18 Jul 2018 01:00:22 +0000 (21:00 -0400)]
Fix notice in Util\Network

6 years agoFixes for E_NOTICE in mod/item.php (#5393)
Roland Häder [Tue, 17 Jul 2018 22:18:42 +0000 (00:18 +0200)]
Fixes for E_NOTICE in mod/item.php (#5393)

* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
  the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes E_NOTICE of missing variable (PHP's lazyness again).

Signed-off-by: Roland Häder <roland@mxchange.org>
* Use !empty() to avoid accessing empty array.

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFixes for OEmbed class (#5392)
Roland Häder [Tue, 17 Jul 2018 20:28:20 +0000 (22:28 +0200)]
Fixes for OEmbed class (#5392)

* Fixes:
- stdClass is clearly an object of `\stdClass`, so let's import it and set it
  as type-hint here
- if $o->type is not found, don't continue

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fix for a fix due to 02:51 a.m. (!) edits ...

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoImprove Console/Config display for array values
Hypolite Petovan [Tue, 17 Jul 2018 06:15:05 +0000 (02:15 -0400)]
Improve Console/Config display for array values

- Prevent setting a config key that is an array

6 years agoAdd support for legacy $lang config in App->loadConfig
Hypolite Petovan [Tue, 17 Jul 2018 06:05:52 +0000 (02:05 -0400)]
Add support for legacy $lang config in App->loadConfig

6 years agoRemove exception for legacy config file in App->loadDatabase
Hypolite Petovan [Tue, 17 Jul 2018 06:05:36 +0000 (02:05 -0400)]
Remove exception for legacy config file in App->loadDatabase

6 years agoFix config value type in MemcachedCacheDriver
Hypolite Petovan [Tue, 17 Jul 2018 06:05:06 +0000 (02:05 -0400)]
Fix config value type in MemcachedCacheDriver

- Remove default config values set in CacheDriverFactory

6 years agoImprove help/Config page
Hypolite Petovan [Tue, 17 Jul 2018 06:03:39 +0000 (02:03 -0400)]
Improve help/Config page

- Remove obsolete file-only config list
- Fix heading level
- Add transition instruction for $lang
- Add reference to config.ini.php, settings.ini.php and addon.ini.php
- Add link to help page in admin warning about legacy config file

6 years agoFixed E_NOTICE when 'title' is absent (uninitialized array key) (#5390)
Roland Häder [Tue, 17 Jul 2018 05:13:22 +0000 (07:13 +0200)]
Fixed E_NOTICE when 'title' is absent (uninitialized array key) (#5390)

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoSeparate default config values between file-only and admin settings
Hypolite Petovan [Mon, 16 Jul 2018 23:07:46 +0000 (19:07 -0400)]
Separate default config values between file-only and admin settings

6 years agoEnforce systen.register_policy value type
Hypolite Petovan [Sun, 15 Jul 2018 19:04:48 +0000 (15:04 -0400)]
Enforce systen.register_policy value type

6 years agoCode standards in App
Hypolite Petovan [Sun, 15 Jul 2018 16:44:32 +0000 (12:44 -0400)]
Code standards in App

6 years agoFix typo in mod/admin
Hypolite Petovan [Sun, 15 Jul 2018 16:44:19 +0000 (12:44 -0400)]
Fix typo in mod/admin

6 years agoRemove remaining references to Config::get in include/dba
Hypolite Petovan [Sun, 15 Jul 2018 16:44:10 +0000 (12:44 -0400)]
Remove remaining references to Config::get in include/dba

6 years agoImprove console/config display
Hypolite Petovan [Thu, 12 Jul 2018 03:00:44 +0000 (23:00 -0400)]
Improve console/config display

- Add visual distinction between get/set value

6 years agoFix undefined index in mod/settings
Hypolite Petovan [Thu, 12 Jul 2018 02:58:52 +0000 (22:58 -0400)]
Fix undefined index in mod/settings

6 years agoMove the addon-specific config in config/addon.ini.php
Hypolite Petovan [Thu, 12 Jul 2018 02:58:37 +0000 (22:58 -0400)]
Move the addon-specific config in config/addon.ini.php

- Add sample addon.ini.php file
- Add config/addon.ini.php file to git ignore