Brion Vibber [Mon, 30 Nov 2009 16:09:30 +0000 (08:09 -0800)]
Ticket 1870: drop unnecessary Tidy module installation requirement.
Tidy was only being used by a couple of non-default URL shortener plugins,
PtitUrl and TightUrl. Both were easily changed to load the tag-soup HTML
via DOMDocument (using the default DOM module which is already used by
other dependencies).
Added xml, dom, and simplexml modules to the requirements check
in install.php, as they were being used but not checked for.
Also cleaned up LilUrl, PtitUrl, and TightUrl to return URL as a string
instead of as a SimpleXML node object.
Brion Vibber [Fri, 27 Nov 2009 22:52:58 +0000 (14:52 -0800)]
Fix regression in group posting: bug introduced in commit 1319002e1519fafb0e82fbfd2d2723abdb3112e7. Need to use actual profile object rather than an id on a variable that doesn't exist when checking blocks :D
Zach Copley [Thu, 26 Nov 2009 02:21:23 +0000 (02:21 +0000)]
Some changes to the OpenID DataObjects to make them emit the exact same
.ini info as what used to be in statusnet.ini before OpenID was pulled
out into a plugin.
Brion Vibber [Wed, 25 Nov 2009 22:10:55 +0000 (22:10 +0000)]
Fix regression in remote subscription; added hasRole() shadow method on Remote_profile.
DB_DataObject hides errors by silently returning null for any non-existent method call, making it harder to tell what the heck's going on... the rights check for blocked remote users returned null for the check for subscribe rights, thus eval'ing to false. We now log a note in this circumstance, which would have cut about 3 hours off of the debug time.
Sarven Capadisli [Wed, 25 Nov 2009 21:32:51 +0000 (21:32 +0000)]
I can't hide the location and status bars in Firefox, IE or Chromium.
It only works in Safari and Opera.
https://developer.mozilla.org/En/DOM/Window.open confirms that by
default, Firefox and IE forces their presence.
Brion Vibber [Tue, 24 Nov 2009 23:29:47 +0000 (15:29 -0800)]
Fix regression in OMB sending with queues enabled -- items never got dequeued, leading to ever-growing queue and big delays.
Success return code from omb_broadcast_message was dropped in commit ec88d2650ea4371cf53229171851747b31587e4b (Aug 10 2009) which switched us to libomb backend. With queues enabled, this would lead to the notice being readded to the outgoing OMB queue for redelivery as the queue system thought the send failed. The resends caused extra load and confusion for third-party sites, and more worryingly just plugged up our own queue so legit messages were badly delayed.
This commit should restore the previous state, where we fire-and-forget; that is, we're not actually checking to see if all remote subscribers received the message successfully and there will be no resends.
Brion Vibber [Tue, 24 Nov 2009 17:38:16 +0000 (09:38 -0800)]
Break TableDef, ColumnDef classes to separate files so autoloader can find them.
With $config['db']['schemacheck'] set to 'script' in live deployment, Schema class wasn't being preloaded for us; the uses of TableDef by plugins for DataObject configuration would then fail because the class wasn't loaded. Broken to separate files, the autoloader can find all classes in either case.
PHP Fatal error: Class 'TableDef' not found in /var/www/statusnet/plugins/OpenID/User_openid.php on line 43, referer: http://identi.ca/brionv/all
Brion Vibber [Sat, 21 Nov 2009 00:34:01 +0000 (16:34 -0800)]
Disable XHTML Content-Type negotiation... You've foiled our plans for the last time!
XHTML mode breaks a lot of JS and has been causing trouble for Safari and Chrome, especially with the fancier new UI-side plugins like realtime and maps.
Brion Vibber [Fri, 20 Nov 2009 22:52:29 +0000 (14:52 -0800)]
Fix bug 1997: notice search rss utter failure
Since commit c4072ef7c930b82b74f8e90f6554974b761c686c in March there's no longer an automatic run of $this->getNotices() from RssAction parent class; added to the subclass.
It might make sense to put it back in the parent class, but of course only if those dupe calls can be resolved.