Continued:
- used dbm::is_result() to avoid E_WARNING when false is returned
- added curly braces + some spaces

Signed-off-by: Roland Haeder <roland@mxchange.org>

added spaces and curly braces

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued:
- added curly braces/spaces
- changed lower-case SQL keywords to upper-case
- used dbm::is_result() instead of count() (avoids warning in case of false is
  returned)

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed old-lost code + internal TODO closed

Signed-off-by: Roland Haeder <roland@mxchange.org>

merged 2 if() into one, closes internal TODO

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed parentheses, added curly ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed TODO, one day this all needs refacturizing ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

rewrote to static approach and if() condition can be simplified.

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed parentheses and indended it for better readability

Signed-off-by: Roland Haeder <roland@mxchange.org>

added spaces/curly braces and TODO for better using trim()

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed old-lost code

Signed-off-by: Roland Haeder <roland@mxchange.org>

changed "and" -> && according to CR

Signed-off-by: Roland Haeder <roland@mxchange.org>

added spaces, removed parentheses. there is more ahead than just this one.

Signed-off-by: Roland Haeder <roland@mxchange.org>

space-time season continues ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

it is space-time! ;-)

Signed-off-by: Roland Haeder <roland@mxchange.org>

added more spaces (CR request)

Signed-off-by: Roland Haeder <roland@mxchange.org>

added more curly braces/spaces

Signed-off-by: Roland Haeder <roland@mxchange.org>

killme() does the same here + added curly braces

Signed-off-by: Roland Haeder <roland@mxchange.org>

Opps, became lazy here, thanks to @Hypolite finding it.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued:
- some spaces added
- removed parentheses as requested by @Hypolite
- added really important TODO as remote-inclusion is not what you want

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed parentheses + added TODO about a small rewrite

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued:
- marked commented-out code as possible old-lost
- added more curly braces
- used more dbm::is_result() where SELECT is stated
- ! added quotes in array element, else (here) >thumb< (without quotes) is
  considered as a constant and causes an E_NOTICE

Signed-off-by: Roland Haeder <roland@mxchange.org>

fixed parser error

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued:
- converted multiple single-line comments into one multi-line comment (please
  stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch

Signed-off-by: Roland Haeder <roland@mxchange.org>

fixed comment and explained one

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued with #3254:
- added curly braces + spaces
- converted multiple single-line comments to one multi-line comment

Signed-off-by: Roland Haeder <roland@mxchange.org>

added more curly braces + spaces for #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued #3254:
- thrown out old lost-code
- add curly braces (not curely ;-) ) and spaces
- exit is not a keyword, it is a function, so use () here

Signed-off-by: Roland Haeder <roland@mxchange.org>

added curely braces + TODO for maybe avoiding multi-lined if() blocks as it confuses #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

old behaviour restored

Signed-off-by: Roland Haeder <roland@mxchange.org>

added more spaces and curely braces
killed ?> as it is discouraged

Signed-off-by: Roland Haeder <roland@mxchange.org>

added curely branches + reverted back to old behaviour (may come back one day)

Signed-off-by: Roland Haeder <roland@mxchange.org>

better comment added by @Hypolite

Signed-off-by: Roland Haeder <roland@mxchange.org>

more spaces added (CR by @Hypolite)

Signed-off-by: Roland Haeder <roland@mxchange.org>

it is space-season ... ;-) #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

closed internal TODO, merged 2 if() to one + added spaces

Signed-off-by: Roland Haeder <roland@mxchange.org>

yet another one removed, thanks to @Hypolite for CR

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed no longer old stuff, let's don't stuff code with commented-out code

Signed-off-by: Roland Haeder <roland@mxchange.org>

added more spaces #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

No parantheses here + no @ (which surpresses warnings and such) #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

Opps, missed one ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

added curly braces #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

replaced some tabs -> spaces + added curly braces #3254

Signed-off-by: Roland Haeder <roland@mxchange.org>

added missing spaces/curly braces

Signed-off-by: Roland Häder <roland@mxchange.org>

Continued:
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
  long time around in PHP) anything can be handled over to the method/function.

Signed-off-by: Roland Häder <roland@mxchange.org>

added more curly braces + a bit more usage of dbm::is_result()

Signed-off-by: Roland Häder <roland@mxchange.org>

Merge pull request #3253 from friendica/revert-3112-rewrites/coding-convention

Revert "Coding convention applied - part 1"

Revert "Coding convention applied - part 1"

Merge pull request #3112 from Quix0r/rewrites/coding-convention

Coding convention applied - part 1

Merge pull request #3246 from annando/1701-poco

Split poco discovery in smaller function calls

Merge remote-tracking branch 'upstream/develop' into rewrites/coding-convention

Signed-off-by: Roland Haeder <roland@mxchange.org>

Merge pull request #3241 from rabuzarus/20170316_-_fix_event_edit

add dop event & fix event edit

add missed NULL_DATE

Merge origin/20170316_-_fix_event_edit into 20170316_-_fix_event_edit

Conflicts:
mod/events.php

add NULL_DATE & coding standard work

Merge develop into 20170316_-_fix_event_edit

Conflicts:
mod/events.php

Merge branch 'develop' into 20170316_-_fix_event_edit

Merge pull request #3250 from tobiasd/20170320-msg

regenerated master messages.po file

regenerated master messages.po file

Merge pull request #3247 from annando/issue-3242-b

If the maintenance reason is a url, then redirect to this address

Test code removed

Enhanced explanation

Merge pull request #3249 from annando/bugfix-dbstructure

Bugfix for issue 3242 - forgotten "use"

Bugfix for issue 3242 - forgotten "use"

Standards and just some more poco slitting

If the maintenance reason is a url, then redirect to this address

Added documention

Split the POCO discovery process in several small processes

Merge remote-tracking branch 'upstream/develop' into 1701-poco

Conflicts:
include/socgraph.php

Merge pull request #3245 from annando/issue-3242

Issue 3242: Define a maintenance reason

Merge pull request #3243 from annando/1702-null-date

Datetime compatibility to MySQL restored

Standards, like always

Some more standards

Issue 3242: Define a maintenance reason

Merge remote-tracking branch 'upstream/develop' into 1702-null-date

Standards, what else?

You shoudln't use a text variable like an array.

added spaces according to coding-convention

Signed-off-by: Roland Haeder <roland@mxchange.org>

old-lost update way, no need for TODO around.

Signed-off-by: Roland Haeder <roland@mxchange.org>

removed MyISAM ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

added logger ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

added spaces around + curly braces ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

better log here ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

Continued:
- added curly braces
- added TODO
- removed TODO (no change needed, is fine)

Signed-off-by: Roland Häder <roland@mxchange.org>

don't quit silently, at least a TODO is now around

Signed-off-by: Roland Häder <roland@mxchange.org>

Missed a 't', thanks to @annando

Signed-off-by: Roland Häder <roland@mxchange.org>

more spaces + some curly spaces added

Signed-off-by: Roland Häder <roland@mxchange.org>

added spaces + some curly braces

Signed-off-by: Roland Häder <roland@mxchange.org>

added spaces + some curly braces + some usage of dbm::is_result()

Signed-off-by: Roland Häder <roland@mxchange.org>

Continued:
- added missing spaces/curly braces
- some more usage of dbm::is_result()
- 2 oppsite if() statements can be mored to else
- added more TODOs for type-hinting

Signed-off-by: Roland Häder <roland@mxchange.org>

Continued:
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
  long time around in PHP) anything can be handled over to the method/function.

Signed-off-by: Roland Häder <roland@mxchange.org>

Opps ...

Signed-off-by: Roland Häder <roland@mxchange.org>

added more curly braces + a bit more usage of dbm::is_result()

Signed-off-by: Roland Häder <roland@mxchange.org>

added more spaces/curly braces

Signed-off-by: Roland Häder <roland@mxchange.org>

unified most db upgrades:
- common way is to check on result ($r mostly) of db upgrade
- on success, return UPDATE_SUCCESS
- on failure, return UPDATE_FAILED

Signed-off-by: Roland Häder <roland@mxchange.org>

added curly braces + removed more useless intval() calls on file_exists()

Signed-off-by: Roland Häder <roland@mxchange.org>

fixed chmod

Signed-off-by: Roland Häder <roland@mxchange.org>

Continued a bit:
- converted some else if to elseif (only PHP)
- converted some space -> tab (intending)

Signed-off-by: Roland Häder <roland@mxchange.org>

Merge pull request #3244 from annando/bugfix-text

You shouldn't use a text variable like an array.

added spaces (coding convention)

Signed-off-by: Roland Häder <roland@mxchange.org>