Roland Häder [Sun, 10 May 2020 04:57:40 +0000 (06:57 +0200)]
Continued:
- also headquarter cannot have direct reference to employee as this would result
in recursive call as the headquarter's employee may also be compared
Roland Häder [Sun, 10 May 2020 04:37:52 +0000 (06:37 +0200)]
Continued:
- added to re-add departmentLead in equals()/hashCode() methods but now as
Contact and not Employee. In Employee you have a Department instance again,
leading to endless recursive calls / stack overflow.
Roland Häder [Sat, 9 May 2020 23:47:53 +0000 (01:47 +0200)]
Continued:
- renamed other to fooEntity
- renamed logoUploader to logoUploaderUser
- added missing members to equals()/hashCode()
- sorted members in equals()/hashCode() methods
Roland Häder [Sun, 26 Apr 2020 17:15:41 +0000 (19:15 +0200)]
Continued:
- need to compare all entity properties in equals()/hashCode()
- renamed some fields from fooCreated to fooEntryCreated
- added some missing fooEntryUpdated fields
Roland Häder [Thu, 10 Oct 2019 20:46:53 +0000 (22:46 +0200)]
Continued:
- renamed JobPosition to HireableJobPosition (tpzo in first syllable) and added
methods from jjobs-core as this was redundant anyway (and didn't work in the
end)
- added JobPositionStatus (enum) from jjobs-core
Roland Häder [Thu, 13 Dec 2018 16:03:47 +0000 (17:03 +0100)]
Continued:
- if all 3 employee's relations are NULL, throw an NPE: branch office, personal
data and headquarter
- basic company data is always required
Roland Häder [Mon, 19 Mar 2018 21:59:06 +0000 (22:59 +0100)]
Continued:
- Objects.equals() is an overdose here, as a possible null-reference has
already been checked before
- CoreNumberUtils was a bad name, SafeNumberUtils is maybe better?
Roland Häder [Mon, 19 Mar 2018 00:05:08 +0000 (01:05 +0100)]
Continued:
- jcore-utils was splitted out from jcoreee to reduce project centralization
(means you have to that whole fat bunch of classes but only use a few)
- removed no longer used jcoreee.jar
Roland Häder [Sun, 18 Mar 2018 23:35:01 +0000 (00:35 +0100)]
Continued:
- added new depdendency Apache Commons Lang3
- used their StringUtils class for null-safe comparisons
- but their NumberUtils class' compare() methods are not null-safe, so have to
take own CoreNumberUtils class instead.
Roland Häder [Sun, 18 Mar 2018 22:09:43 +0000 (23:09 +0100)]
Continued:
- ops, need to compare basic data and contact employee of branch office before
comparing the whole address
- branch office number being compared before contact employee is okay
Roland Häder [Thu, 15 Mar 2018 23:36:19 +0000 (00:36 +0100)]
Continued:
- added new dependency to jcoreee.jar
- implemented Comparable interface in all entities
- rewrote to use Comparables.checkAll()
- check for null-pointer reference
- documented thrown NPE
- added utils class for job positions
Roland Häder [Sun, 5 Nov 2017 16:35:20 +0000 (17:35 +0100)]
Continued:
- also need to check branch office or headquarter when checking if same
department, need to check department's branch office/headquarter only when one
is at least not null
- also compare last house number and extension
- sorted members
Roland Häder [Fri, 3 Nov 2017 21:41:05 +0000 (22:41 +0100)]
Continued:
- added exception for already added employees
- fixed serial numbers, must be globally unique
- sorted imports
- added utilities class for employees
Roland Häder [Thu, 2 Nov 2017 19:45:12 +0000 (20:45 +0100)]
Continued:
- renamed all occurrences of headquarters to headquarter as it was confusing on
many places, if singular or plural was used. Only Headquarters for utilities
class remain (surely).
Roland Häder [Wed, 1 Nov 2017 21:50:38 +0000 (22:50 +0100)]
Continued:
- removed Search<Entity>ById as this is considered as performance-reducing. The
reason is, that the EJB will then be more "asked" for single entries only.
- added first named query AllHeadquarters
Roland Häder [Wed, 1 Nov 2017 21:12:33 +0000 (22:12 +0100)]
Continued:
- added default constructor (required for EJB container)
- added constructor with all required fields
- added email address for headquarters
- added utils class for headquarters
- renamed branch_id to headquarters_id (copy-paste mistake)
Roland Häder [Wed, 1 Nov 2017 20:58:38 +0000 (21:58 +0100)]
Continued:
- had to rename Headquarters again, to Headquarter to make room for a tools
class, it is common to name them <Entity>s and Headquarterss is not correct
Roland Häder [Wed, 1 Nov 2017 20:21:18 +0000 (21:21 +0100)]
Continued:
- removed suffix Data, just Headquarters is okay here, not for basic data
entity, of course
- renamed exception, only company headquarters will exist
- added checked exception which is being thrown when headquarters with same
address already exists
Roland Häder [Mon, 16 Oct 2017 18:28:23 +0000 (20:28 +0200)]
Continued:
- no other employees than company/business employees will be there ...
- renamed Employee interface to a much nicer Employable name
- renamed CompanyDepartment -> BusinessDepartment as there will be other kinds
of departments (e.g. fire/police)
- renamed more company -> business, but not all
Roland Häder [Sat, 14 Oct 2017 12:59:58 +0000 (14:59 +0200)]
Continued:
- need to change CascadeType to ALL as this should be persisted and all others
- also changed back from ALL to REFRESH as the foreign entities do already exist
Roland Häder [Sat, 7 Oct 2017 22:17:52 +0000 (00:17 +0200)]
Continued (renaming-season has started):
- renamed OpeningTimes -> OpeningTime as it is a single entity anyway
- also renamed package opening_times -> opening_time
- add event for when an opening time has been added
Roland Häder [Sat, 7 Oct 2017 19:55:01 +0000 (21:55 +0200)]
Continued:
- added event when department has been added
- added exception for not-found opening times
- added utils class for departments
- fixed some tzpos here and there
- used REFRESH instead of ALL as else maybe the other entityos being duplicated
- added first 2 named queries for opening times
- renamed CompanyDepartment -> Department
Roland Häder [Sun, 24 Sep 2017 19:13:57 +0000 (21:13 +0200)]
Continued:
- user "owner" is no longer required for employee as it may not be available at
all times
- one opening-times line is maybe not enough as they may varry from day to day
projects / jcontacts-business-core.git / log