]> git.mxchange.org Git - friendica.git/log
friendica.git
2 years agoContinued:
Roland Häder [Thu, 23 Jun 2022 07:41:37 +0000 (09:41 +0200)]
Continued:
- renamed varibales to $camelCase
- added type-hints
- updated documentation

2 years agoMerge pull request #11678 from Quix0r/fixes/send-contact-accept-id-string
Hypolite Petovan [Thu, 23 Jun 2022 15:05:38 +0000 (11:05 -0400)]
Merge pull request #11678 from Quix0r/fixes/send-contact-accept-id-string

Fix for Transmitter::sendContactAccept() wrong 2nd parameter type

2 years ago$id in Transmitter::sendContactAccept() is a string, see Introduction class
Roland Häder [Thu, 23 Jun 2022 14:46:44 +0000 (16:46 +0200)]
$id in Transmitter::sendContactAccept() is a string, see Introduction class

2 years agoMerge pull request #11676 from Quix0r/fixes/array-element-missing
Hypolite Petovan [Thu, 23 Jun 2022 13:06:59 +0000 (09:06 -0400)]
Merge pull request #11676 from Quix0r/fixes/array-element-missing

Maybe this fixes missing array element

2 years agoMerge pull request #11675 from Quix0r/features/smarty-sub-directories
Hypolite Petovan [Thu, 23 Jun 2022 13:06:06 +0000 (09:06 -0400)]
Merge pull request #11675 from Quix0r/features/smarty-sub-directories

Enabled sub-directories for compiled/cache Smarty3 files

2 years agoMaybe this fixes missing array element
Roland Häder [Thu, 23 Jun 2022 05:39:27 +0000 (07:39 +0200)]
Maybe this fixes missing array element

2 years agoSo simple ... Ops!
Roland Häder [Thu, 23 Jun 2022 02:58:16 +0000 (04:58 +0200)]
So simple ... Ops!

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 02:23:22 +0000 (04:23 +0200)]
Changes:
- enabled sub-directories for compiled/cached files which avoids large+slow
  directory descriptors
- changed some double-quotes to single

2 years agoMerge pull request #11674 from nupplaphil/dep/guzzle
Hypolite Petovan [Wed, 22 Jun 2022 19:07:42 +0000 (15:07 -0400)]
Merge pull request #11674 from nupplaphil/dep/guzzle

Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8

2 years agoMerge pull request #9 from nupplaphil/dependabot/composer/guzzlehttp/guzzle-6.5.8
Philipp [Wed, 22 Jun 2022 18:23:38 +0000 (20:23 +0200)]
Merge pull request #9 from nupplaphil/dependabot/composer/guzzlehttp/guzzle-6.5.8

Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8

2 years agoMerge pull request #11673 from Quix0r/bugs/returned-type-array-bool
Hypolite Petovan [Wed, 22 Jun 2022 17:29:39 +0000 (13:29 -0400)]
Merge pull request #11673 from Quix0r/bugs/returned-type-array-bool

Fixed: ?? didn't work here as bool won't be seen as null

2 years agoChanged:
Roland Häder [Wed, 22 Jun 2022 16:56:08 +0000 (18:56 +0200)]
Changed:
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"

2 years agoConverted multiple single-comment (//) to multi-line comment block (/* */)
Roland Häder [Wed, 22 Jun 2022 16:06:04 +0000 (18:06 +0200)]
Converted multiple single-comment (//) to multi-line comment block (/* */)

2 years agoImages::getInfoFromURL[Cached]() will both return empty arrays on error and
Roland Häder [Wed, 22 Jun 2022 15:18:39 +0000 (17:18 +0200)]
Images::getInfoFromURL[Cached]() will both return empty arrays on error and
that needs to be reflected here, too.

2 years agoFixed: ?? didn't work here as bool won't be seen as null
Roland Häder [Wed, 22 Jun 2022 15:09:20 +0000 (17:09 +0200)]
Fixed: ?? didn't work here as bool won't be seen as null

2 years agoMerge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode
Philipp [Wed, 22 Jun 2022 14:51:23 +0000 (16:51 +0200)]
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode

2 years agoMerge pull request #11670 from Quix0r/fixes/more-type-hints-004
Hypolite Petovan [Wed, 22 Jun 2022 14:49:20 +0000 (10:49 -0400)]
Merge pull request #11670 from Quix0r/fixes/more-type-hints-004

Fixes/more type hints 004

2 years agoFixed:
Roland Häder [Wed, 22 Jun 2022 14:19:45 +0000 (16:19 +0200)]
Fixed:
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
  type string, null given, called in src/Util/XML.php line 171

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 14:13:46 +0000 (16:13 +0200)]
Changes:
- added some documentation
- fixed some documentation
- changed more double-quotes to singl

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 10:43:56 +0000 (12:43 +0200)]
Changes:
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 10:01:42 +0000 (12:01 +0200)]
Changes:
- added more type-hints
- added some documentation

2 years agoReturn empty array on error (I hope it works this way).
Roland Häder [Wed, 22 Jun 2022 09:49:54 +0000 (11:49 +0200)]
Return empty array on error (I hope it works this way).

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 09:44:56 +0000 (11:44 +0200)]
Changes:
- added more type-hints
- updated documentation
- changed double-quotes to single

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 09:35:15 +0000 (11:35 +0200)]
Changes:
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single

2 years ago$data can turn into bool here
Roland Häder [Wed, 22 Jun 2022 04:03:37 +0000 (06:03 +0200)]
$data can turn into bool here

2 years agoOps, forgot to rename these, too.
Roland Häder [Wed, 22 Jun 2022 03:54:25 +0000 (05:54 +0200)]
Ops, forgot to rename these, too.

2 years agoChanges
Roland Häder [Wed, 22 Jun 2022 03:44:57 +0000 (05:44 +0200)]
Changes
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 03:03:30 +0000 (05:03 +0200)]
Changes:
- added type-hints
- added documentation

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 21:34:14 +0000 (23:34 +0200)]
Changes:
- added more type-hints
- added missing documentation

2 years agoMerge pull request #11671 from MrPetovan/bug/fatal-errors
Tobias Diekershoff [Wed, 22 Jun 2022 12:30:39 +0000 (14:30 +0200)]
Merge pull request #11671 from MrPetovan/bug/fatal-errors

Add expected type-hint to BoundariesPager::renderFull

2 years agoAdd expected type-hint to BoundariesPager::renderFull
Hypolite Petovan [Wed, 22 Jun 2022 11:49:45 +0000 (07:49 -0400)]
Add expected type-hint to BoundariesPager::renderFull

- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199

2 years agoRemove type-hint inconsistent with expected return value in Database->getVariable
Hypolite Petovan [Wed, 22 Jun 2022 11:47:15 +0000 (07:47 -0400)]
Remove type-hint inconsistent with expected return value in Database->getVariable

2 years agoRemove email subject encoding from ItemCCEmail constructor
Hypolite Petovan [Wed, 22 Jun 2022 01:12:09 +0000 (21:12 -0400)]
Remove email subject encoding from ItemCCEmail constructor

- It was wrongly re-encoded in Emailer::send

2 years agoMerge pull request #11668 from Quix0r/renames/logger
Hypolite Petovan [Wed, 22 Jun 2022 00:52:19 +0000 (20:52 -0400)]
Merge pull request #11668 from Quix0r/renames/logger

Renamings in logger class to make them more clear

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 23:49:35 +0000 (01:49 +0200)]
Changes:
- renamed Logger::getLogger() to getInstance() (@MrPetovan)

2 years agoBump guzzlehttp/guzzle from 6.5.5 to 6.5.8
dependabot[bot] [Tue, 21 Jun 2022 20:47:00 +0000 (20:47 +0000)]
Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8

Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.5 to 6.5.8.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.8/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.5...6.5.8)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 16:40:26 +0000 (18:40 +0200)]
Changes:
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
  returned but the actual (inner) logger

2 years agoMerge pull request #11665 from Quix0r/rewrites/dba-array-string-table
Hypolite Petovan [Tue, 21 Jun 2022 19:15:57 +0000 (15:15 -0400)]
Merge pull request #11665 from Quix0r/rewrites/dba-array-string-table

Rewrites/dba array string table

2 years agoAdded important comment from @nupplaphil@github.com
Roland Häder [Tue, 21 Jun 2022 19:12:43 +0000 (21:12 +0200)]
Added important comment from @nupplaphil@github.com

2 years agoReverted and improved TODO:
Roland Häder [Tue, 21 Jun 2022 17:19:11 +0000 (19:19 +0200)]
Reverted and improved TODO:
------
@nupplaphil: There is no easy possibility to add a logger here, that's why there
isn't any yet and instead a placeholder.. This execution point is a critical
state during a testrun, and tbh I'd like to leave here no further logic (yet)
because I spent hours debugging cases, where transactions weren't fully closed
and strange/unpredictable errors occur (sometimes -mainly during debugging other
errors :) ...)
-----

2 years agoFixed documentation
Roland Häder [Tue, 21 Jun 2022 16:42:51 +0000 (18:42 +0200)]
Fixed documentation

2 years agoRewrote to suggestions from @MrPetovan (I tried to maintain the old way of
Roland Häder [Tue, 21 Jun 2022 16:11:59 +0000 (18:11 +0200)]
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of
['scheme' => 'table'] with my version).

2 years agoUse protected $this->logger instead
Roland Häder [Tue, 21 Jun 2022 15:54:23 +0000 (17:54 +0200)]
Use protected $this->logger instead

2 years agoOps, autorun.sh is there but looks like lesser "multi-project" friendly as
Roland Häder [Tue, 21 Jun 2022 15:47:11 +0000 (17:47 +0200)]
Ops, autorun.sh is there but looks like lesser "multi-project" friendly as
MYSQL_* must be defined. I might still use my version as that is
project-specific.

2 years agoOps, WWORD ...
Roland Häder [Tue, 21 Jun 2022 11:53:30 +0000 (13:53 +0200)]
Ops, WWORD ...

2 years agoAdded simple wrapper script to run PHPUnit tests for you. To use this, you need
Roland Häder [Tue, 21 Jun 2022 11:45:13 +0000 (13:45 +0200)]
Added simple wrapper script to run PHPUnit tests for you. To use this, you need
to set at least 4 variables in your ~/.bashrc (recommended):

export FRIENDICA_MYSQL_HOST="localhost"
export FRIENDICA_MYSQL_DATABASE="friendica_test"
export FRIENDICA_MYSQL_USER="friendica_test"
export FRIENDICA_MYSQL_PASSWWORD="friendica_test"

Then you can put ./bin/dev/run_tests.sh into your .git/hooks/pre-commit file

2 years agoFixed:
Roland Häder [Tue, 21 Jun 2022 11:32:04 +0000 (13:32 +0200)]
Fixed:
- PHPUnit\Framework\Error\Notice:  Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 11:21:33 +0000 (13:21 +0200)]
Changes:
- let's at least log the error message, yes it does flood your logfile

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 11:04:05 +0000 (13:04 +0200)]
Changes:
- Database->$driver can no longer be NULL, an empty string is fine anyway

2 years agoFixed:
Roland Häder [Tue, 21 Jun 2022 10:43:24 +0000 (12:43 +0200)]
Fixed:
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
  can be found in it

2 years agoWIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?
Roland Häder [Tue, 21 Jun 2022 10:09:51 +0000 (12:09 +0200)]
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?

2 years agoRewrite:
Roland Häder [Tue, 21 Jun 2022 09:44:23 +0000 (11:44 +0200)]
Rewrite:
- avoid having array|string for $table to have a "string" type-hint for $table
- you now have to do it for yourself by giving 'schema.table' as parameter

2 years agoRemoved comment
Roland Häder [Tue, 21 Jun 2022 09:10:11 +0000 (11:10 +0200)]
Removed comment

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 01:10:02 +0000 (03:10 +0200)]
Changes:
- added type-hints
- added some missing documentation

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 00:30:09 +0000 (02:30 +0200)]
Changes:
- added more type-hints

2 years agoFixed:
Roland Häder [Thu, 16 Jun 2022 17:31:50 +0000 (19:31 +0200)]
Fixed:
- Uncaught Exception TypeError: "Argument 3 passed to
  Friendica\Protocol\DFRN::createActivity() must be of the type string, null
  given, called ..."

2 years agoMerge pull request #11664 from tobiasd/20220621-fr
Hypolite Petovan [Tue, 21 Jun 2022 11:43:12 +0000 (07:43 -0400)]
Merge pull request #11664 from tobiasd/20220621-fr

update FR translations THX kalon33

2 years agoMerge pull request #11662 from MrPetovan/bug/11661-splitattachment-null
Tobias Diekershoff [Tue, 21 Jun 2022 04:48:52 +0000 (06:48 +0200)]
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null

Ensure parameter 4 of Post\Media::splitAttachment is a boolean value

2 years agoupdate FR translations THX kalon33
Tobias Diekershoff [Tue, 21 Jun 2022 04:45:14 +0000 (06:45 +0200)]
update FR translations THX kalon33

2 years agoMerge pull request #11660 from Quix0r/fixes/more-type-hints-003
Hypolite Petovan [Tue, 21 Jun 2022 01:53:17 +0000 (21:53 -0400)]
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003

More type-hints - Batch 003

2 years agoFixed:
Roland Häder [Mon, 20 Jun 2022 23:41:34 +0000 (01:41 +0200)]
Fixed:
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method

2 years agoFixed indenting
Roland Häder [Mon, 20 Jun 2022 23:29:20 +0000 (01:29 +0200)]
Fixed indenting

2 years agoMerge pull request #11663 from Quix0r/composer/upgrade
Hypolite Petovan [Mon, 20 Jun 2022 23:17:13 +0000 (19:17 -0400)]
Merge pull request #11663 from Quix0r/composer/upgrade

Updated composer.phar

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 21:49:29 +0000 (23:49 +0200)]
Changes:
- added type-hints
- added some documentation
- marked some generic methods to be moved to Util\Strings class instead

2 years agoUpdated composer.phar
Roland Häder [Mon, 20 Jun 2022 20:54:45 +0000 (22:54 +0200)]
Updated composer.phar

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 19:21:32 +0000 (21:21 +0200)]
Changes:
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation

2 years agoAdded documentation
Roland Häder [Mon, 20 Jun 2022 19:02:18 +0000 (21:02 +0200)]
Added documentation

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 18:59:08 +0000 (20:59 +0200)]
Changes:
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean

2 years agoEnsure parameter 4 of Post\Media::splitAttachment is a boolean value
Hypolite Petovan [Mon, 20 Jun 2022 18:34:02 +0000 (14:34 -0400)]
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 18:01:25 +0000 (20:01 +0200)]
Changes:
- null was 2nd argument's value before, an empty string is basically the same here

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 17:08:23 +0000 (19:08 +0200)]
Changes:
- let's start throwing exceptions on e.g. invalid arguments instead of returning
  FALSE

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 17:04:01 +0000 (19:04 +0200)]
Changes:
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 16:55:17 +0000 (18:55 +0200)]
Changes:
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
  /var/www/.../src/Model/GServer.php on line 940" error

2 years agoFixes:
Roland Häder [Mon, 20 Jun 2022 06:25:17 +0000 (08:25 +0200)]
Fixes:
- Strings::isHex() should not be misused for checking on NULL

2 years agoChanged:
Roland Häder [Mon, 20 Jun 2022 06:18:53 +0000 (08:18 +0200)]
Changed:
- DBA::exists() should only be used for checking if records exists.
- if you want to check if a table exists, please ALWAYS use
  DBStructure::existsTable() instead

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 06:12:09 +0000 (08:12 +0200)]
Changes:
- some methods now need to return bool to be compatible
- added some missing type-hints

2 years agoBoth declarations must be the same
Roland Häder [Mon, 20 Jun 2022 06:06:45 +0000 (08:06 +0200)]
Both declarations must be the same

2 years agoMerge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier
Tobias Diekershoff [Mon, 20 Jun 2022 04:26:33 +0000 (06:26 +0200)]
Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier

Add missing identifier quote in Database->replaceInTableFields

2 years agoChanged:
Roland Häder [Mon, 20 Jun 2022 01:48:12 +0000 (03:48 +0200)]
Changed:
- cannot have type-hints :-(

2 years agoOps, wrong type-hint
Roland Häder [Mon, 20 Jun 2022 01:36:13 +0000 (03:36 +0200)]
Ops, wrong type-hint

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 01:10:02 +0000 (03:10 +0200)]
Changes:
- added type-hints
- added some missing documentation

2 years agoChanges:
Roland Häder [Mon, 20 Jun 2022 00:45:53 +0000 (02:45 +0200)]
Changes:
- added some documentation
- added type-hints

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 23:08:52 +0000 (01:08 +0200)]
Changes:
- added type-hints
- added missing documentation

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 22:51:59 +0000 (00:51 +0200)]
Changes:
- added more type-hints

2 years agoMerge pull request #11657 from Quix0r/fixes/post-media-size-bigint
Hypolite Petovan [Mon, 20 Jun 2022 00:23:29 +0000 (20:23 -0400)]
Merge pull request #11657 from Quix0r/fixes/post-media-size-bigint

Size "mediumint" wasn't enough

2 years agoAdd missing identifier quote in Database->replaceInTableFields
Hypolite Petovan [Mon, 20 Jun 2022 00:06:12 +0000 (20:06 -0400)]
Add missing identifier quote in Database->replaceInTableFields

- This caused hyphenated table names to fail the replace query

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 22:58:52 +0000 (00:58 +0200)]
Changes:
- added type-hints
- changed some double-quotes to single

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 21:06:04 +0000 (23:06 +0200)]
Changes:
 - `url` to `varbinary(1024)`
 - `preview` to `varbinary(512)`

as the previous once (half length) were not enough in real-life scenarios

2 years agoIncremented again
Roland Häder [Sun, 19 Jun 2022 13:32:14 +0000 (15:32 +0200)]
Incremented again

2 years agoFixed documentation/SQL dump with ./bin/console dbstructure dump
Roland Häder [Sun, 19 Jun 2022 07:10:36 +0000 (09:10 +0200)]
Fixed documentation/SQL dump with ./bin/console dbstructure dump

2 years agoSize "mediumint" wasn't enough:
Roland Häder [Sun, 19 Jun 2022 00:31:59 +0000 (02:31 +0200)]
Size "mediumint" wasn't enough:
https://digitalcourage.video/static/webseed/5a039eb2-9fbc-441d-a772-59ae3ee65c15-1080.mp4 has 6758472669 Bytes

So let's go REALLY big.

2 years agoMerge pull request #11655 from Quix0r/fixes/more-type-hints-002
Hypolite Petovan [Sun, 19 Jun 2022 13:27:29 +0000 (09:27 -0400)]
Merge pull request #11655 from Quix0r/fixes/more-type-hints-002

More type-hints and documentation added

2 years agoIncremented database version
Roland Häder [Sun, 19 Jun 2022 12:41:04 +0000 (14:41 +0200)]
Incremented database version

2 years agoOps, not here wanted. :-(
Roland Häder [Sun, 19 Jun 2022 12:06:20 +0000 (14:06 +0200)]
Ops, not here wanted. :-(

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 11:59:58 +0000 (13:59 +0200)]
Changes:
- added type-hints
- added returned type-hints in interface (I checked all)

2 years agoMerge pull request #11658 from tobiasd/20220619-accesskey
Hypolite Petovan [Sun, 19 Jun 2022 11:09:20 +0000 (07:09 -0400)]
Merge pull request #11658 from tobiasd/20220619-accesskey

Accesskey was used twice

2 years agoSome calls saved
Roland Häder [Sun, 19 Jun 2022 09:25:52 +0000 (11:25 +0200)]
Some calls saved

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 08:49:26 +0000 (10:49 +0200)]
Changes:
- added missing type-hints
- added documentation for a method

2 years agoChanges:
Roland Häder [Sun, 19 Jun 2022 08:48:47 +0000 (10:48 +0200)]
Changes:
- MySQL index on BLOB/TEXT can only be partial (e.g.: `column`(length))

2 years agoContact::getAccountType()'s parameter is never a string, ops
Roland Häder [Sun, 19 Jun 2022 07:35:53 +0000 (09:35 +0200)]
Contact::getAccountType()'s parameter is never a string, ops