Roland Häder [Sat, 21 Jan 2023 09:02:55 +0000 (10:02 +0100)]
Please cherry-pick:
- "validate" parameter, e.g. where you don't want null references, then check if
it is null to prevent possible logic errors and maybe here a wrong/misleading
result
Roland Häder [Sat, 12 Nov 2022 20:31:18 +0000 (21:31 +0100)]
Please cherry-pick:
- removed star-import and it isn't needed anymore
- still this interface should be used as a type alongside with `@Inject`
annotations
Roland Häder [Sat, 5 Nov 2022 04:39:57 +0000 (05:39 +0100)]
Please cherry-pick:
- updated to latest changes in constructor (order of parameters)
- also used newly added constructor with all optional class fields, except
contactId, fax/land-line/mobile number and created/updated fields
Roland Häder [Sun, 23 Oct 2022 21:13:02 +0000 (23:13 +0200)]
Please cherry-pick:
- I don't know what maximum number is possible, e.g. +352 is Luxembourg which is
far bigger than intended maximum 99. So let's put it up to 999
Roland Häder [Thu, 20 Oct 2022 17:17:46 +0000 (19:17 +0200)]
Please cherry-pick:
- added missing parameter "country" for updated constructor
- also validated if contact's Country instance is set and already persisted
Roland Häder [Thu, 20 Oct 2022 16:42:21 +0000 (18:42 +0200)]
Please cherry-pick:
- renamed copyUser() to copyToUser() because that method "copies" (read: sets)
all required class fields except "entry-created" in given user instance
- also used UserContact's parameterized constructor instead of default one and
then setting all on my own
- removed @PostConstruct method
Roland Häder [Sun, 2 Oct 2022 17:42:56 +0000 (19:42 +0200)]
Please cherry-pick:
- these checks on if registered or not or provided or not makes here no sense
and has caused forms not accepting email addresses
- renamed template
- added country Hungary
Roland Häder [Wed, 28 Sep 2022 17:10:11 +0000 (19:10 +0200)]
Product-only:
- introduced validator JSF tags for product and category
- edit views must bypass duplicate i18n key check
- ops, had to rename wrongly named template
Roland Häder [Sun, 25 Sep 2022 20:36:04 +0000 (22:36 +0200)]
Please cherry-pick:
- branch offices have optional email addresses (finally found the bug that you
always must enter an email address while the form field is not marked as
required)
Roland Häder [Sun, 25 Sep 2022 20:21:32 +0000 (22:21 +0200)]
Please cherry-pick:
- removed duplicate validator for branch office's email address
- validators should check specific fields, not generic
- arranged code a bit for better readability
- renamed private method
Roland Häder [Fri, 23 Sep 2022 16:52:47 +0000 (18:52 +0200)]
Please cherry-pick:
- cannot copy whole user instance to RequestScoped bean as this is being
forgotten on next request, SessionScoped will be a little overdose + it can
be solved by taking the user instance already set in beanHelper bean
Roland Häder [Thu, 15 Sep 2022 05:11:31 +0000 (07:11 +0200)]
Don't cherry-pick:
- moved i18n BARCODE_NUMBER_HEADER to project file
- also renamed it to BARCODE_HEADER as the actual bar code is being rendered
- added missing i18n strings
Roland Häder [Mon, 1 Jun 2020 13:37:44 +0000 (15:37 +0200)]
Don't cherry-pick:
- renderReceipt() does now require a second parameter showReceiptPaymentType
which can be used to include or exclude the payment type in views. For all
selection boxes, this feature has been disabled (in views) or else the
selection box becomes very wide
Roland Häder [Mon, 1 Jun 2020 13:35:31 +0000 (15:35 +0200)]
Product-only:
- show tax rate to user and format the number as a float when entered
- renamed NO_PRODUCT_NUMBER_ASSIGNED to ADMIN_NO_PRODUCT_NUMBER_ASSIGNED
- added missing i18n key for the case when no FSC number is entered
Roland Häder [Mon, 1 Jun 2020 13:32:24 +0000 (15:32 +0200)]
Please cherry-pick:
- all extra email address validators (so not the generic one) have no attribute
"allowEmptyRequiredData" anymore as the email address for them (e.g. branch
office) is always optional
- converted own JSF tag core:outputAdminContactDataFormFields to template again
- reformatted some JSF tags to have each attribute in a single line
- the gender-specific backing bean was superflous since there is a "static
data" backing bean
- added missing i18n string COUNTRY_POLAND (country was added in JFinancials)
- fixed tpzo in i18n key
Roland Häder [Wed, 20 May 2020 17:51:29 +0000 (19:51 +0200)]
Product-only:
- renamed adminCategoryController to adminProductCategoryController
- added column with filter for categoryShownInStatistics flag
- added missing i18n key
Roland Häder [Wed, 20 May 2020 16:42:59 +0000 (18:42 +0200)]
Please cherry-pick:
- renamed userCreated -> userEntryCreated
- renamed userUpdated -> userEntryUpdated
- updateUserData() may throw a checked UserNotFoundException, let's catch it
here and throw a FacesException with it as cause
- same with confirmAccount()
Roland Häder [Mon, 11 May 2020 01:12:04 +0000 (03:12 +0200)]
Please cherry-pick:
- since departments, headquarters and branch offices cannot link to employes,
so also the view navigation rules must reflect this. Employees can have a
relationship to any these 3 entities and would lead to endless loop
- introduced adminDepartmentActionController instead of without "Action", let
us keep these empty ("dead") backing beans around, they may one day be filled
with life again. Or they will be removed if no purpose could be found.
- closed some TODOs in views where p:fieldset allows a title attribute
- also a ui:fragment can be avoided when p:fieldset allows a render attribute
- added view for administrative editing of departments
- removed double // NOI18N strings (ops?) which is for some language string
scanning and translation tools to ignore these lines (exception messages
should normally not show up to the user).
Roland Häder [Thu, 30 Apr 2020 21:41:37 +0000 (23:41 +0200)]
Don't cherry-pick:
- renamed class field financialBean to financialIncomeBean as this reflects
the real purpose of the EJB.
- exposed incomeEnabled flag in admin-add-income form
- removed some needless tags as it can be done easier in PrimeFaces
- added missing i18n strings
projects / jfinancials-war.git / log