]> git.mxchange.org Git - friendica.git/log
friendica.git
6 years agoAccording to @annando and @MrPetovan, $emailcc is no `item` field (column) and (...
Roland Häder [Wed, 18 Jul 2018 21:26:14 +0000 (23:26 +0200)]
According to @annando and @MrPetovan, $emailcc is no `item` field (column) and (#5401)

should be initialized empty (I did it above the `if()` block).

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFix tests (#5400)
Pierre Rudloff [Wed, 18 Jul 2018 20:30:55 +0000 (22:30 +0200)]
Fix tests (#5400)

* Avoid argc side-effects

* Fix undefined array keys in JITConfigAdapter::set()

* Avoid argv side effects in ApiTest

6 years agoPrettified the parameter layout of workerqueue (#5397)
Jeroen De Meerleer [Wed, 18 Jul 2018 20:24:35 +0000 (22:24 +0200)]
Prettified the parameter layout of workerqueue (#5397)

* Prettified the parameter layout of workerqueue

* Updated to code standards :)

* Where did I go wrong?

6 years agoFixed E_NOTICE when no 'term' was provided (#5391)
Roland Häder [Wed, 18 Jul 2018 19:41:24 +0000 (21:41 +0200)]
Fixed E_NOTICE when no 'term' was provided (#5391)

* Fixed E_NOTICE when no 'term' was provided, maybe better encapsulate this whole
$_GET, $_POST and $_SESSION thing into a `Request` class?

Signed-off-by: Roland Häder <roland@mxchange.org>
* Rewrote to recommendation by @MrPetovan which results in really nicer code.

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFix silent exit in ApiTest::testApiMediaUploadWithMedia() (#5398)
Pierre Rudloff [Wed, 18 Jul 2018 19:36:51 +0000 (21:36 +0200)]
Fix silent exit in ApiTest::testApiMediaUploadWithMedia() (#5398)

6 years agoswitch the Vagrant VM to the new config system (#5396)
Tobias Diekershoff [Wed, 18 Jul 2018 19:32:24 +0000 (21:32 +0200)]
switch the Vagrant VM to the new config system (#5396)

6 years agosimplifying unittests (#5395)
Philipp [Wed, 18 Jul 2018 19:04:18 +0000 (21:04 +0200)]
simplifying unittests (#5395)

* simplifying unittests

- use @requires instead class_exist
- define @small and @medium

* simplifying unittests

- removed unnecessary throwings

6 years agoMerge pull request #5394 from MrPetovan/bug/fix-config-set-return-value
Michael Vogel [Wed, 18 Jul 2018 09:07:10 +0000 (11:07 +0200)]
Merge pull request #5394 from MrPetovan/bug/fix-config-set-return-value

Change (P)Config::set return value to bool

6 years agoMerge pull request #5295 from MrPetovan/task/4889-move-config-to-config
Michael Vogel [Wed, 18 Jul 2018 09:04:35 +0000 (11:04 +0200)]
Merge pull request #5295 from MrPetovan/task/4889-move-config-to-config

Move configuration to config/

6 years agoChange (P)Config::set return value to bool
Hypolite Petovan [Wed, 18 Jul 2018 06:32:35 +0000 (02:32 -0400)]
Change (P)Config::set return value to bool

6 years agoFix notice in Util\Network
Hypolite Petovan [Wed, 18 Jul 2018 01:00:22 +0000 (21:00 -0400)]
Fix notice in Util\Network

6 years agoFixes for E_NOTICE in mod/item.php (#5393)
Roland Häder [Tue, 17 Jul 2018 22:18:42 +0000 (00:18 +0200)]
Fixes for E_NOTICE in mod/item.php (#5393)

* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
  the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes E_NOTICE of missing variable (PHP's lazyness again).

Signed-off-by: Roland Häder <roland@mxchange.org>
* Use !empty() to avoid accessing empty array.

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoFixes for OEmbed class (#5392)
Roland Häder [Tue, 17 Jul 2018 20:28:20 +0000 (22:28 +0200)]
Fixes for OEmbed class (#5392)

* Fixes:
- stdClass is clearly an object of `\stdClass`, so let's import it and set it
  as type-hint here
- if $o->type is not found, don't continue

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fix for a fix due to 02:51 a.m. (!) edits ...

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoImprove Console/Config display for array values
Hypolite Petovan [Tue, 17 Jul 2018 06:15:05 +0000 (02:15 -0400)]
Improve Console/Config display for array values

- Prevent setting a config key that is an array

6 years agoAdd support for legacy $lang config in App->loadConfig
Hypolite Petovan [Tue, 17 Jul 2018 06:05:52 +0000 (02:05 -0400)]
Add support for legacy $lang config in App->loadConfig

6 years agoRemove exception for legacy config file in App->loadDatabase
Hypolite Petovan [Tue, 17 Jul 2018 06:05:36 +0000 (02:05 -0400)]
Remove exception for legacy config file in App->loadDatabase

6 years agoFix config value type in MemcachedCacheDriver
Hypolite Petovan [Tue, 17 Jul 2018 06:05:06 +0000 (02:05 -0400)]
Fix config value type in MemcachedCacheDriver

- Remove default config values set in CacheDriverFactory

6 years agoImprove help/Config page
Hypolite Petovan [Tue, 17 Jul 2018 06:03:39 +0000 (02:03 -0400)]
Improve help/Config page

- Remove obsolete file-only config list
- Fix heading level
- Add transition instruction for $lang
- Add reference to config.ini.php, settings.ini.php and addon.ini.php
- Add link to help page in admin warning about legacy config file

6 years agoFixed E_NOTICE when 'title' is absent (uninitialized array key) (#5390)
Roland Häder [Tue, 17 Jul 2018 05:13:22 +0000 (07:13 +0200)]
Fixed E_NOTICE when 'title' is absent (uninitialized array key) (#5390)

Signed-off-by: Roland Häder <roland@mxchange.org>
6 years agoSeparate default config values between file-only and admin settings
Hypolite Petovan [Mon, 16 Jul 2018 23:07:46 +0000 (19:07 -0400)]
Separate default config values between file-only and admin settings

6 years agoEnforce systen.register_policy value type
Hypolite Petovan [Sun, 15 Jul 2018 19:04:48 +0000 (15:04 -0400)]
Enforce systen.register_policy value type

6 years agoCode standards in App
Hypolite Petovan [Sun, 15 Jul 2018 16:44:32 +0000 (12:44 -0400)]
Code standards in App

6 years agoFix typo in mod/admin
Hypolite Petovan [Sun, 15 Jul 2018 16:44:19 +0000 (12:44 -0400)]
Fix typo in mod/admin

6 years agoRemove remaining references to Config::get in include/dba
Hypolite Petovan [Sun, 15 Jul 2018 16:44:10 +0000 (12:44 -0400)]
Remove remaining references to Config::get in include/dba

6 years agoImprove console/config display
Hypolite Petovan [Thu, 12 Jul 2018 03:00:44 +0000 (23:00 -0400)]
Improve console/config display

- Add visual distinction between get/set value

6 years agoFix undefined index in mod/settings
Hypolite Petovan [Thu, 12 Jul 2018 02:58:52 +0000 (22:58 -0400)]
Fix undefined index in mod/settings

6 years agoMove the addon-specific config in config/addon.ini.php
Hypolite Petovan [Thu, 12 Jul 2018 02:58:37 +0000 (22:58 -0400)]
Move the addon-specific config in config/addon.ini.php

- Add sample addon.ini.php file
- Add config/addon.ini.php file to git ignore

6 years agoFix missing use in mod/ping
Hypolite Petovan [Thu, 12 Jul 2018 02:41:52 +0000 (22:41 -0400)]
Fix missing use in mod/ping

6 years agoFix segfault in PHP 5.6 parsing INI strings
Hypolite Petovan [Thu, 12 Jul 2018 02:24:52 +0000 (22:24 -0400)]
Fix segfault in PHP 5.6 parsing INI strings

- add documentation to generated local.ini.php file

6 years agoFix JITConfigAdapter to retrieve non-db config.* values
Hypolite Petovan [Thu, 12 Jul 2018 02:24:20 +0000 (22:24 -0400)]
Fix JITConfigAdapter to retrieve non-db config.* values

6 years agoFix urlpath determination on the root page
Hypolite Petovan [Thu, 12 Jul 2018 02:23:57 +0000 (22:23 -0400)]
Fix urlpath determination on the root page

6 years agoFix undefined index notice messages in mod/install
Hypolite Petovan [Thu, 12 Jul 2018 02:23:35 +0000 (22:23 -0400)]
Fix undefined index notice messages in mod/install

6 years agoRemove global $db variable
Hypolite Petovan [Tue, 10 Jul 2018 02:40:10 +0000 (22:40 -0400)]
Remove global $db variable

6 years agoReplace global $a with BaseObject::getApp()
Hypolite Petovan [Tue, 10 Jul 2018 02:39:59 +0000 (22:39 -0400)]
Replace global $a with BaseObject::getApp()

6 years agoReplace global $lang with system.language
Hypolite Petovan [Tue, 10 Jul 2018 02:37:51 +0000 (22:37 -0400)]
Replace global $lang with system.language

6 years agoRemove deprecated functions in include/text
Hypolite Petovan [Tue, 10 Jul 2018 02:11:39 +0000 (22:11 -0400)]
Remove deprecated functions in include/text

6 years agoFix formatting in mod/help
Hypolite Petovan [Tue, 10 Jul 2018 01:53:19 +0000 (21:53 -0400)]
Fix formatting in mod/help

6 years agoChasing a segfault in PHP 5.6 tests
Hypolite Petovan [Mon, 9 Jul 2018 13:22:01 +0000 (09:22 -0400)]
Chasing a segfault in PHP 5.6 tests

6 years agoRemove api test pconfig debug
Hypolite Petovan [Sun, 8 Jul 2018 07:28:29 +0000 (03:28 -0400)]
Remove api test pconfig debug

6 years agoFix wrong mode for App since local conf file wasn't present
Hypolite Petovan [Sun, 8 Jul 2018 07:16:38 +0000 (03:16 -0400)]
Fix wrong mode for App since local conf file wasn't present

6 years agoFix debug
Hypolite Petovan [Sun, 8 Jul 2018 07:16:20 +0000 (03:16 -0400)]
Fix debug

6 years agoAdd yet more pconfig debug to testApiGetUserWithCustomFrioSchema
Hypolite Petovan [Sun, 8 Jul 2018 07:07:38 +0000 (03:07 -0400)]
Add yet more pconfig debug to testApiGetUserWithCustomFrioSchema

6 years agoWrong table name
Hypolite Petovan [Sun, 8 Jul 2018 06:57:00 +0000 (02:57 -0400)]
Wrong table name

6 years agoAdd more api test debug
Hypolite Petovan [Sun, 8 Jul 2018 06:49:12 +0000 (02:49 -0400)]
Add more api test debug

6 years agoAdd api test debug
Hypolite Petovan [Sun, 8 Jul 2018 06:32:51 +0000 (02:32 -0400)]
Add api test debug

6 years agoPut base test config in Yaml dataset
Hypolite Petovan [Sun, 8 Jul 2018 05:59:52 +0000 (01:59 -0400)]
Put base test config in Yaml dataset

6 years agoFix Memached config value format usage
Hypolite Petovan [Sun, 8 Jul 2018 05:46:46 +0000 (01:46 -0400)]
Fix Memached config value format usage

6 years agoSet system.hostname in test bootstrap
Hypolite Petovan [Sun, 8 Jul 2018 05:46:22 +0000 (01:46 -0400)]
Set system.hostname in test bootstrap

6 years agoMove meaningful message inside Exception thrown in Cache tests
Hypolite Petovan [Sun, 8 Jul 2018 05:46:06 +0000 (01:46 -0400)]
Move meaningful message inside Exception thrown in Cache tests

6 years agoRevert using Config class in dba
Hypolite Petovan [Sun, 8 Jul 2018 05:45:22 +0000 (01:45 -0400)]
Revert using Config class in dba

6 years agoRestore system.url declaration in tests
Hypolite Petovan [Sat, 7 Jul 2018 22:03:59 +0000 (18:03 -0400)]
Restore system.url declaration in tests

6 years agoRemove direct App instantiation from tests
Hypolite Petovan [Sat, 7 Jul 2018 22:03:45 +0000 (18:03 -0400)]
Remove direct App instantiation from tests

6 years agoFix uses in include/dba
Hypolite Petovan [Sat, 7 Jul 2018 21:55:06 +0000 (17:55 -0400)]
Fix uses in include/dba

6 years ago[tests] Prevent bin/worker.php from being called during tests
Hypolite Petovan [Sat, 7 Jul 2018 21:46:51 +0000 (17:46 -0400)]
[tests] Prevent bin/worker.php from being called during tests

6 years agoReplace direct accesses to App->config by Config::get/set calls
Hypolite Petovan [Sat, 7 Jul 2018 21:46:30 +0000 (17:46 -0400)]
Replace direct accesses to App->config by Config::get/set calls

6 years agoAdd missing default config keys
Hypolite Petovan [Sat, 7 Jul 2018 21:46:20 +0000 (17:46 -0400)]
Add missing default config keys

- Add config.admin_nickname
- Add config.info
- Add featurelock section

6 years agoFix dbesc as a constant notice message
Hypolite Petovan [Sat, 7 Jul 2018 20:31:03 +0000 (16:31 -0400)]
Fix dbesc as a constant notice message

6 years agoAdd optimize_max_tablesize to default config file
Hypolite Petovan [Sat, 7 Jul 2018 01:46:51 +0000 (21:46 -0400)]
Add optimize_max_tablesize to default config file

6 years agoMove forbidden_nicknames default to config file
Hypolite Petovan [Sat, 7 Jul 2018 01:46:35 +0000 (21:46 -0400)]
Move forbidden_nicknames default to config file

6 years agoFix set_baseurl() notice messages in worker during tests
Hypolite Petovan [Sat, 7 Jul 2018 01:39:24 +0000 (21:39 -0400)]
Fix set_baseurl() notice messages in worker during tests

6 years agoImprove comparison in App->loadDatabase()
Hypolite Petovan [Sat, 7 Jul 2018 01:24:40 +0000 (21:24 -0400)]
Improve comparison in App->loadDatabase()

6 years agoFix test bootstrap namespace issue
Hypolite Petovan [Sat, 7 Jul 2018 01:24:17 +0000 (21:24 -0400)]
Fix test bootstrap namespace issue

6 years agoInstantiate the App in test bootstrap
Hypolite Petovan [Sat, 7 Jul 2018 01:20:29 +0000 (21:20 -0400)]
Instantiate the App in test bootstrap

- Remove wrong App instantiation in Lock test

6 years agoRemove .htconfig.php reference from DatabaseTest
Hypolite Petovan [Sat, 7 Jul 2018 01:17:04 +0000 (21:17 -0400)]
Remove .htconfig.php reference from DatabaseTest

6 years agoUpdate use of environment variables in loadDatabase
Hypolite Petovan [Sat, 7 Jul 2018 01:08:48 +0000 (21:08 -0400)]
Update use of environment variables in loadDatabase

6 years agoAdd load_config hook doc
Hypolite Petovan [Sun, 1 Jul 2018 19:27:05 +0000 (15:27 -0400)]
Add load_config hook doc

6 years agoBump minimum PHP version to 5.6.1
Hypolite Petovan [Sun, 1 Jul 2018 19:15:17 +0000 (15:15 -0400)]
Bump minimum PHP version to 5.6.1

6 years agoFix Database connexion in tests
Hypolite Petovan [Sun, 1 Jul 2018 08:05:20 +0000 (04:05 -0400)]
Fix Database connexion in tests

6 years agoReplace system.proc_windows config by PHP_OS test
Hypolite Petovan [Sun, 1 Jul 2018 08:04:42 +0000 (04:04 -0400)]
Replace system.proc_windows config by PHP_OS test

6 years agoAdd system.groupedit_image_limit config key to defaults.ini.php
Hypolite Petovan [Sun, 1 Jul 2018 04:12:57 +0000 (00:12 -0400)]
Add system.groupedit_image_limit config key to defaults.ini.php

6 years agoRework App modes
Hypolite Petovan [Sat, 30 Jun 2018 18:40:09 +0000 (14:40 -0400)]
Rework App modes

- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code

6 years agoStandards: Rename App methods
Hypolite Petovan [Sat, 30 Jun 2018 18:07:01 +0000 (14:07 -0400)]
Standards: Rename App methods

- Rename App->max_processes_reached to App->isMaxProcessesReached
- Rename App->maxload_reached to App->isMaxLoadReached

6 years agoFix wrong urlpath determination
Hypolite Petovan [Sat, 30 Jun 2018 15:11:22 +0000 (11:11 -0400)]
Fix wrong urlpath determination

6 years agoUpdate config/defaults.ini.php
Hypolite Petovan [Fri, 29 Jun 2018 04:31:22 +0000 (00:31 -0400)]
Update config/defaults.ini.php

- Move sections around
- Update config.admin_email value type

6 years agoFix INSTALL
Hypolite Petovan [Fri, 29 Jun 2018 04:27:21 +0000 (00:27 -0400)]
Fix INSTALL

- Change config file permissions
- Remove leading slash of config/

6 years agoUpdate documentation
Hypolite Petovan [Fri, 29 Jun 2018 04:26:53 +0000 (00:26 -0400)]
Update documentation

- Add line breaks on periods
- Remove obsolete text

6 years agoRevert doc/Config title
Hypolite Petovan [Fri, 29 Jun 2018 04:26:00 +0000 (00:26 -0400)]
Revert doc/Config title

6 years agoReorganize .gitignore
Hypolite Petovan [Fri, 29 Jun 2018 04:25:43 +0000 (00:25 -0400)]
Reorganize .gitignore

- Delete duplicates
- Add leading slash to /doc/html
- Typo

6 years agoMove doc/htconfig.md to doc/Config.md
Hypolite Petovan [Thu, 28 Jun 2018 03:07:38 +0000 (23:07 -0400)]
Move doc/htconfig.md to doc/Config.md

- Updated all .htconfig.php references in other documentation pages
- Added migration part

6 years agoFix config mentions (no doc)
Hypolite Petovan [Thu, 28 Jun 2018 03:06:23 +0000 (23:06 -0400)]
Fix config mentions (no doc)

6 years agoAdd addon config hook
Hypolite Petovan [Thu, 28 Jun 2018 03:05:38 +0000 (23:05 -0400)]
Add addon config hook

6 years agoUpdated configuration files
Hypolite Petovan [Thu, 28 Jun 2018 03:05:01 +0000 (23:05 -0400)]
Updated configuration files

- Added system.account_abandon_days and system.addon to defaults.ini.php
- Fixed database section key names in local-sample.ini.php

6 years agoUpdate install procedure
Hypolite Petovan [Tue, 26 Jun 2018 01:00:58 +0000 (21:00 -0400)]
Update install procedure

- Fix Notice messages in Core\Install and Database\DBStructure
- Move local config file template from htconfig.tpl to local.ini.tpl
- Remove htconfig.php

6 years agoUpdate config console command
Hypolite Petovan [Tue, 26 Jun 2018 00:59:02 +0000 (20:59 -0400)]
Update config console command

6 years agoRemove stray include of .htconfig.php in index.php
Hypolite Petovan [Tue, 26 Jun 2018 00:58:33 +0000 (20:58 -0400)]
Remove stray include of .htconfig.php in index.php

6 years agoPrevent infinite loops with Config when App is in install mode
Hypolite Petovan [Tue, 26 Jun 2018 00:57:57 +0000 (20:57 -0400)]
Prevent infinite loops with Config when App is in install mode

6 years agoUpdate support for daemon pidfile config
Hypolite Petovan [Tue, 26 Jun 2018 00:56:35 +0000 (20:56 -0400)]
Update support for daemon pidfile config

6 years agoRemove extraneous dba::connect calls
Hypolite Petovan [Tue, 26 Jun 2018 00:56:07 +0000 (20:56 -0400)]
Remove extraneous dba::connect calls

6 years agoSet BaseObject::setApp in App
Hypolite Petovan [Tue, 26 Jun 2018 00:44:35 +0000 (20:44 -0400)]
Set BaseObject::setApp in App

6 years agoRename App->path to App->urlpath
Hypolite Petovan [Tue, 26 Jun 2018 00:39:56 +0000 (20:39 -0400)]
Rename App->path to App->urlpath

6 years agoCentralize startup steps in Friendica\App
Hypolite Petovan [Tue, 26 Jun 2018 00:38:41 +0000 (20:38 -0400)]
Centralize startup steps in Friendica\App

- Add loadDatabase startup step
- Add loadConfigFiles startup step
- Remove startup() in boot.php
- Replace App::checkMaintenanceMode() with App::determineMode()

6 years agoAdd new INI config files
Hypolite Petovan [Mon, 25 Jun 2018 00:26:00 +0000 (20:26 -0400)]
Add new INI config files

- Add new local.ini.tpl template
- Change all references from .htconfig.php to config/local.ini.php

6 years agoAdd config/local.ini.php to gitignore
Hypolite Petovan [Sun, 24 Jun 2018 18:02:57 +0000 (14:02 -0400)]
Add config/local.ini.php to gitignore

6 years agoRemove dependency to App in dba::connect
Hypolite Petovan [Sun, 24 Jun 2018 15:15:26 +0000 (11:15 -0400)]
Remove dependency to App in dba::connect

- Remove timing (can be done centrally)
- Add charset parameter to dba::connect and dba::reconnect

6 years agotypo correction of try_files directive (#5387)
rebeka-catalina [Mon, 16 Jul 2018 06:53:50 +0000 (08:53 +0200)]
typo correction of try_files directive (#5387)

6 years agoMerge pull request #5386 from annando/dfrn-unknown-owner
Tobias Diekershoff [Mon, 16 Jul 2018 06:50:55 +0000 (08:50 +0200)]
Merge pull request #5386 from annando/dfrn-unknown-owner

Don't accept posts from unknown owners

6 years agoEnsure that "follow" requests can be processed
Michael [Mon, 16 Jul 2018 06:34:12 +0000 (06:34 +0000)]
Ensure that "follow" requests can be processed

6 years agoDon't accept posts from unknown owners
Michael [Mon, 16 Jul 2018 05:48:51 +0000 (05:48 +0000)]
Don't accept posts from unknown owners

6 years agoMerge pull request #5384 from annando/item-uri
Tobias Diekershoff [Mon, 16 Jul 2018 04:45:41 +0000 (06:45 +0200)]
Merge pull request #5384 from annando/item-uri

Fix for missing username in uri for comments to public posts

6 years agoMerge pull request #5385 from annando/public-items
Tobias Diekershoff [Mon, 16 Jul 2018 04:44:50 +0000 (06:44 +0200)]
Merge pull request #5385 from annando/public-items

Fix for displaying public items