]> git.mxchange.org Git - friendica.git/log
friendica.git
2 years agoMerge pull request #11689 from Quix0r/rewrites/double-quotes-single
Hypolite Petovan [Sat, 25 Jun 2022 16:02:01 +0000 (12:02 -0400)]
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single

Changed more double-quotes to single

2 years agoMade @TODO more clear?
Roland Häder [Sat, 25 Jun 2022 15:58:27 +0000 (17:58 +0200)]
Made @TODO more clear?

2 years agoMerge pull request #11688 from MrPetovan/bug/11635-mod-photos-posted
Philipp [Sat, 25 Jun 2022 15:54:49 +0000 (17:54 +0200)]
Merge pull request #11688 from MrPetovan/bug/11635-mod-photos-posted

Replace obsolete posted sort field by created in mod\photos

2 years agoReplace obsolete posted sort field by created in mod\photos
Hypolite Petovan [Sat, 25 Jun 2022 10:17:56 +0000 (06:17 -0400)]
Replace obsolete posted sort field by created in mod\photos

2 years agoAdd tests for BBCode::fetchShareAttributes
Hypolite Petovan [Sat, 25 Jun 2022 15:46:12 +0000 (11:46 -0400)]
Add tests for BBCode::fetchShareAttributes

2 years agoCentralize share tag attribute extraction code in Content\Text\BBCode
Hypolite Petovan [Sat, 25 Jun 2022 10:15:26 +0000 (06:15 -0400)]
Centralize share tag attribute extraction code in Content\Text\BBCode

2 years agoChanges:
Roland Häder [Fri, 24 Jun 2022 04:27:38 +0000 (06:27 +0200)]
Changes:
- added type-hints
- added documentation

2 years agoChanges:
Roland Häder [Fri, 24 Jun 2022 03:47:53 +0000 (05:47 +0200)]
Changes:
- let's get rid of that `Database::exists()` is being misused for checking table existence
- reformatted array

2 years agoChanged double-quotes to single
Roland Häder [Fri, 24 Jun 2022 03:27:33 +0000 (05:27 +0200)]
Changed double-quotes to single

2 years agoChanges:
Roland Häder [Fri, 24 Jun 2022 02:42:35 +0000 (04:42 +0200)]
Changes:
- added some type-hints
- added documentation

2 years agoSpace for the rescue. ;-)
Roland Häder [Fri, 24 Jun 2022 01:44:52 +0000 (03:44 +0200)]
Space for the rescue. ;-)

2 years agoReformatted array
Roland Häder [Fri, 24 Jun 2022 01:24:51 +0000 (03:24 +0200)]
Reformatted array

2 years agoChanges:
Roland Häder [Fri, 24 Jun 2022 01:01:13 +0000 (03:01 +0200)]
Changes:
- added some type-hints
- changed some double-quotes to single

2 years agoChanged doubled-quotes to single
Roland Häder [Wed, 22 Jun 2022 23:46:37 +0000 (01:46 +0200)]
Changed doubled-quotes to single

2 years agoMerge pull request #11685 from MrPetovan/bug/11638-gserver_site_name-length
Michael Vogel [Sat, 25 Jun 2022 10:39:06 +0000 (12:39 +0200)]
Merge pull request #11685 from MrPetovan/bug/11638-gserver_site_name-length

Add explicit gserver.site_name string truncate in Model\GServer

2 years agoAdd explicit gserver.site_name string truncate in Model\GServer
Hypolite Petovan [Sat, 25 Jun 2022 09:28:06 +0000 (05:28 -0400)]
Add explicit gserver.site_name string truncate in Model\GServer

- Avoids "Data too long for column 'site_name'" database errors

2 years agoMerge pull request #11686 from MrPetovan/bug/11636-emailer-message-id-check
Philipp [Sat, 25 Jun 2022 09:58:23 +0000 (11:58 +0200)]
Merge pull request #11686 from MrPetovan/bug/11636-emailer-message-id-check

Fix off-by-one error in Message ID header count check in Util\Emailer

2 years agoFix off-by-one error in Message ID header count check in Util\Emailer
Hypolite Petovan [Sat, 25 Jun 2022 09:35:24 +0000 (05:35 -0400)]
Fix off-by-one error in Message ID header count check in Util\Emailer

2 years agoMerge pull request #11683 from MrPetovan/bug/fatal-errors
Tobias Diekershoff [Sat, 25 Jun 2022 09:20:33 +0000 (11:20 +0200)]
Merge pull request #11683 from MrPetovan/bug/fatal-errors

Fix a couple Fatal Errors

2 years agoUpdate default value for LocalRelationship->priority to avoid null values
Hypolite Petovan [Sat, 25 Jun 2022 09:03:02 +0000 (05:03 -0400)]
Update default value for LocalRelationship->priority to avoid null values

- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166192993

2 years agoUpdate return value type-hint of GServer::getProtocol
Hypolite Petovan [Sat, 25 Jun 2022 02:37:53 +0000 (22:37 -0400)]
Update return value type-hint of GServer::getProtocol

- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874

2 years agoMerge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null
Hypolite Petovan [Fri, 24 Jun 2022 14:15:26 +0000 (10:15 -0400)]
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null

Allowing Item::getFromUri()'s 2nd parameter a null value

2 years agoMerge pull request #11680 from nupplaphil/feat/log_forward
Hypolite Petovan [Fri, 24 Jun 2022 14:12:19 +0000 (10:12 -0400)]
Merge pull request #11680 from nupplaphil/feat/log_forward

Respect Forwarded-For headers

2 years agoChanges:
Roland Häder [Fri, 24 Jun 2022 01:14:22 +0000 (03:14 +0200)]
Changes:
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630

2 years agoMove documentation :-)
Philipp [Thu, 23 Jun 2022 21:24:15 +0000 (23:24 +0200)]
Move documentation :-)

2 years agoMove documentation :-)
Philipp [Thu, 23 Jun 2022 21:23:36 +0000 (23:23 +0200)]
Move documentation :-)

2 years agoadaptions :-)
Philipp [Thu, 23 Jun 2022 21:01:09 +0000 (23:01 +0200)]
adaptions :-)

2 years agoadd more doc
Philipp [Thu, 23 Jun 2022 20:46:46 +0000 (22:46 +0200)]
add more doc

2 years agoAdd copyright
Philipp [Thu, 23 Jun 2022 20:44:17 +0000 (22:44 +0200)]
Add copyright

2 years agoRespect Forwarded-For headers
Philipp [Thu, 23 Jun 2022 20:42:35 +0000 (22:42 +0200)]
Respect Forwarded-For headers

2 years agoMerge pull request #11679 from Quix0r/rewrites/autotest
Hypolite Petovan [Thu, 23 Jun 2022 16:41:14 +0000 (12:41 -0400)]
Merge pull request #11679 from Quix0r/rewrites/autotest

Rewrite of autotest.sh

2 years agoRewrite:
Roland Häder [Tue, 21 Jun 2022 17:38:56 +0000 (19:38 +0200)]
Rewrite:
- rewrote autotest.sh and moved it to bin/dev/ as this is clearly a developer
  script
- the rewrite's goal is towards Shell/POSIX-compliance (e.g. ${VAR} and not $VAR)

2 years agoMerge pull request #11677 from Quix0r/rewrites/type-hints-doc-001
Hypolite Petovan [Thu, 23 Jun 2022 15:34:52 +0000 (11:34 -0400)]
Merge pull request #11677 from Quix0r/rewrites/type-hints-doc-001

Rewrites/type hints doc 001

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 15:26:31 +0000 (17:26 +0200)]
Changes:
- documented null value
- two ' to much!

2 years agoNo need to log $tid here
Roland Häder [Thu, 23 Jun 2022 14:14:33 +0000 (16:14 +0200)]
No need to log $tid here

2 years agoReformatted code
Roland Häder [Thu, 23 Jun 2022 14:03:55 +0000 (16:03 +0200)]
Reformatted code

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 12:50:19 +0000 (14:50 +0200)]
Changes:
- added some nodes to OpenSearch descriptor
- still no UTF-8 encoding!
- added some type-hints

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 11:56:18 +0000 (13:56 +0200)]
Changes:
- added some type-hints
- added documentation

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 10:11:22 +0000 (12:11 +0200)]
Changes:
- added some type-hints
- changed double-quotes to single

2 years agoMore type-hints added
Roland Häder [Thu, 23 Jun 2022 09:59:37 +0000 (11:59 +0200)]
More type-hints added

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 09:57:52 +0000 (11:57 +0200)]
Changes:
- added type-hints
- added missing documentation

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 09:39:45 +0000 (11:39 +0200)]
Changes:
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single

2 years agoAdded more type-hints
Roland Häder [Thu, 23 Jun 2022 08:56:37 +0000 (10:56 +0200)]
Added more type-hints

2 years agoAdded some type-hints
Roland Häder [Thu, 23 Jun 2022 08:30:44 +0000 (10:30 +0200)]
Added some type-hints

2 years agoAdded some missing type-hints
Roland Häder [Thu, 23 Jun 2022 08:18:38 +0000 (10:18 +0200)]
Added some missing type-hints

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 08:14:18 +0000 (10:14 +0200)]
Changes:
- changed double-quotes to single
- added type-hints

2 years agoThrow IAE again (should never become visible)
Roland Häder [Thu, 23 Jun 2022 08:03:10 +0000 (10:03 +0200)]
Throw IAE again (should never become visible)

2 years agoOps, cannot return Thread?
Roland Häder [Thu, 23 Jun 2022 07:57:42 +0000 (09:57 +0200)]
Ops, cannot return Thread?

2 years agoChanged:
Roland Häder [Thu, 23 Jun 2022 07:53:46 +0000 (09:53 +0200)]
Changed:
- Introduced InvalidArgumentException (should never come)
- added type-hints

2 years agoContinued:
Roland Häder [Thu, 23 Jun 2022 07:41:37 +0000 (09:41 +0200)]
Continued:
- renamed varibales to $camelCase
- added type-hints
- updated documentation

2 years agoMerge pull request #11678 from Quix0r/fixes/send-contact-accept-id-string
Hypolite Petovan [Thu, 23 Jun 2022 15:05:38 +0000 (11:05 -0400)]
Merge pull request #11678 from Quix0r/fixes/send-contact-accept-id-string

Fix for Transmitter::sendContactAccept() wrong 2nd parameter type

2 years ago$id in Transmitter::sendContactAccept() is a string, see Introduction class
Roland Häder [Thu, 23 Jun 2022 14:46:44 +0000 (16:46 +0200)]
$id in Transmitter::sendContactAccept() is a string, see Introduction class

2 years agoMerge pull request #11676 from Quix0r/fixes/array-element-missing
Hypolite Petovan [Thu, 23 Jun 2022 13:06:59 +0000 (09:06 -0400)]
Merge pull request #11676 from Quix0r/fixes/array-element-missing

Maybe this fixes missing array element

2 years agoMerge pull request #11675 from Quix0r/features/smarty-sub-directories
Hypolite Petovan [Thu, 23 Jun 2022 13:06:06 +0000 (09:06 -0400)]
Merge pull request #11675 from Quix0r/features/smarty-sub-directories

Enabled sub-directories for compiled/cache Smarty3 files

2 years agoMaybe this fixes missing array element
Roland Häder [Thu, 23 Jun 2022 05:39:27 +0000 (07:39 +0200)]
Maybe this fixes missing array element

2 years agoSo simple ... Ops!
Roland Häder [Thu, 23 Jun 2022 02:58:16 +0000 (04:58 +0200)]
So simple ... Ops!

2 years agoChanges:
Roland Häder [Thu, 23 Jun 2022 02:23:22 +0000 (04:23 +0200)]
Changes:
- enabled sub-directories for compiled/cached files which avoids large+slow
  directory descriptors
- changed some double-quotes to single

2 years agoMerge pull request #11674 from nupplaphil/dep/guzzle
Hypolite Petovan [Wed, 22 Jun 2022 19:07:42 +0000 (15:07 -0400)]
Merge pull request #11674 from nupplaphil/dep/guzzle

Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8

2 years agoMerge pull request #9 from nupplaphil/dependabot/composer/guzzlehttp/guzzle-6.5.8
Philipp [Wed, 22 Jun 2022 18:23:38 +0000 (20:23 +0200)]
Merge pull request #9 from nupplaphil/dependabot/composer/guzzlehttp/guzzle-6.5.8

Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8

2 years agoMerge pull request #11673 from Quix0r/bugs/returned-type-array-bool
Hypolite Petovan [Wed, 22 Jun 2022 17:29:39 +0000 (13:29 -0400)]
Merge pull request #11673 from Quix0r/bugs/returned-type-array-bool

Fixed: ?? didn't work here as bool won't be seen as null

2 years agoChanged:
Roland Häder [Wed, 22 Jun 2022 16:56:08 +0000 (18:56 +0200)]
Changed:
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"

2 years agoConverted multiple single-comment (//) to multi-line comment block (/* */)
Roland Häder [Wed, 22 Jun 2022 16:06:04 +0000 (18:06 +0200)]
Converted multiple single-comment (//) to multi-line comment block (/* */)

2 years agoImages::getInfoFromURL[Cached]() will both return empty arrays on error and
Roland Häder [Wed, 22 Jun 2022 15:18:39 +0000 (17:18 +0200)]
Images::getInfoFromURL[Cached]() will both return empty arrays on error and
that needs to be reflected here, too.

2 years agoFixed: ?? didn't work here as bool won't be seen as null
Roland Häder [Wed, 22 Jun 2022 15:09:20 +0000 (17:09 +0200)]
Fixed: ?? didn't work here as bool won't be seen as null

2 years agoMerge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode
Philipp [Wed, 22 Jun 2022 14:51:23 +0000 (16:51 +0200)]
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode

2 years agoMerge pull request #11670 from Quix0r/fixes/more-type-hints-004
Hypolite Petovan [Wed, 22 Jun 2022 14:49:20 +0000 (10:49 -0400)]
Merge pull request #11670 from Quix0r/fixes/more-type-hints-004

Fixes/more type hints 004

2 years agoFixed:
Roland Häder [Wed, 22 Jun 2022 14:19:45 +0000 (16:19 +0200)]
Fixed:
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
  type string, null given, called in src/Util/XML.php line 171

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 14:13:46 +0000 (16:13 +0200)]
Changes:
- added some documentation
- fixed some documentation
- changed more double-quotes to singl

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 10:43:56 +0000 (12:43 +0200)]
Changes:
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 10:01:42 +0000 (12:01 +0200)]
Changes:
- added more type-hints
- added some documentation

2 years agoReturn empty array on error (I hope it works this way).
Roland Häder [Wed, 22 Jun 2022 09:49:54 +0000 (11:49 +0200)]
Return empty array on error (I hope it works this way).

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 09:44:56 +0000 (11:44 +0200)]
Changes:
- added more type-hints
- updated documentation
- changed double-quotes to single

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 09:35:15 +0000 (11:35 +0200)]
Changes:
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single

2 years ago$data can turn into bool here
Roland Häder [Wed, 22 Jun 2022 04:03:37 +0000 (06:03 +0200)]
$data can turn into bool here

2 years agoOps, forgot to rename these, too.
Roland Häder [Wed, 22 Jun 2022 03:54:25 +0000 (05:54 +0200)]
Ops, forgot to rename these, too.

2 years agoChanges
Roland Häder [Wed, 22 Jun 2022 03:44:57 +0000 (05:44 +0200)]
Changes
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array

2 years agoChanges:
Roland Häder [Wed, 22 Jun 2022 03:03:30 +0000 (05:03 +0200)]
Changes:
- added type-hints
- added documentation

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 21:34:14 +0000 (23:34 +0200)]
Changes:
- added more type-hints
- added missing documentation

2 years agoMerge pull request #11671 from MrPetovan/bug/fatal-errors
Tobias Diekershoff [Wed, 22 Jun 2022 12:30:39 +0000 (14:30 +0200)]
Merge pull request #11671 from MrPetovan/bug/fatal-errors

Add expected type-hint to BoundariesPager::renderFull

2 years agoAdd expected type-hint to BoundariesPager::renderFull
Hypolite Petovan [Wed, 22 Jun 2022 11:49:45 +0000 (07:49 -0400)]
Add expected type-hint to BoundariesPager::renderFull

- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199

2 years agoRemove type-hint inconsistent with expected return value in Database->getVariable
Hypolite Petovan [Wed, 22 Jun 2022 11:47:15 +0000 (07:47 -0400)]
Remove type-hint inconsistent with expected return value in Database->getVariable

2 years agoRemove email subject encoding from ItemCCEmail constructor
Hypolite Petovan [Wed, 22 Jun 2022 01:12:09 +0000 (21:12 -0400)]
Remove email subject encoding from ItemCCEmail constructor

- It was wrongly re-encoded in Emailer::send

2 years agoMerge pull request #11668 from Quix0r/renames/logger
Hypolite Petovan [Wed, 22 Jun 2022 00:52:19 +0000 (20:52 -0400)]
Merge pull request #11668 from Quix0r/renames/logger

Renamings in logger class to make them more clear

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 23:49:35 +0000 (01:49 +0200)]
Changes:
- renamed Logger::getLogger() to getInstance() (@MrPetovan)

2 years agoBump guzzlehttp/guzzle from 6.5.5 to 6.5.8
dependabot[bot] [Tue, 21 Jun 2022 20:47:00 +0000 (20:47 +0000)]
Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8

Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.5 to 6.5.8.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.8/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.5...6.5.8)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 16:40:26 +0000 (18:40 +0200)]
Changes:
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
  returned but the actual (inner) logger

2 years agoMerge pull request #11665 from Quix0r/rewrites/dba-array-string-table
Hypolite Petovan [Tue, 21 Jun 2022 19:15:57 +0000 (15:15 -0400)]
Merge pull request #11665 from Quix0r/rewrites/dba-array-string-table

Rewrites/dba array string table

2 years agoAdded important comment from @nupplaphil@github.com
Roland Häder [Tue, 21 Jun 2022 19:12:43 +0000 (21:12 +0200)]
Added important comment from @nupplaphil@github.com

2 years agoReverted and improved TODO:
Roland Häder [Tue, 21 Jun 2022 17:19:11 +0000 (19:19 +0200)]
Reverted and improved TODO:
------
@nupplaphil: There is no easy possibility to add a logger here, that's why there
isn't any yet and instead a placeholder.. This execution point is a critical
state during a testrun, and tbh I'd like to leave here no further logic (yet)
because I spent hours debugging cases, where transactions weren't fully closed
and strange/unpredictable errors occur (sometimes -mainly during debugging other
errors :) ...)
-----

2 years agoFixed documentation
Roland Häder [Tue, 21 Jun 2022 16:42:51 +0000 (18:42 +0200)]
Fixed documentation

2 years agoRewrote to suggestions from @MrPetovan (I tried to maintain the old way of
Roland Häder [Tue, 21 Jun 2022 16:11:59 +0000 (18:11 +0200)]
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of
['scheme' => 'table'] with my version).

2 years agoUse protected $this->logger instead
Roland Häder [Tue, 21 Jun 2022 15:54:23 +0000 (17:54 +0200)]
Use protected $this->logger instead

2 years agoOps, autorun.sh is there but looks like lesser "multi-project" friendly as
Roland Häder [Tue, 21 Jun 2022 15:47:11 +0000 (17:47 +0200)]
Ops, autorun.sh is there but looks like lesser "multi-project" friendly as
MYSQL_* must be defined. I might still use my version as that is
project-specific.

2 years agoOps, WWORD ...
Roland Häder [Tue, 21 Jun 2022 11:53:30 +0000 (13:53 +0200)]
Ops, WWORD ...

2 years agoAdded simple wrapper script to run PHPUnit tests for you. To use this, you need
Roland Häder [Tue, 21 Jun 2022 11:45:13 +0000 (13:45 +0200)]
Added simple wrapper script to run PHPUnit tests for you. To use this, you need
to set at least 4 variables in your ~/.bashrc (recommended):

export FRIENDICA_MYSQL_HOST="localhost"
export FRIENDICA_MYSQL_DATABASE="friendica_test"
export FRIENDICA_MYSQL_USER="friendica_test"
export FRIENDICA_MYSQL_PASSWWORD="friendica_test"

Then you can put ./bin/dev/run_tests.sh into your .git/hooks/pre-commit file

2 years agoFixed:
Roland Häder [Tue, 21 Jun 2022 11:32:04 +0000 (13:32 +0200)]
Fixed:
- PHPUnit\Framework\Error\Notice:  Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 11:21:33 +0000 (13:21 +0200)]
Changes:
- let's at least log the error message, yes it does flood your logfile

2 years agoChanges:
Roland Häder [Tue, 21 Jun 2022 11:04:05 +0000 (13:04 +0200)]
Changes:
- Database->$driver can no longer be NULL, an empty string is fine anyway

2 years agoFixed:
Roland Häder [Tue, 21 Jun 2022 10:43:24 +0000 (12:43 +0200)]
Fixed:
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
  can be found in it

2 years agoWIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?
Roland Häder [Tue, 21 Jun 2022 10:09:51 +0000 (12:09 +0200)]
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?