]>
git.mxchange.org Git - friendica.git/log
Roland Haeder [Sat, 1 Apr 2017 19:46:57 +0000 (21:46 +0200)]
added spaces + used x ()
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 19:04:08 +0000 (21:04 +0200)]
Continued with CR:
- added spaces as requested
- removed parentheses from include/require calls as they are no functions
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:55:50 +0000 (20:55 +0200)]
space-time contines ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:52:32 +0000 (20:52 +0200)]
space-time!
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:51:18 +0000 (20:51 +0200)]
Continued a bit:
- converted multiple single-line comments into one multi-line comment
- added spaces (space-time!)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:49:43 +0000 (20:49 +0200)]
added space, marked rest 86 occurrences in todos.txt
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:47:23 +0000 (20:47 +0200)]
added spaces, marked in todos.txt as usual
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:44:38 +0000 (20:44 +0200)]
$tagged is being initialized but not written to until the foreach() loop is
being executed. Maybe here is old-lost code anyway?
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:41:32 +0000 (20:41 +0200)]
Continued a bit:
- added 'array' type-hint which is valid for many versions back
- added spaces as requested by CR
- removed $a = get_app(); call, $a was no longer needed here
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:36:01 +0000 (20:36 +0200)]
Continued a bit:
- recommended way is to use foreach() instead of own looping through arrays
- even when you need the index:
<?php
foreach ($someArray as $key => $value) {
// Handle $key/$value somehow
}
?>
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:32:52 +0000 (20:32 +0200)]
added spaces (space-time!) and TODO that x() is maybe proper way?
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:30:21 +0000 (20:30 +0200)]
Continued a bit:
- removed parentheses from include/require as they are no functions
- added type-hint for $a which is unused btw.
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 31 Mar 2017 18:05:15 +0000 (20:05 +0200)]
fixed parser error
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:51:31 +0000 (21:51 +0200)]
whoops, parser error fixed
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:50:19 +0000 (21:50 +0200)]
it is space-time! ;-)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:48:46 +0000 (21:48 +0200)]
merged 2 if() into one three times
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:45:35 +0000 (21:45 +0200)]
merged 2 if() into one as requested by CR
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:44:32 +0000 (21:44 +0200)]
added spaces + removed parentheses (include/require are no functions)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:42:00 +0000 (21:42 +0200)]
added spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:38:22 +0000 (21:38 +0200)]
removed old-lost code by CR request
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:36:34 +0000 (21:36 +0200)]
Please use x() correctly:
<?php
if (x($someArray, 'element')) {
// Do something
}
?>
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 19:32:12 +0000 (21:32 +0200)]
Continued a bit:
- added spaces / curly braces
- converted multiple single-line comments into one multi-line comment
- used more dbm::is_result()
- include/require are no functions, let's not abuse them ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 18:33:38 +0000 (20:33 +0200)]
space to the rescue ... ;-) CR request
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 18:30:23 +0000 (20:30 +0200)]
it is ... SPACE TIME! ;-)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 18:26:36 +0000 (20:26 +0200)]
removed old-lost code by CR request + spaces added ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 18:24:55 +0000 (20:24 +0200)]
removed commented-out by CR request + it is ... SPACE TIME! ;-)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 30 Mar 2017 18:22:03 +0000 (20:22 +0200)]
spaces added according code convention and CR + fixed tzpo in function name (opps)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 20:21:50 +0000 (21:21 +0100)]
used ltrim() for removing (any) trailing space
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 20:19:52 +0000 (21:19 +0100)]
added spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 17:32:33 +0000 (18:32 +0100)]
strange that this curly brace didn't make it in. now it is, thanks to @annando
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 17:32:11 +0000 (18:32 +0100)]
some spaces ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 14:13:28 +0000 (15:13 +0100)]
and without self:: ;-(
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 14:12:24 +0000 (15:12 +0100)]
there is already $this->backend around, needs renaming
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 13:57:40 +0000 (14:57 +0100)]
fixed another parser error, opps
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 13:56:23 +0000 (14:56 +0100)]
Opps, fixed parser error. indending was confusing here
+ added much more curly braces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 13:32:49 +0000 (14:32 +0100)]
rewrote for() loop to foreach() + added curly braces/spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 13:07:26 +0000 (14:07 +0100)]
Continued:
- added curly braces/spaces
- converted multiple single-line comments into one multi-line comment
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:56:56 +0000 (13:56 +0100)]
Convention:
- comment blocks with 2 stars at beinging are doc-tags, with only star is a
regular multi-line comment
- added curly braces + spaces
- removed TODO, there needs to be a way of writing this better than using @
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:46:28 +0000 (13:46 +0100)]
was a bit confusing for me or I was not sleeping to much ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:40:43 +0000 (13:40 +0100)]
don't kill when no result is found, this may break communication, thanks to @annando explaining it
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:37:15 +0000 (13:37 +0100)]
PHP5 does not support native type-hints, except `array` + used dbm::is_result()
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:33:15 +0000 (13:33 +0100)]
fixed indending + closed own internal todo: better usage of x()
removed todo
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:30:12 +0000 (13:30 +0100)]
closed internal TODO, added parentheses as this is a minimized if/else block
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:27:38 +0000 (13:27 +0100)]
added a space
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:25:33 +0000 (13:25 +0100)]
Continued:
- added spaces
- made a code block even
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:22:39 +0000 (13:22 +0100)]
Continued:
- used dbm::is_result() to avoid E_WARNING when false is returned
- added curly braces + some spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:18:28 +0000 (13:18 +0100)]
added spaces and curly braces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:14:50 +0000 (13:14 +0100)]
Continued:
- added curly braces/spaces
- changed lower-case SQL keywords to upper-case
- used dbm::is_result() instead of count() (avoids warning in case of false is
returned)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:12:25 +0000 (13:12 +0100)]
removed old-lost code + internal TODO closed
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:08:38 +0000 (13:08 +0100)]
merged 2 if() into one, closes internal TODO
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:07:19 +0000 (13:07 +0100)]
removed parentheses, added curly ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 12:01:41 +0000 (13:01 +0100)]
removed TODO, one day this all needs refacturizing ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 11:59:37 +0000 (12:59 +0100)]
rewrote to static approach and if() condition can be simplified.
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 11:55:13 +0000 (12:55 +0100)]
removed parentheses and indended it for better readability
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 11:53:01 +0000 (12:53 +0100)]
added spaces/curly braces and TODO for better using trim()
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 11:49:09 +0000 (12:49 +0100)]
removed old-lost code
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 11:47:31 +0000 (12:47 +0100)]
changed "and" -> && according to CR
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Sat, 25 Mar 2017 11:43:07 +0000 (12:43 +0100)]
added spaces, removed parentheses. there is more ahead than just this one.
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 21:44:18 +0000 (22:44 +0100)]
space-time season continues ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 21:40:25 +0000 (22:40 +0100)]
it is space-time! ;-)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 21:36:13 +0000 (22:36 +0100)]
added more spaces (CR request)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 21:33:57 +0000 (22:33 +0100)]
added more curly braces/spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 20:17:00 +0000 (21:17 +0100)]
killme() does the same here + added curly braces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 20:15:14 +0000 (21:15 +0100)]
Opps, became lazy here, thanks to @Hypolite finding it.
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 20:08:03 +0000 (21:08 +0100)]
Continued:
- some spaces added
- removed parentheses as requested by @Hypolite
- added really important TODO as remote-inclusion is not what you want
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 20:05:08 +0000 (21:05 +0100)]
removed parentheses + added TODO about a small rewrite
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 19:57:52 +0000 (20:57 +0100)]
Continued:
- marked commented-out code as possible old-lost
- added more curly braces
- used more dbm::is_result() where SELECT is stated
- ! added quotes in array element, else (here) >thumb< (without quotes) is
considered as a constant and causes an E_NOTICE
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 19:50:10 +0000 (20:50 +0100)]
fixed parser error
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Fri, 24 Mar 2017 19:39:00 +0000 (20:39 +0100)]
Continued:
- converted multiple single-line comments into one multi-line comment (please
stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 22:37:58 +0000 (23:37 +0100)]
fixed comment and explained one
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 22:07:29 +0000 (23:07 +0100)]
Continued with #3254:
- added curly braces + spaces
- converted multiple single-line comments to one multi-line comment
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 22:05:53 +0000 (23:05 +0100)]
added more curly braces + spaces for #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 22:01:04 +0000 (23:01 +0100)]
Continued #3254:
- thrown out old lost-code
- add curly braces (not curely ;-) ) and spaces
- exit is not a keyword, it is a function, so use () here
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:51:52 +0000 (22:51 +0100)]
added curely braces + TODO for maybe avoiding multi-lined if() blocks as it confuses #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:49:05 +0000 (22:49 +0100)]
old behaviour restored
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:43:46 +0000 (22:43 +0100)]
added more spaces and curely braces
killed ?> as it is discouraged
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:33:12 +0000 (22:33 +0100)]
added curely branches + reverted back to old behaviour (may come back one day)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:26:07 +0000 (22:26 +0100)]
better comment added by @Hypolite
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:22:18 +0000 (22:22 +0100)]
more spaces added (CR by @Hypolite)
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:19:10 +0000 (22:19 +0100)]
it is space-season ... ;-) #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:16:04 +0000 (22:16 +0100)]
closed internal TODO, merged 2 if() to one + added spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:12:51 +0000 (22:12 +0100)]
yet another one removed, thanks to @Hypolite for CR
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:10:37 +0000 (22:10 +0100)]
removed no longer old stuff, let's don't stuff code with commented-out code
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 21:08:33 +0000 (22:08 +0100)]
added more spaces #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 20:46:49 +0000 (21:46 +0100)]
No parantheses here + no @ (which surpresses warnings and such) #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 20:45:00 +0000 (21:45 +0100)]
Opps, missed one ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 20:39:03 +0000 (21:39 +0100)]
added curly braces #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Haeder [Thu, 23 Mar 2017 19:48:48 +0000 (20:48 +0100)]
replaced some tabs -> spaces + added curly braces #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
Roland Häder [Thu, 26 Jan 2017 13:28:43 +0000 (14:28 +0100)]
added missing spaces/curly braces
Signed-off-by: Roland Häder <roland@mxchange.org>
Roland Häder [Thu, 26 Jan 2017 08:38:52 +0000 (09:38 +0100)]
Continued:
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
long time around in PHP) anything can be handled over to the method/function.
Signed-off-by: Roland Häder <roland@mxchange.org>
Roland Häder [Wed, 25 Jan 2017 14:59:27 +0000 (15:59 +0100)]
added more curly braces + a bit more usage of dbm::is_result()
Signed-off-by: Roland Häder <roland@mxchange.org>
Hypolite Petovan [Tue, 21 Mar 2017 16:04:19 +0000 (12:04 -0400)]
Merge pull request #3253 from friendica/revert-3112-rewrites/coding-convention
Revert "Coding convention applied - part 1"
Hypolite Petovan [Tue, 21 Mar 2017 16:02:59 +0000 (12:02 -0400)]
Revert "Coding convention applied - part 1"
Hypolite Petovan [Tue, 21 Mar 2017 14:19:53 +0000 (10:19 -0400)]
Merge pull request #3112 from Quix0r/rewrites/coding-convention
Coding convention applied - part 1
Tobias Diekershoff [Tue, 21 Mar 2017 06:27:10 +0000 (07:27 +0100)]
Merge pull request #3246 from annando/1701-poco
Split poco discovery in smaller function calls
Roland Haeder [Mon, 20 Mar 2017 19:51:32 +0000 (20:51 +0100)]
Merge remote-tracking branch 'upstream/develop' into rewrites/coding-convention
Signed-off-by: Roland Haeder <roland@mxchange.org>
Hypolite Petovan [Mon, 20 Mar 2017 17:18:18 +0000 (13:18 -0400)]
Merge pull request #3241 from rabuzarus/20170316_-_fix_event_edit
add dop event & fix event edit
rabuzarus [Mon, 20 Mar 2017 16:19:24 +0000 (17:19 +0100)]
add missed NULL_DATE
rabuzarus [Mon, 20 Mar 2017 16:16:39 +0000 (17:16 +0100)]
Merge origin/20170316_-_fix_event_edit into 20170316_-_fix_event_edit
Conflicts:
mod/events.php
rabuzarus [Mon, 20 Mar 2017 15:59:21 +0000 (16:59 +0100)]
add NULL_DATE & coding standard work