Continued:
- disable all warnings and errors, generally bad, but here neccessarry until
  this whole thing has been rewritten to something better
- also disable some interfering settings from Xdebug

Signed-off-by: Roland Häder <roland@mxchange.org>

re-added doc-tag and removed double-declaration

Signed-off-by: Roland Haeder <roland@mxchange.org>

was renamed for security reasons

Signed-off-by: Roland Haeder <roland@mxchange.org>

fixed parser error (opps)
and no need for `some foo bar`, use $(some foo bar)

Signed-off-by: Roland Haeder <roland@mxchange.org>

Better check on object (use instanceof wherever possible)

Signed-off-by: Roland Haeder <roland@mxchange.org>

Rewrite this API-usage or at least keep backticks in for SQL-compatiblity.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Cannot use NoticeListemItem as type-hint as NoticeListItemAdapter exists.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Opps, don't miss this here ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for StartMakeEntryForm and renamed $out to $action

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for StartShowEntryForms hook

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for adaptNoticeListItem() method

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for constructor of NoticeTreeItem class

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for StartShowNoticeFormData hook

Signed-off-by: Roland Haeder <roland@mxchange.org>

Last type-hint is an array, added.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing type-hints for EndRssEntryArray hooks.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing type-hints for EndNoticeSave(Web) (different).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for EndShowNoticeOptionItems hooks.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for EndNoticeInScope hook.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing type-hint for EndPublicGroupNav (it is Menu).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for StartHostMetaLinks hook

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing type-hint for StartShowHTML hook

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for StartNoticeSourceLink hooks.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added type-hint for RedirectToLogin hooks. Please note that User $user=null
must beused as one call sets null for $user parameter.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Introduced common_location_shared() to check if location sharing is always,
never or by-user enabled. This commit also excluded geometa.js if location
sharing is for any reason disabled as this loads an external reference from
Google.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Save some else blocks that makes the code just more complex.

Signed-off-by: Roland Haeder <roland@mxchange.org>

A bit better test.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Backward-compatiblity hack for PHP 5.4 installations.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Found these missing, still there is one that says 'Action' as type-hint. Please investigate.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added new 'Scroller' plugin from @buttle which aims to replace the out-dated
'InfiniteScroll' plugin.

Signed-off-by: Roland Haeder <roland@mxchange.org>

.inc.php please ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

.inc files are mostly readable from the internet, e.g. http://example.org/some/file.inc and should be avoided.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Re-added code from upstream (opps).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Correct content now ... :-(

Signed-off-by: Roland Haeder <roland@mxchange.org>

*** Privacy Leak fixed: ***
- isCurrentProfileInScope() is now more asked if the current profile is allowed
  to see the given notice. It was possible (with upstream master) to see private
  messages in RSS and (possible) JSON feeds

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing isPrivateScope().

Signed-off-by: Roland Haeder <roland@mxchange.org>

Misses this file to merge. I like the comments.

Signed-off-by: Roland Haeder <roland@mxchange.org>

No more needed (for this fix) but maybe later. So I always only comment them out.

Signed-off-by: Roland Haeder <roland@mxchange.org>

typo fixed ...

Signed-off-by: Roland Haeder <roland@mxchange.org>

Opps, PEAR sucks. Need to call find() before fetch() ... :-(

Signed-off-by: Roland Haeder <roland@mxchange.org>

Needed to add notice_id to selected fields ... :-(

Signed-off-by: Roland Haeder <roland@mxchange.org>

fetch() must work to get this check passed.

Signed-off-by: Roland Haeder <roland@mxchange.org>

??? Not Notice_tag?

Signed-off-by: Roland Haeder <roland@mxchange.org>

??? Not callable?

Signed-off-by: Roland Haeder <roland@mxchange.org>

Introduced isCurrentProfileInScope() which shall check if current profile is
allowed (in scope of) to see the tag.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Grrr, not fixed. So adding debug lines.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Possible hack for tags from private dents in public profile or wrong scope (both privacy leak).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Profile::current() suits better here.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Save some memory + added type-hint.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added debug lines, the first attempt didn't work and I have *no* development system now. :-(

Signed-off-by: Roland Haeder <roland@mxchange.org>

Check scope, else a privacy leaks happens this way:

1) Bob and Alice follow each other and write private notices
   (this->scope=2) to each other.
2) Bob uses tags in his private notice to alice (which she can
   read from him).
3) Alice adds that notice (with tags) to her favorites
   ("faving") it.
4) The tags from Bob's private notice becomes visible in Alice's
   profile.

This has the simple background that the scope is not being
re-checked. This has to be done here at this point because given
above scenario is a privacy leak as the tags may be *really*
private (nobody else shall see them) such as initmate words or
very political words.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added checked type-hints

Signed-off-by: Roland Haeder <roland@mxchange.org>
Conflicts:
classes/Notice.php

Signed-off-by: Roland Haeder <roland@mxchange.org>

'checked' must be false because else the browser won't send any location and it is better for privacy ... :-)

Signed-off-by: Roland Haeder <roland@mxchange.org>

onArgsInitialize() wants an array and many plugins want to add more elements, so make it everywhere the same.

Signed-off-by: Roland Haeder <roland@mxchange.org>

rand() is weak on some OSes as it only produces random numbers from -32766 to
32766. So let's get rid of it all together and use mt_rand() (which produces
*way* larger numbers on *all* systems).

Signed-off-by: Roland Haeder <roland@mxchange.org>
Conflicts:
lib/noticeform.php

Signed-off-by: Roland Haeder <roland@mxchange.org>

Make attachment fit better in notice: drop text and link

Added more checked type-hints

Signed-off-by: Roland Haeder <roland@mxchange.org>

$related must contain class names, no table names ("all" lower-case) + fixed some checked type-hints.

Again, it must be User_flag_profile (class name), not user_flag_profile (table name).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Fixed more type-hints for safety.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Type-hint 'Action' for onEndProfileSettingsActions()

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added @pztrn@sn.pztrn.name 's wonderful statistics plugin as GIT module and linked all relevant files.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing method TagSub::getProfile()

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added missing SearchSub::getProfile() method.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added fixup script to fix bad profile URLs:

https://social.mxchange.org/conversation/83342#notice-83342

"I have written a small fixup script that fixes invalid profile URLs: If the
group is a remote group but #profileurl shows to
https://your.instance.tld/group/groupname then the profileurl field must be
fixed. cc !gnusocial I will commit it very soon."

Signed-off-by: Roland Haeder <roland@mxchange.org>

$sender cannot be only Profile ... (false found).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Maybe this message will be needed some day ...

Signed-off-by: Roland Häder <haeder@hmmdeutschland.de>

Fixed:
-----------------------------
Argument 2 passed to Ostatus_profile::notifyDeferred() must be an
instance of Profile, instance of User given, called in
/var/www/htdocs/plugins/OStatus/lib/ostatusqueuehandler.php on line 156 and
defined (/var/www/htdocs/plugins/OStatus/classes/Ostatus_profile.php:363)
[ABORT]
-----------------------------
getProfile() must be called on this->user

Plus fixed/added some type-hints.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Reoved another to strict type-hint + added check if $args is no array. In this
case the below foreach() is unneccessary as the if() block in it will never
match.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added asserts + remove wrong type-hint (was no array).

Signed-off-by: Roland Haeder <roland@mxchange.org>

Fixed ;-)

Signed-off-by: Roland Haeder <roland@mxchange.org>

Improved type-hint for following methods:
- handle
- isReadOnly
- prepare

Signed-off-by: Roland Haeder <roland@mxchange.org>

Adding htaccess.sample back*shame*

oops, DB.txt O_o

Add urlshortenerplugin2.php to solve some @todo's and adding exceptions

Improved type-hint for following methods:
- handle
- isReadOnly
- prepare

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added some (good known) type-hints.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Possible fix for https://bugz.foocorp.net/T41

Signed-off-by: Roland Haeder <roland@mxchange.org>

No need for php interpreter again as this script is executable.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Fixed CHMOD.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Added additional check.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Fixes for making Meteor working with HTTPS.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Usefull line for debugging added.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Check for valid database connection object.

Signed-off-by: Roland Haeder <roland@mxchange.org>

Adding htaccess.sample back*shame*

[LinkPreview] Fix 'no candidate for action "embedproxy"'

[CORE] Fix subscription-related functions from the Profile class

The undifined variable $private_stream, from the User class, was causing
undifined behavior from calling requiresSubscriptionApproval. The is_null
test was added to fix this problem.

[DOCUMENTATION][SYSADMIN][CONFIGURE] x-static-delivery was in the wrong section

[NodeInfo] New endpoint and formula for computing active users
Seriously improved documentation
Now NodeInfo 2.0 is available at /api/nodeinfo/2.0.json
For active users we now also consider favourites and recently created accounts
Some further minor bug fixes and full review of the implementation

[DOCUMENTATION] Late update of CHANGELOG and TODO list

[DOCUMENTATION][SYSADMIN][CONFIG][profile] Fix default of backup and restore options

[REFACTOR] Added explicit return type to all instances of QueueHandler::handle

[CORE][QUEUE] Error checking and type declaration on handling notice queue events

Patch submitted by XRevan86

[PEAR][DB] Import some new commits
Patch submitted by XRevan86

[DB/pgsql.php] Change pg_exec to pg_query
Encouraged by http://php.net/manual/en/function.pg-query.php and enables
improved monitoring by New Relic (https://newrelic.com)
[DB.php] changed count to empty for php7.2
[DB/common.php] change to array cast for php72

From: https://github.com/pear/DB/
Commits: 7d0ddaff, d04a42a5 and ea9fff4a, respectively

[EXTLIB][VALIDATE] Fix some types

[DOCUMENTATION] Added X-Sendfile/X-Accel-Redirect to the sample nginx and apache config files

[DOCUMENTATION] Add versioning information
Some other minor improvements and a bug fix in the boilerplate

[Embed] Fixed error related to oembed action

[DOCUMENTATION] Fix nginx location rule's regex for install and index

Merge branch 'master' of biodantas/gnu-social into master

[MEDIA] Fixed wrong image cropping

[MEDIA] Replaced internal image handling with intervention/image, which is capable of using both GD and ImageMagik